Add lock checks in delete functions of disk and config resources (#2237)

* Add checks for disks and config to prevent a locked Linode from being in an undesired state (shutdown) during deletion attempts

* Update linode/instancedisk/framework_resource.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update linode/instancedisk/framework_resource.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: zliang-akamai

linode/helper/instance.go

@@ -6,6 +6,7 @@ import (
 	"encoding/base64"
 	"encoding/json"
 	"fmt"
+	"slices"
 	"time"
 
 	fwdiag "github.com/hashicorp/terraform-plugin-framework/diag"
@@ -506,3 +507,18 @@ func WaitForInstanceNonTransientStatus(
 
 	return instance.Status, nil
 }
+
+// LinodeIsLockedWithCannotDeleteSubresources checks if a Linode instance
+// has the CannotDeleteWithSubresources lock type.
+func LinodeIsLockedWithCannotDeleteSubresources(
+	ctx context.Context,
+	client *linodego.Client,
+	linodeID int,
+) (locked bool, err error) {
+	linode, err := client.GetInstance(ctx, linodeID)
+	if err != nil {
+		return
+	}
+
+	return slices.Contains(linode.Locks, linodego.LockTypeCannotDeleteWithSubresources), nil
+}

linode/instanceconfig/resource.go

@@ -345,6 +345,19 @@ func deleteResource(ctx context.Context, d *schema.ResourceData, meta any) diag.
 		return diag.Errorf("Error finding the specified Linode Instance: %s", err)
 	}
 
+	locked, err := helper.LinodeIsLockedWithCannotDeleteSubresources(ctx, &client, linodeID)
+	if err != nil {
+		return diag.Errorf("failed to get locks of Linode: %s", err)
+	}
+
+	if locked {
+		return diag.Errorf(
+			"can't delete config %d in Linode %d: the resource lock on the Linode prohibits deletion "+
+				"of its subresources, which includes this config",
+			id, linodeID,
+		)
+	}
+
 	// Shutdown the instance if the config is in use
 	if booted, err := isConfigBooted(ctx, &client, inst, id, d.Get("booted").(bool)); err != nil {
 		return diag.Errorf("failed to check if config is booted: %s", err)

linode/instancedisk/framework_resource.go

@@ -334,6 +334,21 @@ func (r *Resource) Delete(
 		return
 	}
 
+	locked, err := helper.LinodeIsLockedWithCannotDeleteSubresources(ctx, client, linodeID)
+	if err != nil {
+		resp.Diagnostics.AddError("Failed to Get Locks of Linode", err.Error())
+		return
+	}
+
+	if locked {
+		resp.Diagnostics.AddError(
+			fmt.Sprintf("Can't Delete Disk %d in Linode %d", id, linodeID),
+			"the resource lock on the Linode prohibits deletion "+
+				"of its subresources, which includes this disk",
+		)
+		return
+	}
+
 	deleteTimeout, diags := state.Timeouts.Delete(ctx, DefaultVolumeDeleteTimeout)
 	resp.Diagnostics.Append(diags...)
 	if resp.Diagnostics.HasError() {