Fix firewall_id handling in LKE node pools

Author: zliang-akamai

linode/lke/schema_resource.go

@@ -133,6 +133,7 @@ var resourceSchema = map[string]*schema.Schema{
 					Type:        schema.TypeInt,
 					Description: "The ID of the Firewall to attach to nodes in this node pool.",
 					Optional:    true,
+					Computed:    true,
 				},
 				"labels": {
 					Type: schema.TypeMap,

linode/lkenodepool/framework_models.go

@@ -149,9 +149,11 @@ func (pool *NodePoolModel) SetNodePoolCreateOptions(
 	)
 	p.Type = pool.Type.ValueString()
 	p.Label = pool.Label.ValueStringPointer()
-	if !pool.FirewallID.IsUnknown() && !pool.FirewallID.IsNull() {
-		id := pool.FirewallID.ValueInt64()
-		p.FirewallID = linodego.Pointer(int(id))
+	if !pool.FirewallID.IsUnknown() {
+		p.FirewallID = helper.FrameworkSafeInt64PointerToIntPointer(pool.FirewallID.ValueInt64Pointer(), diags)
+		if diags.HasError() {
+			return
+		}
 	}
 
 	if !pool.Tags.IsNull() {
@@ -205,9 +207,11 @@ func (pool *NodePoolModel) SetNodePoolUpdateOptions(
 	}
 
 	if !state.FirewallID.Equal(pool.FirewallID) {
-		if !pool.FirewallID.IsUnknown() && !pool.FirewallID.IsNull() {
-			id := pool.FirewallID.ValueInt64()
-			p.FirewallID = linodego.Pointer(int(id))
+		if !pool.FirewallID.IsUnknown() {
+			p.FirewallID = helper.FrameworkSafeInt64PointerToIntPointer(pool.FirewallID.ValueInt64Pointer(), diags)
+			if diags.HasError() {
+				return false
+			}
 		}
 		// else: do NOT set p.FirewallID at all
 		shouldUpdate = true