Fix coder workspaces refresh

Change codespaces and workspaces checks to check if
gh and coder are in path and authenticated.
Instead of waiting for workspaces to be configured.

Author: ananthb

internal/config/config.go

@@ -382,57 +382,6 @@ func (c *Config) effectiveWorkspaceProviderLocked() string {
 	return c.WorkspaceProvider
 }
 
-// IsCoderConfigured reports whether Coder is in use anywhere in the
-// config: as the effective provider, or via any target that declares a
-// `coder` block. Used to keep the Coder menu visible whenever the user
-// has wired up Coder, even if the API call failed on the last poll.
-func (c *Config) IsCoderConfigured() bool {
-	if c == nil {
-		return false
-	}
-	c.mu.RLock()
-	defer c.mu.RUnlock()
-	// NOTE: cannot import provider package due to import cycle
-	// (provider imports config). Keep this literal in sync with
-	// provider.NameCoder.
-	if c.effectiveWorkspaceProviderLocked() == "coder" {
-		return true
-	}
-	for _, t := range c.Targets {
-		if t.Coder != nil {
-			return true
-		}
-	}
-	return false
-}
-
-// IsGitHubConfigured reports whether GitHub Codespaces is in use:
-// either as the effective provider (the default), or via any target
-// that doesn't declare a `coder` block.
-//
-// Note the asymmetry with IsCoderConfigured: GitHub is the default
-// provider, so the absence of an explicit `coder` block on a target
-// makes that target an implicit GitHub target. A nil Config (no file
-// loaded yet) is therefore treated as "GitHub configured", which lets
-// the Codespaces tray submenu appear during early startup. Coder, by
-// contrast, only counts when targets opt in explicitly via t.Coder.
-func (c *Config) IsGitHubConfigured() bool {
-	if c == nil {
-		return true
-	}
-	c.mu.RLock()
-	defer c.mu.RUnlock()
-	if c.effectiveWorkspaceProviderLocked() == "github" {
-		return true
-	}
-	for _, t := range c.Targets {
-		if t.Coder == nil {
-			return true
-		}
-	}
-	return false
-}
-
 func (t Target) ExplicitWorkspaceName(provider string) string {
 	// NOTE: cannot import provider package due to import cycle
 	// (provider imports config). Keep this literal in sync with

internal/daemon/poller.go

@@ -179,12 +179,9 @@ func (d *Daemon) runPoll() {
 		return codespacesToWorkspaces(cs), nil
 	})
 
-	var coderWorkspaces []provider.Workspace
-	if d.Cfg != nil && d.Cfg.IsCoderConfigured() {
-		coderWorkspaces = d.pollProvider(provider.NameCoder, "coder", func(ctx context.Context) ([]provider.Workspace, error) {
-			return provider.NewCoderManager(d.Cfg).ListAllWorkspacesCtx(ctx)
-		})
-	}
+	coderWorkspaces := d.pollProvider(provider.NameCoder, "coder", func(ctx context.Context) ([]provider.Workspace, error) {
+		return provider.NewCoderManager(d.Cfg).ListAllWorkspacesCtx(ctx)
+	})
 
 	workspaces := append(ghWorkspaces, coderWorkspaces...)
 

internal/daemon/tray.go

@@ -118,7 +118,7 @@ func (d *Daemon) buildTrayMenu() *fyne.Menu {
 
 func (d *Daemon) githubCodespacesMenu() *fyne.MenuItem {
 	all := d.Codespaces()
-	if len(all) == 0 && !d.Cfg.IsGitHubConfigured() {
+	if len(all) == 0 && !provider.IsGitHubAvailable() {
 		return nil
 	}
 
@@ -196,8 +196,7 @@ func githubStatusMessage(status ProviderStatus) string {
 
 func (d *Daemon) coderWorkspaceMenu() *fyne.MenuItem {
 	workspaces := filterWorkspacesByProvider(d.Workspaces(), provider.NameCoder)
-	configured := d.Cfg != nil && d.Cfg.IsCoderConfigured()
-	if len(workspaces) == 0 && !configured {
+	if len(workspaces) == 0 && !provider.IsCoderAvailable() {
 		return nil
 	}
 

internal/provider/availability.go

@@ -0,0 +1,37 @@
+package provider
+
+import (
+	"context"
+	"os/exec"
+	"time"
+)
+
+// availabilityProbeTimeout caps the local auth probe so a misbehaving
+// CLI (network stall, hung SSO) can't pin a tray rebuild or UI gate.
+const availabilityProbeTimeout = 5 * time.Second
+
+// IsGitHubAvailable reports whether the `gh` CLI is on PATH and the
+// user is authenticated for codespace operations. Implemented as
+// `gh auth status` because it's the cheapest signal that catches both
+// "CLI missing" and "not logged in" without making a Codespaces API
+// call. False also covers token-scope problems that gh auth surfaces.
+func IsGitHubAvailable() bool {
+	if _, err := exec.LookPath("gh"); err != nil {
+		return false
+	}
+	ctx, cancel := context.WithTimeout(context.Background(), availabilityProbeTimeout)
+	defer cancel()
+	return exec.CommandContext(ctx, "gh", "auth", "status").Run() == nil
+}
+
+// IsCoderAvailable reports whether the `coder` CLI is on PATH and has
+// a working session. Implemented as `coder whoami` — fast, hits the
+// configured Coder server only enough to validate the session token.
+func IsCoderAvailable() bool {
+	if _, err := exec.LookPath("coder"); err != nil {
+		return false
+	}
+	ctx, cancel := context.WithTimeout(context.Background(), availabilityProbeTimeout)
+	defer cancel()
+	return exec.CommandContext(ctx, "coder", "whoami").Run() == nil
+}

internal/tui/applet_create.go

@@ -99,11 +99,13 @@ func newCreateModel(d *AppletData) createModel {
 		}
 	}
 
-	// Default provider selection. Prefer whichever is configured; if both
-	// are, default to GitHub but allow toggling. The provider row is
-	// hidden when only one is in play.
-	gh := cfg.IsGitHubConfigured()
-	cd := cfg.IsCoderConfigured() && len(m.coderTargets) > 0
+	// Default provider selection. Prefer whichever provider is available
+	// (CLI + auth); if both are, default to GitHub but allow toggling.
+	// The provider row is hidden when only one is in play. Coder also
+	// requires at least one Coder-tagged target since create needs a
+	// template selector.
+	gh := provider.IsGitHubAvailable()
+	cd := provider.IsCoderAvailable() && len(m.coderTargets) > 0
 	switch {
 	case gh && cd:
 		m.providerName = provider.NameGitHub

internal/tui/applet_data.go

@@ -166,7 +166,7 @@ func (d *AppletData) Poll() PollResult {
 	var combined []provider.Workspace
 	var firstErr error
 
-	if d.cfg.IsGitHubConfigured() {
+	if provider.IsGitHubAvailable() {
 		ws, cs, err := d.pollGitHub()
 		d.setProviderStatus(provider.NameGitHub, "gh", err)
 		if err != nil && firstErr == nil {
@@ -177,7 +177,7 @@ func (d *AppletData) Poll() PollResult {
 		d.mu.Unlock()
 		combined = append(combined, ws...)
 	}
-	if d.cfg.IsCoderConfigured() {
+	if provider.IsCoderAvailable() {
 		ws, err := d.pollCoder()
 		d.setProviderStatus(provider.NameCoder, "coder", err)
 		if err != nil && firstErr == nil {