Fix warnings

notify_test always compiled the FAN_FS_ERROR report helper and counter even when configure disabled FAN_FS_ERROR support. In that configuration the test body using them is omitted, leaving the helper and variable unused.

The FAN_FS_ERROR-only helper and counter are now guarded by TEST_HAVE_FAN_FS_ERROR, matching the guarded assertions that use them. free_language_mimes now consumes the avl_remove return value and frees the removed node, satisfying the warn_unused_result contract without changing ownership.

Author: stevegrubb

src/cli/ignore-mounts.c

@@ -266,10 +266,13 @@ static int insert_language_mime(avl_tree_t *languages, const char *mime)
 static void free_language_mimes(avl_tree_t *languages)
 {
 	while (languages->root) {
-		struct language_entry *entry =
-			(struct language_entry *)languages->root;
+		struct language_entry *entry;
+
+		entry = (struct language_entry *)
+			avl_remove(languages, languages->root);
+		if (entry == NULL)
+			break;
 
-		avl_remove(languages, &entry->avl);
 		free(entry->mime);
 		free(entry);
 	}

src/tests/notify_test.c

@@ -163,6 +163,7 @@ static void read_operating_mode_report(char *buf, size_t size)
 	fclose(f);
 }
 
+#if TEST_HAVE_FAN_FS_ERROR
 /*
  * read_fs_error_report - capture recent FAN_FS_ERROR detail output.
  * @buf: destination buffer.
@@ -184,6 +185,7 @@ static void read_fs_error_report(char *buf, size_t size)
 	buf[used] = 0;
 	fclose(f);
 }
+#endif
 
 /*
  * test_operating_mode_report_order - verify state field order.
@@ -346,7 +348,9 @@ int main(void)
 	};
 	unsigned long before, after;
 	unsigned long overflow_after, reply_after;
+#if TEST_HAVE_FAN_FS_ERROR
 	unsigned long fs_error_after = 0;
+#endif
 	char report[4096], expected[128];
 	int event_pipe[2];