nvme/044 is skipped because `_have_driver dh_generic` fails

[igaw]

nvme/044 is not executed in my setup because the requirement _have_driver dh_generic fails. I've configured all modules as built-in.

  _have_driver dh_generic

Shouldn't this be instead

   _have_kernel_option CRYPTO_DH

?

I still wonder how _have_driver dh_generic does work on my distro. modprobe dh_generic does not complain that the module doesn't exist:

# modprobe dh_generic
# echo $?
0
# lsmod | grep dh_generic
#

Anyway, with _have_kernel_option it seems to work correctly. Should I post a PR?

[igaw]

It could be that in my test setup is not complete. It's a VM and I am starting it using an external kernel and only coy the modules over. Thus I've never do the make install or make modules_install step. This might trip over the modprobe step.

# ls /lib/modules/6.17.0-rc1+/* -l
-rw-r--r-- 1 root root  4078 Aug 11 09:14 /lib/modules/6.17.0-rc1+/modules.alias
-rw-r--r-- 1 root root  4542 Aug 11 09:14 /lib/modules/6.17.0-rc1+/modules.alias.bin
-rw-r--r-- 1 root root     0 Aug 11 09:14 /lib/modules/6.17.0-rc1+/modules.builtin.alias.bin
-rw-r--r-- 1 root root     0 Aug 11 09:14 /lib/modules/6.17.0-rc1+/modules.builtin.bin
-rw-r--r-- 1 root root  2775 Aug 11 09:14 /lib/modules/6.17.0-rc1+/modules.dep
-rw-r--r-- 1 root root  3610 Aug 11 09:14 /lib/modules/6.17.0-rc1+/modules.dep.bin
-rw-r--r-- 1 root root    78 Aug 11 09:14 /lib/modules/6.17.0-rc1+/modules.devname
-rw-r--r-- 1 root root    55 Aug 11 09:14 /lib/modules/6.17.0-rc1+/modules.softdep
-rw-r--r-- 1 root root  8195 Aug 11 09:14 /lib/modules/6.17.0-rc1+/modules.symbols
-rw-r--r-- 1 root root 10284 Aug 11 09:14 /lib/modules/6.17.0-rc1+/modules.symbols.bin

[hreinecke]

cat /proc/crypto | grep dh-generic
Maybe?

[igaw]

After a quick offline discussion with Hannes, we came up with the idea that something like

__have_crypto DH

might the best solution.

It would still do a modprobe and if this fails it tests if it is available in /proc/crypto. The kernel configuration has changed over time (e.g. naming or in which module the code is). This means some mapping is necessary but that shouldn't be too complex.

[hreinecke]

Created PR #198 to handle this issue.