nvme/056: Add check for empty ddp capabilities #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a shell syntax error that occurs when trying to perform bitwise
AND operation on empty ddp capabilities.
Now explicitly checks if ddp_caps hw returns empty string before
proceeding with capability check.
Improves error handling for non-ddp capable devices like qemu virtio-net.
Without this patch qemu with virtio-net returns error:
```
tests/nvme/056: line 222: & 3: syntax error: operand expected (error token is "& 3")
```
With patch:
```
nvme/056 (tr=tcp) (enable zero copy offload and run rw traffic) [not run]
runtime ... 0.150s
No ddp capabilities found for enp0s6
```
Signed-off-by: Denys Fedoryshchenko <[email protected]>
Collaborator
|
@nuclearcat Thanks for the fix. It looks good to me. I'll wait a few more days before merge just in case @aaptel has any comments. @aaptel FYI. |
Collaborator
|
I have merged this PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a shell syntax error that occurs when trying to perform bitwise AND operation on empty ddp capabilities.
Now explicitly checks if ddp_caps hw returns empty string before proceeding with capability check.
Improves error handling for non-ddp capable devices like qemu virtio-net.
Without this patch qemu with virtio-net returns error:
With patch: