nvme/{043,045}: use SHA-512 DH-HMAC-CHAP keys #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We really should not use keys with a length smaller than the hash length, so use SHA-512 keys to ensure we always have a large enough key. Signed-off-by: Hannes Reinecke <[email protected]>
igaw
reviewed
Apr 16, 2025
| local ns | ||
|
|
||
| hostkey="$(nvme gen-dhchap-key -n "${def_subsysnqn}" 2> /dev/null)" | ||
| hostkey="$(nvme gen-dhchap-key -m 3 -n "${def_subsysnqn}" 2> /dev/null)" |
Contributor
There was a problem hiding this comment.
I would use this opportunity to start using long option names, --hmac and --nqn
Contributor
Author
There was a problem hiding this comment.
By all means. I'll rework the patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We really should not use keys with a length smaller than the hash length as otherwise we would not have enough key data to satisfy security constrains. So update tests to use SHA-512 keys to ensure we always have a large enough key.