-
Notifications
You must be signed in to change notification settings - Fork 85
Test scsi_debug timeout and abort handling #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@kawasaki Do you expect me to ping you if a pull request is ready for review? |
|
@bvanassche Sorry for the slow response. I put review of this PR on my todo list, but other work took higher priority... This ping helps me to prioritize blktests works. I guess the kernel side change is this one, right? If the failure is unique to my system, I will need to allocate my time to debug it. |
kawasaki
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks important and valuable, and the patches look good to me overall. I left just two nit comments.
Change a single occurrence of "specifeid" into "specified". Fixes: 17dd969 ("common/scsi_debug: introduce _configure_scsi_debug") Signed-off-by: Bart Van Assche <[email protected]>
It seems like there is a misunderstanding. My goal with this test is that it passes against all kernel versions. This means that this test should pass whether or not the patch series mentioned above has been applied. I see that this test passes if I run it on top of a debug kernel and that this test fails if run on top of a release kernel. Let me take a closer look at this. |
No functionality has been changed. Signed-off-by: Bart Van Assche <[email protected]>
Signed-off-by: Bart Van Assche <[email protected]>
If modifying a /sys/class/block/*/queue attribute fails, show the path involved in the write failure. Signed-off-by: Bart Van Assche <[email protected]>
Move the code for parsing the kernel configuration file from tests/scsi/007 into common/rc. No functionality has been changed. Signed-off-by: Bart Van Assche <[email protected]>
Check whether scsi_timeout() has been called. Fail immediately if an unexpected error occurs. Signed-off-by: Bart Van Assche <[email protected]>
|
Tests scsi/012 and scsi/007 have been merged into scsi/007. |
|
Thanks for updating the series. The changes look good to me. I have just started another round of confirmation run. Tomorrow, I will check the result then will merge this PR. |
A pending Linux kernel patch modifies SCSI abort handling in the
scsi_debug kernel driver. Hence, add a test that triggers aborting SCSI
commands for the scsi_debug kernel driver.