Skip to content

bdev: add hint prints in sb_set_blocksize() for LBS dependency on THP #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: linus-master_base
Choose a base branch
from
Open

bdev: add hint prints in sb_set_blocksize() for LBS dependency on THP #345

wants to merge 1 commit into from

Conversation

@blktests-ci
Copy link

@blktests-ci blktests-ci bot commented Nov 10, 2025

Pull request for series with
subject: bdev: add hint prints in sb_set_blocksize() for LBS dependency on THP
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1021565

@blktests-ci
Copy link
Author

blktests-ci bot commented Nov 10, 2025

Upstream branch: e9a6fb0
series: https://patchwork.kernel.org/project/linux-block/list/?series=1021565
version: 1

@blktests-ci
Copy link
Author

blktests-ci bot commented Nov 10, 2025

Upstream branch: e9a6fb0
series: https://patchwork.kernel.org/project/linux-block/list/?series=1021565
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1021565=>linus-master branch from 5265d77 to a4b58df Compare November 10, 2025 14:28
@blktests-ci blktests-ci bot force-pushed the linus-master_base branch from f699346 to 83d3e2f Compare November 14, 2025 03:26
@blktests-ci
Copy link
Author

blktests-ci bot commented Nov 14, 2025

Upstream branch: 6da43bb
series: https://patchwork.kernel.org/project/linux-block/list/?series=1021565
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1021565=>linus-master branch from a4b58df to 2a5180e Compare November 14, 2025 03:37
@blktests-ci blktests-ci bot force-pushed the linus-master_base branch from 83d3e2f to 00d5e5c Compare November 16, 2025 07:35
@blktests-ci
Copy link
Author

blktests-ci bot commented Nov 16, 2025

Upstream branch: f824272
series: https://patchwork.kernel.org/project/linux-block/list/?series=1021565
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1021565=>linus-master branch from 2a5180e to b4100d0 Compare November 16, 2025 07:39
@blktests-ci blktests-ci bot force-pushed the linus-master_base branch from 00d5e5c to d782508 Compare November 17, 2025 00:45
@blktests-ci
Copy link
Author

blktests-ci bot commented Nov 17, 2025

Upstream branch: f824272
series: https://patchwork.kernel.org/project/linux-block/list/?series=1021565
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1021565=>linus-master branch from b4100d0 to 6571b70 Compare November 17, 2025 00:49
@blktests-ci blktests-ci bot force-pushed the linus-master_base branch from d782508 to 6099a4d Compare November 17, 2025 23:44
@blktests-ci
Copy link
Author

blktests-ci bot commented Nov 17, 2025

Upstream branch: e7c375b
series: https://patchwork.kernel.org/project/linux-block/list/?series=1021565
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1021565=>linus-master branch from 6571b70 to 9a53eb1 Compare November 17, 2025 23:49
@blktests-ci blktests-ci bot force-pushed the linus-master_base branch from 6099a4d to 5121c4d Compare November 18, 2025 02:19
@blktests-ci
Copy link
Author

blktests-ci bot commented Nov 18, 2025

Upstream branch: e7c375b
series: https://patchwork.kernel.org/project/linux-block/list/?series=1021565
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1021565=>linus-master branch from 9a53eb1 to 69f6a05 Compare November 18, 2025 02:23
@blktests-ci blktests-ci bot force-pushed the linus-master_base branch from 5121c4d to 4458758 Compare November 19, 2025 00:24
@blktests-ci
Copy link
Author

blktests-ci bot commented Nov 19, 2025

Upstream branch: 8b69055
series: https://patchwork.kernel.org/project/linux-block/list/?series=1021565
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1021565=>linus-master branch from 69f6a05 to c989324 Compare November 19, 2025 00:38
@blktests-ci blktests-ci bot force-pushed the linus-master_base branch from 4458758 to 6f43942 Compare November 21, 2025 09:45
@LiBaokun96 @kawasaki
bdev: add hint prints in sb_set_blocksize() for LBS dependency on THP
0cab139 
Support for block sizes greater than the page size depends on large
folios, which in turn require CONFIG_TRANSPARENT_HUGEPAGE to be enabled.

Because the code is wrapped in multiple layers of abstraction, this
dependency is rather obscure, so users may not realize it and may be
unsure how to enable LBS.

As suggested by Theodore, I have added hint messages in sb_set_blocksize
so that users can distinguish whether a mount failure with block size
larger than page size is due to lack of filesystem support or the absence
of CONFIG_TRANSPARENT_HUGEPAGE.

Suggested-by: Theodore Ts'o <[email protected]>
Link: https://patch.msgid.link/[email protected]
Signed-off-by: Baokun Li <[email protected]>
Reviewed-by: Jan Kara <[email protected]>
Reviewed-by: Zhang Yi <[email protected]>
@blktests-ci
Copy link
Author

blktests-ci bot commented Nov 21, 2025

Upstream branch: fd95357
series: https://patchwork.kernel.org/project/linux-block/list/?series=1021565
version: 1

@blktests-ci blktests-ci bot force-pushed the series/1021565=>linus-master branch from c989324 to 0cab139 Compare November 21, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

linus-master new V1-ci-pass V1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LiBaokun96