New trait OwnableRefCounted for ARef<->Owned conversion. #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Upstream branch: f824272 |
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
d782508 to
6099a4d
Compare
Author
|
Upstream branch: e7c375b |
blktests-ci
bot
force-pushed
the
series/1024189=>linus-master
branch
from
5b3b0ed to
195123f
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
6099a4d to
5121c4d
Compare
Author
|
Upstream branch: e7c375b |
blktests-ci
bot
force-pushed
the
series/1024189=>linus-master
branch
from
195123f to
12ab472
Compare
blktests-ci
bot
force-pushed
the
linus-master_base
branch
from
5121c4d to
4458758
Compare
Author
|
Upstream branch: 8b69055 |
blktests-ci
bot
force-pushed
the
series/1024189=>linus-master
branch
from
12ab472 to
9b983be
Compare
By analogy to `AlwaysRefCounted` and `ARef`, an `Ownable` type is a (typically C FFI) type that *may* be owned by Rust, but need not be. Unlike `AlwaysRefCounted`, this mechanism expects the reference to be unique within Rust, and does not allow cloning. Conceptually, this is similar to a `KBox<T>`, except that it delegates resource management to the `T` instead of using a generic allocator. [ om: - Split code into separate file and `pub use` it from types.rs. - Make from_raw() and into_raw() public. - Remove OwnableMut, and make DerefMut dependent on Unpin instead. - Usage example/doctest for Ownable/Owned. - Fixes to documentation and commit message. ] Link: https://lore.kernel.org/all/[email protected]/ Signed-off-by: Asahi Lina <[email protected]> Co-developed-by: Oliver Mangold <[email protected]> Signed-off-by: Oliver Mangold <[email protected]> Co-developed-by: Andreas Hindborg <[email protected]> Signed-off-by: Andreas Hindborg <[email protected]> Reviewed-by: Boqun Feng <[email protected]>
`AlwaysRefCounted` will become a marker trait to indicate that it is allowed to obtain an `ARef<T>` from a `&T`, which cannot be allowed for types which are also Ownable. Signed-off-by: Oliver Mangold <[email protected]> Co-developed-by: Andreas Hindborg <[email protected]> Signed-off-by: Andreas Hindborg <[email protected]> Suggested-by: Alice Ryhl <[email protected]>
SAFETY comment in rustdoc example was just 'TODO'. Fixed. Signed-off-by: Oliver Mangold <[email protected]> Co-developed-by: Andreas Hindborg <[email protected]> Signed-off-by: Andreas Hindborg <[email protected]>
Types implementing one of these traits can safely convert between an `ARef<T>` and an `Owned<T>`. This is useful for types which generally are accessed through an `ARef` but have methods which can only safely be called when the reference is unique, like e.g. `block::mq::Request::end_ok()`. Signed-off-by: Oliver Mangold <[email protected]> Co-developed-by: Andreas Hindborg <[email protected]> Signed-off-by: Andreas Hindborg <[email protected]> Reviewed-by: Andreas Hindborg <[email protected]>
Author
|
Upstream branch: fd95357 |
blktests-ci
bot
force-pushed
the
series/1024189=>linus-master
branch
from
9b983be to
5ce4d2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: New trait OwnableRefCounted for ARef<->Owned conversion.
version: 13
url: https://patchwork.kernel.org/project/linux-block/list/?series=1024189