sndk plugin command showing features wrongly under capabilities with SN655(NVMe OF)

[adhipashelly]

Check the sndk plug in commands with NVMe OF enclosure for SN655 with nvme-cli-git-2.16-2117-ga0bc6b8.

nvme sndk capabilites show few “Supported” features also as “Not Supported”
#####################################################################################
nvme sndk capabilities /dev/nvme10
ERROR: SNDK: sndk_get_pci_ids : Open vendor file failed
sndk_get_dev_mgment_data: UUID lists are supported but a matching uuid was not found
ERROR: SNDK: 0xC2 Log Page not found
Sandisk Plugin Capabilities for NVME device:nvme10
vs-internal-log : Supported
vs-nand-stats : Not Supported
vs-smart-add-log : Not Supported
--C0 Log Page : Not Supported
--C1 Log Page : Not Supported
--C3 Log Page : Not Supported
--CA Log Page : Not Supported
--D0 Log Page : Not Supported
clear-pcie-correctable-errors : Not Supported
get-drive-status : Supported
clear-assert-dump : Supported
drive-resize : Supported
vs-fw-activate-history : Not Supported
clear-fw-activate-history : Not Supported
vs-telemetry-controller-option: Not Supported
vs-error-reason-identifier : Not Supported
log-page-directory : Not Supported
namespace-resize : Not Supported
vs-drive-info : Not Supported
vs-temperature-stats : Not Supported
cloud-SSD-plugin-version : Not Supported
vs-pcie-stats : Not Supported
get-error-recovery-log : Not Supported
get-dev-capabilities-log : Not Supported
get-unsupported-reqs-log : Not Supported
get-latency-monitor-log : Not Supported
cloud-boot-SSD-version : Not Supported
vs-cloud-log : Not Supported
vs-hw-rev-log : Not Supported
vs-device_waf : Not Supported
set-latency-monitor-feature : Not Supported
capabilities : Supported
###########################################################################

OBSERVATION

• sndk plugin command capabilities are not being reported correctly.

• The output generated by the SNDK and WDC capability plug-in commands varies, as each provides a different set of parameters.

• Issue observed only with sndk plug-in command with CB II and CB plus drives.

[igaw]

@jeff-lien-sndk I think this one is for you :)

[jeff-lien-sndk]

@igaw I'll take a look into this.

[jeff-lien-sndk]

@adhipashelly Not all the commands supported by the WDC plugin are supported by the Sandisk plugin. Some commands for some of the older WD drives were purposely not moved into Sandisk plugin. Therefore, the capability plug-in command output will vary between the wdc and sandisk plugin. The sandisk plugin has a smaller number of supported commands so the capabilities list is naturally going to be smaller.

For SN-655 drives, most if not all of it's supported capabilities should be supported in both plugins. I did a comparison of the SN-655 capabilities for both the wdc and sandisk plugins on my system confirm this. I could not compare the nvme over fabrics case though since I don't have that setup available to me.

• Could you list the particular capabilities that you require and are missing in the sandisk plugin?

Sandisk Plugin Capabilities for NVME device:nvme2 - CB 2723 FW LCA10400
vs-internal-log : Supported
vs-nand-stats : Not Supported
vs-smart-add-log : Supported
--C0 Log Page : Supported
--C1 Log Page : Not Supported
--C3 Log Page : Not Supported
--CA Log Page : Not Supported
--D0 Log Page : Not Supported
clear-pcie-correctable-errors : Supported
get-drive-status : Supported
clear-assert-dump : Supported
drive-resize : Supported
vs-fw-activate-history : Supported
clear-fw-activate-history : Supported
vs-telemetry-controller-option: Supported
vs-error-reason-identifier : Supported
log-page-directory : Supported
namespace-resize : Not Supported
vs-drive-info : Not Supported
vs-temperature-stats : Not Supported
cloud-SSD-plugin-version : Not Supported
vs-pcie-stats : Not Supported
get-error-recovery-log : Not Supported
get-dev-capabilities-log : Supported
get-unsupported-reqs-log : Supported
get-latency-monitor-log : Not Supported
cloud-boot-SSD-version : Not Supported
vs-cloud-log : Not Supported
vs-hw-rev-log : Not Supported
vs-device_waf : Not Supported
set-latency-monitor-feature : Not Supported
capabilities : Supported

WDC Plugin Capabilities for NVME device:nvme2
cap-diag : Supported
drive-log : Not Supported
get-crash-dump : Not Supported
get-pfail-dump : Not Supported
id-ctrl : Supported
purge : Not Supported
purge-monitor : Not Supported
vs-internal-log : Supported
vs-nand-stats : Not Supported
vs-smart-add-log : Supported
--C0 Log Page : Supported
--C1 Log Page : Not Supported
--C3 Log Page : Not Supported
--CA Log Page : Not Supported
--D0 Log Page : Not Supported
clear-pcie-correctable-errors : Supported
drive-essentials : Not Supported
get-drive-status : Supported
clear-assert-dump : Supported
drive-resize : Supported
vs-fw-activate-history : Supported
clear-fw-activate-history : Supported
vs-telemetry-controller-option: Supported
vs-error-reason-identifier : Supported
log-page-directory : Supported
namespace-resize : Not Supported
vs-drive-info : Not Supported
vs-temperature-stats : Not Supported
cloud-SSD-plugin-version : Not Supported
vs-pcie-stats : Not Supported
get-error-recovery-log : Not Supported
get-dev-capabilities-log : Supported
get-unsupported-reqs-log : Supported
get-latency-monitor-log : Not Supported
cloud-boot-SSD-version : Not Supported
vs-cloud-log : Not Supported
vs-hw-rev-log : Not Supported
vs-device_waf : Not Supported
set-latency-monitor-feature : Not Supported
capabilities : Supported