Segfault seen with connect-all using config JSON file #3020
Description
Seeing a segfault during a connect-all using the config JSON file. Details below:
# cat /usr/local/etc/nvme/config.json
[
{
"hostnqn":"nqn.2014-08.org.nvmexpress:uuid:e6550026-173e-4959-ba74-be367844bd8a",
"hostid":"e6550026-173e-4959-ba74-be367844bd8a",
"subsystems":[
{
"nqn":"nqn.1992-08.com.netapp:sn.48391d66c0a611ecaaa5d039ea165514:subsystem.subsys_CLIENT116_0",
"ports":[
{
"transport":"tcp",
"traddr":"192.168.1.116",
"host_traddr":"192.168.1.6",
"trsvcid":"4420"
}
]
}
]
}
]
# nvme connect-all -J /usr/local/etc/nvme/config.json -vv
scan controller nvme1
lookup subsystem /sys/class/nvme-subsystem/nvme-subsys1/nvme1
skipping path scan for ctrl nvme1
skipping namespace scan for ctrl nvme1
failed to scan ctrl nvme1: Success
scan subsystem nvme-subsys1
creating detached subsystem 'nvme-subsys1'
skipping namespace scan for subsys nqn.1992-08.com.netapp:sn.48391d66c0a611ecaaa5d039ea165514:subsystem.subsys_CLIENT116_0
failed to scan subsystem nvme-subsys1: Unknown error -22
kernel supports: instance cntlid transport traddr trsvcid nqn queue_size nr_io_queues reconnect_delay ctrl_loss_tmo keep_alive_tmo hostnqn host_traddr host_iface hostid duplicate_connect disable_sqflow hdr_digest data_digest nr_write_queues nr_poll_queues tos keyring tls_key fast_io_fail_tmo discovery dhchap_secret dhchap_ctrl_secret tls concat recovery_delay
connect ctrl, 'nqn=nqn.2014-08.org.nvmexpress.discovery,transport=tcp,traddr=192.168.1.116,host_traddr=192.168.1.6,trsvcid=4420,hostnqn=nqn.2014-08.org.nvmexpress:uuid:e6550026-173e-4959-ba74-be367844bd8a,hostid=e6550026-173e-4959-ba74-be367844bd8a,ctrl_loss_tmo=600'
connect ctrl, response 'instance=0,cntlid=24640'
nvme0: nqn.2014-08.org.nvmexpress.discovery connected
lookup subsystem /sys/class/nvme-subsystem/nvme-subsys0/nvme0
nvme0: nqn.2014-08.org.nvmexpress.discovery disconnected
connect ctrl, 'nqn=nqn.1992-08.com.netapp:sn.48391d66c0a611ecaaa5d039ea165514:discovery,transport=tcp,traddr=192.168.1.116,host_traddr=192.168.1.6,trsvcid=4420,hostnqn=nqn.2014-08.org.nvmexpress:uuid:e6550026-173e-4959-ba74-be367844bd8a,hostid=e6550026-173e-4959-ba74-be367844bd8a,discovery,ctrl_loss_tmo=600'
connect ctrl, response 'instance=0,cntlid=24704'
nvme0: nqn.1992-08.com.netapp:sn.48391d66c0a611ecaaa5d039ea165514:discovery connected
lookup subsystem /sys/class/nvme-subsystem/nvme-subsys0/nvme0
nvme0: get header (try 0/10)
nvme0: get 2 records (genctr 75)
nvme0: get header again
nvme0: nqn.1992-08.com.netapp:sn.48391d66c0a611ecaaa5d039ea165514:discovery disconnected
Segmentation fault (core dumped)
Backtrace of the segfault reveals the following:
# gdb /usr/local/sbin/nvme core.nvme.4121
GNU gdb (GDB; SUSE Linux Enterprise 15) 14.2
Copyright (C) 2023 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-suse-linux".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://bugs.opensuse.org/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /usr/local/sbin/nvme...
[New LWP 4121]
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
Core was generated by `nvme connect-all -J /usr/local/etc/nvme/config.json -vv'.
Program terminated with signal SIGSEGV, Segmentation fault.
#0 cb_parser_next_line (fctx=0xda01b80, user_data=0x7fffee2d72d0) at ../fabrics.c:284
284 memcpy(&cfg, cfd->defcfg, sizeof(cfg));
Missing separate debuginfos, use: zypper install glibc-debuginfo-2.38-150600.14.29.1.x86_64 libjitterentropy3-debuginfo-3.4.1-150000.1.12.1.x86_64 libjson-c5-debuginfo-0.16-150600.1.4.x86_64 libkeyutils1-debuginfo-1.6.3-5.6.1.x86_64 libopenssl3-debuginfo-3.2.3-150700.5.21.1.x86_64 libz1-debuginfo-1.2.13-150500.4.3.1.x86_64
(gdb) where
#0 cb_parser_next_line (fctx=0xda01b80, user_data=0x7fffee2d72d0) at ../fabrics.c:284
#1 0x00007f13a388c685 in nvmf_discovery_config_file (ctx=ctx@entry=0xd9ff2e0, fctx=fctx@entry=0xda01b80, connect=connect@entry=true, force=false) at ../libnvme/src/nvme/fabrics.c:2558
#2 0x0000000000409977 in fabrics_discovery (desc=<optimized out>, argc=<optimized out>, argv=<optimized out>, connect=<optimized out>) at ../fabrics.c:564
#3 0x00000000004462c9 in handle_plugin (argc=argc@entry=4, argv=argv@entry=0x7fffee2d83d0, plugin=0x53bee0 <builtin>) at ../plugin.c:190
#4 0x0000000000407761 in main (argc=5, argv=0x7fffee2d83c8) at ../nvme.c:11029
(gdb)