Skip to content

Commit c77f23a

Browse files
committed
Change minimum and maximum fan speeds
MacBook Airs allow 1200-6500 and Mac Pro allow 500-5200. Allow mbpfan to configure smaller and larger values. Also fix typo in constant names.
1 parent 53e1c35 commit c77f23a

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/mbpfan.c

+7-6
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,9 @@ int max_temp = 86; // do not set it > 90
6060
#define NUM_HWMONS 12
6161
#define NUM_TEMP_INPUTS 16
6262
#define NUM_FANS 10
63-
#define NUM_MIN_FAN_SPEED_DEFAULT 2000
64-
#define NUM_MAX_FAN_SPEED_DEFAULT 6200
63+
// sane defaults when user provides unexpected values
64+
#define MIN_FAN_SPEED_DEFAULT 500
65+
#define MAX_FAN_SPEED_DEFAULT 6500
6566

6667
int polling_interval = 1;
6768

@@ -291,14 +292,14 @@ t_fans *retrieve_fans()
291292
fan->fan_id = counter;
292293

293294
int fan_speed = read_value(path_fan_min);
294-
if(fan_speed == -1 || fan_speed < NUM_MIN_FAN_SPEED_DEFAULT)
295-
fan->fan_min_speed = NUM_MIN_FAN_SPEED_DEFAULT;
295+
if(fan_speed == -1 || fan_speed < MIN_FAN_SPEED_DEFAULT)
296+
fan->fan_min_speed = MIN_FAN_SPEED_DEFAULT;
296297
else
297298
fan->fan_min_speed = fan_speed;
298299

299300
fan_speed = read_value(path_fan_max);
300-
if(fan_speed == -1 || fan_speed > NUM_MAX_FAN_SPEED_DEFAULT)
301-
fan->fan_max_speed = NUM_MAX_FAN_SPEED_DEFAULT;
301+
if(fan_speed == -1 || fan_speed > MAX_FAN_SPEED_DEFAULT)
302+
fan->fan_max_speed = MAX_FAN_SPEED_DEFAULT;
302303
else
303304
fan->fan_max_speed = fan_speed;
304305

0 commit comments

Comments
 (0)