glmark2 not building - egl not found - potentially sunxi-mali related

[KristofRobot]

When trying to bitbake glmark2 on a cubieboard2, I get following error, which is potentially sunxi-mali related.

DEBUG: Executing python function sysroot_cleansstate
DEBUG: Python function sysroot_cleansstate finished
DEBUG: Executing shell function do_configure
Setting top to                           : /home/kristof/OE/oe-core/build/tmp-eglibc/work/cortexa7hf-vfp-neon-oe-linux-gnueabi/glmark2/2012.12-r0/glmark2-2012.12 
Setting out to                           : /home/kristof/OE/oe-core/build/tmp-eglibc/work/cortexa7hf-vfp-neon-oe-linux-gnueabi/glmark2/2012.12-r0/glmark2-2012.12/build 
Checking for 'gcc' (c compiler)          : arm-oe-linux-gnueabi-gcc -march=armv7-a -marm -mthumb-interwork -mfloat-abi=hard -mfpu=neon-vfpv4 -mtune=cortex-a7 --sysroot=/home/kristof/OE/oe-core/build/tmp-eglibc/sysroots/cubieboard2 
Checking for 'g++' (c++ compiler)        : arm-oe-linux-gnueabi-g++ -march=armv7-a -marm -mthumb-interwork -mfloat-abi=hard -mfpu=neon-vfpv4 -mtune=cortex-a7 --sysroot=/home/kristof/OE/oe-core/build/tmp-eglibc/sysroots/cubieboard2 
Checking for header stdlib.h             : yes 
Checking for header string.h             : yes 
Checking for header unistd.h             : yes 
Checking for header stdint.h             : yes 
Checking for header stdio.h              : yes 
Checking for header jpeglib.h            : yes 
Checking for library m                   : yes 
Checking for library jpeg                : yes 
Checking for function memset             : yes 
Checking for function sqrt               : yes 
Checking for program pkg-config          : /home/kristof/OE/oe-core/build/tmp-eglibc/sysroots/x86_64-linux/usr/bin/pkg-config 
Checking for 'libpng12'                  : yes 
Checking for 'x11'                       : yes 
Checking for 'gl'                        : yes 
Checking for 'egl'                       : not found 
The configuration failed
(complete log in /home/kristof/OE/oe-core/build/tmp-eglibc/work/cortexa7hf-vfp-neon-oe-linux-gnueabi/glmark2/2012.12-r0/glmark2-2012.12/build/config.log)
WARNING: exit code 1 from a shell command.
ERROR: Function failed: do_configure (log file is located at /home/kristof/OE/oe-core/build/tmp-eglibc/work/cortexa7hf-vfp-neon-oe-linux-gnueabi/glmark2/2012.12-r0/temp/log.do_configure.26995)

cat cat /home/kristof/OE/oe-core/build/tmp-eglibc/work/cortexa7hf-vfp-neon-oe-linux-gnueabi/glmark2/2012.12-r0/glmark2-2012.12/build/config.log:

[...]
Checking for 'gl'
['/home/kristof/OE/oe-core/build/tmp-eglibc/sysroots/x86_64-linux/usr/bin/pkg-config', 'gl', '--cflags', '--libs']
out: -DMESA_EGL_NO_X11_HEADERS -I/home/kristof/OE/oe-core/build/tmp-eglibc/sysroots/cubieboard2/usr/include/libdrm -lGL 

yes
----------------------------------------
Checking for 'egl'
['/home/kristof/OE/oe-core/build/tmp-eglibc/sysroots/x86_64-linux/usr/bin/pkg-config', 'egl', '--cflags', '--libs']
err: Package egl was not found in the pkg-config search path.
Perhaps you should add the directory containing `egl.pc'
to the PKG_CONFIG_PATH environment variable
No package 'egl' found

not found

I believe this is some error in the machine file, and more specifically in the sunxi-mali recipe [1], as that should provide egl:

PROVIDES = "virtual/libgles1 virtual/libgles2 virtual/egl"

Are others able to reproduce this as well? Any ideas on how to fix this?

Thanks!

Kristof

[1] https://github.com/linux-sunxi/meta-sunxi/blob/master/recipes-graphics/libgles/sunxi-mali_git.bb

[raoulh]

Hi,

Yes sunxi-mali does not provide the egl.pc files for pkg-config. I have a patch for this in my branch:
raoulh@ed253d0

I also tried to compile glmark2, but it failed later at compile time because a typedef is missing in the gl headers. I manually added typedef char GLchar; or something like that in the glmark2 header and it was working.

I don't know if we need to patch glmark2 and add a bbappend in meta-sunxi or patch the GL headers....?

[KristofRobot]

@raoulh thanks, that looks great!

I'd propose to pull a request to merge this with meta-sunxi master, and also open an issue upstream (at sunxi-mail [1]) to fix this.
I think that ideally, this should be fixed by updating the Makefile to generate these *.pc files.

After applying this patch, configuring works fine, and I get indeed stuck at the compile stage, as you predicted:

Waf: Entering directory `/home/kristof/OE/oe-core/build/tmp-eglibc/work/cortexa7hf-vfp-neon-oe-linux-gnueabi/glmark2/2012.12-r0/glmark2-2012.12/build'
[...]
[ 66/129] cxx: src/libmatrix/util.cc -> build/src/libmatrix/util.cc.3.o
../src/libmatrix/program.cc: In constructor 'Shader::Shader(unsigned int, const string&)':
../src/libmatrix/program.cc:41:11: error: 'GLchar' does not name a type
     const GLchar* shaderSource = source_.c_str();
           ^
../src/libmatrix/program.cc:42:33: error: 'shaderSource' was not declared in this scope
     glShaderSource(handle_, 1, &shaderSource, NULL);
                                 ^
../src/libmatrix/program.cc: In member function 'void Shader::compile()':
../src/libmatrix/program.cc:77:9: error: 'GLchar' was not declared in this scope
         GLchar* infoLog = new GLchar[param + 1];
         ^
../src/libmatrix/program.cc:77:17: error: 'infoLog' was not declared in this scope
         GLchar* infoLog = new GLchar[param + 1];
                 ^
../src/libmatrix/program.cc:77:31: error: expected type-specifier before 'GLchar'
         GLchar* infoLog = new GLchar[param + 1];
                               ^
../src/libmatrix/program.cc:77:31: error: expected ';' before 'GLchar'
../src/libmatrix/program.cc:80:19: error: type '<type error>' argument given to 'delete', expected pointer
         delete [] infoLog;
                   ^
../src/libmatrix/program.cc: In member function 'void Program::build()':
../src/libmatrix/program.cc:217:9: error: 'GLchar' was not declared in this scope
         GLchar* infoLog = new GLchar[param + 1];
         ^
../src/libmatrix/program.cc:217:17: error: 'infoLog' was not declared in this scope
         GLchar* infoLog = new GLchar[param + 1];
                 ^
../src/libmatrix/program.cc:217:31: error: expected type-specifier before 'GLchar'
         GLchar* infoLog = new GLchar[param + 1];
                               ^
../src/libmatrix/program.cc:217:31: error: expected ';' before 'GLchar'
../src/libmatrix/program.cc:220:19: error: type '<type error>' argument given to 'delete', expected pointer
         delete [] infoLog;
                   ^
Waf: Leaving directory `/home/kristof/OE/oe-core/build/tmp-eglibc/work/cortexa7hf-vfp-neon-oe-linux-gnueabi/glmark2/2012.12-r0/glmark2-2012.12/build'
Build failed
 -> task in 'matrix-es2' failed (exit status 1): 
    {task 28348368: cxx program.cc -> program.cc.3.o}
['arm-oe-linux-gnueabi-g++', '-march=armv7-a', '-marm', '-mthumb-interwork', '-mfloat-abi=hard', '-mfpu=neon-vfpv4', '-mtune=cortex-a7', '--sysroot=/home/kristof/OE/oe-core/build/tmp-eglibc/sysroots/cubieboard2', '-g', '-O2', '-O2', '-pipe', '-g', '-feliminate-unused-debug-types', '-fpermissive', '-fvisibility-inlines-hidden', '-Werror', '-Wall', '-Wextra', '-Wnon-virtual-dtor', '-I/home/kristof/OE/oe-core/build/tmp-eglibc/work/cortexa7hf-vfp-neon-oe-linux-gnueabi/glmark2/2012.12-r0/glmark2-2012.12/build/src', '-I/home/kristof/OE/oe-core/build/tmp-eglibc/work/cortexa7hf-vfp-neon-oe-linux-gnueabi/glmark2/2012.12-r0/glmark2-2012.12/src', '-DHAVE_STDLIB_H=1', '-DHAVE_STRING_H=1', '-DHAVE_UNISTD_H=1', '-DHAVE_STDINT_H=1', '-DHAVE_STDIO_H=1', '-DHAVE_JPEGLIB_H=1', '-DHAVE_MEMSET=1', '-DHAVE_SQRT=1', '-DHAVE_LIBPNG12=1', '-DHAVE_X11=1', '-DHAVE_GL=1', '-DHAVE_EGL=1', '-DHAVE_GLESV2=1', '-DHAVE_DRM=1', '-DHAVE_GBM=1', '-DGLMARK_DATA_PATH="/usr/share/glmark2"', '-DGLMARK_VERSION="2012.12"', '-DUSE_GLESv2', '-DUSE_EXCEPTIONS', '../src/libmatrix/program.cc', '-c', '-o', 'src/libmatrix/program.cc.3.o']
WARNING: exit code 1 from a shell command.
ERROR: Function failed: do_compile (log file is located at /home/kristof/OE/oe-core/build/tmp-eglibc/work/cortexa7hf-vfp-neon-oe-linux-gnueabi/glmark2/2012.12-r0/temp/log.do_compile.30557)

How exactly did you fix this?
I think here again, the best short-term fix is to add an bbappend in meta-sunxi, and, additionally, report this upstream to get it fixed in glmark2 (and perhaps in the upstream oe-core recipe as well).

Thanks!

Kristof

[1] https://github.com/linux-sunxi/sunxi-mali

[KristofRobot]

How exactly did you fix this?

Ok, as you suggested, adding

typedef char GLchar;

in gl-headers.hdoes seem to do the job.

[KristofRobot]

Note that the missing typedef is the same issue as reported here: https://bugs.launchpad.net/efikamx/+bug/733022

Apparently we don't need to fix this in glmark2 (as I originally thought), but also in sunxi-mail, by pathing their gl.h and gl2.h file ([1], [2])

[1] https://github.com/linux-sunxi/sunxi-mali/blob/master/include/GLES/gl.h
[2] https://github.com/linux-sunxi/sunxi-mali/blob/master/include/GLES2/gl2.h

[raoulh]

Exactly.

I think too, that the .pc files belongs to the sunxi-mali repo and be installed directly by Makefile. That's why I didn't do a pull request. I was not sure of the best solution.

For the typedef char GLchar thing, I think the best way would be to add the typedef directly to https://github.com/linux-sunxi/sunxi-mali/blob/master/include/GLES2/gl2.h

[KristofRobot]

@raoulh are you willing to create a pull request that patches sunxi-mail to:

(1) Generate the pc files (preferably using a Makefile patch)
(2) Add the typedef to gl.h and gl2.h

Let me know if you need help with it, and I'd be happy to test it.

Thanks!

Kristof

[raoulh]

Yes I will do it as soon as I have some time ;)

[raoulh]

@KristofRobot I commited two patches in sunxi-mali to build .pc files and to add the missing declaration. Could you please test that? If it's working I will propose a pull request to sunxi-mali and update meta-sunxi to use it.

Thanks

The patches are:
raoulh/sunxi-mali@613cb39
raoulh/sunxi-mali@b36c946

[KristofRobot]

@raoulh Thanks!

I just tried it out with the a fresh build directory, trying bitbake glmark2, with MACHINE ?= "cubieboard2, and changing sunxi-mali_git.bb to use your version:

SRCREV_pn-${PN} = "613cb39cf29070d6aaec440d0b830214f1be5b93"
SRC_URI = "gitsm://github.com/raoulh/sunxi-mali.git;protocol=http"

However, that still fails with the same error.

Didn't look deeply, but at first sight suspect this is due to the do_install() override in the sunxi-mali recipe.

Were you able to build glmark2 successfully?

[raoulh]

It works for me, but I had to update also the sunxi-mali_git.bb to install all .pc files.
Check this commit:
raoulh@2957173

[KristofRobot]

@raoulh - I tried replacing sunxi-mali_git.bb with your version ([1]), but still the same error...

EDIT: when I say "same error", I mean the "Checking for 'egl' : not found" one.

Maybe my build dir is contaminated, will try again later with a fresh directory.

[1] https://github.com/raoulh/meta-sunxi/blob/master/recipes-graphics/libgles/sunxi-mali_git.bb

[KristofRobot]

Looking in my image directory, I actually only found Makefile.pc:

ls /home/kristof/OE/oe-core/build/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/sunxi-mali/git-r0/image/usr/lib/pkgconfig/
Makefile.pc

although in my source directory all the *pc files are present:

ls /home/kristof/OE/oe-core/build/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/sunxi-mali/git-r0/git/*.pc
/home/kristof/OE/oe-core/build/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/sunxi-mali/git-r0/git/egl.pc
/home/kristof/OE/oe-core/build/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/sunxi-mali/git-r0/git/gles_cm.pc
/home/kristof/OE/oe-core/build/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/sunxi-mali/git-r0/git/glesv2.pc
/home/kristof/OE/oe-core/build/tmp-eglibc/work/armv7a-vfp-neon-oe-linux-gnueabi/sunxi-mali/git-r0/git/Makefile.pc

Forcing the install task again, solved the issue:

bitbake sunxi-mali -c install -f

Seems there is something wrong with the order of writing out the pc files, and installing them?

If I clean sunxi-mali (bitbake sunxi-mali -c cleanall), and then try building glmark2 again (bitbake glmark2), I have again the same problem...

[KristofRobot]

I also have a problem with running it:

root@frobo:~# glmark2
libGL error: failed to load driver: i965
libGL error: Try again with LIBGL_DEBUG=verbose for more details.
libGL error: failed to load driver: swrast
libGL error: Try again with LIBGL_DEBUG=verbose for more details.
** GLX does not support GLX_EXT_swap_control or GLX_MESA_swap_control!
X Error of failed request:  BadAlloc (insufficient resources for operation)
  Major opcode of failed request:  154 (GLX)
  Minor opcode of failed request:  24 (X_GLXCreateNewContext)
  Serial number of failed request:  37
  Current serial number in output stream:  38

Note however that I am running this without screen attached, using X11 Forwarding - although I would not expect this to cause that kind of problem.

Did you manage to run it?

[raoulh]

Thanks for your tests. Ok it seems there is some problems with the .pc installation. I'm going to check and fix that.

[KristofRobot]

@raoulh - have you found time to further look into this? Let me know if I can do additional testing.