Skip to content

Commit 5af754b

Browse files
committed
ci: Ansible version must be string, not float [citest_skip]
The ansible version is specified as a YAML floating point number. This causes `2.20` to be converted to `2.2` which breaks platforms that use ansible 2.20. Ensure it and similar version numbers are specified in YAML as strings. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
1 parent 8d03c21 commit 5af754b

File tree

2 files changed

+11
-9
lines changed

2 files changed

+11
-9
lines changed

.github/workflows/tft.yml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -98,21 +98,22 @@ jobs:
9898
fail-fast: false
9999
matrix:
100100
include:
101+
# Ensure ansible version is a string!
101102
- platform: Fedora-42
102-
ansible_version: 2.19
103+
ansible_version: "2.19"
103104
- platform: Fedora-43
104-
ansible_version: 2.20
105+
ansible_version: "2.20"
105106
- platform: CentOS-7-latest
106-
ansible_version: 2.9
107+
ansible_version: "2.9"
107108
- platform: CentOS-Stream-8
108-
ansible_version: 2.9
109+
ansible_version: "2.9"
109110
# On CentOS-Stream-8, latest supported Ansible is 2.16
110111
- platform: CentOS-Stream-8
111-
ansible_version: 2.16
112+
ansible_version: "2.16"
112113
- platform: CentOS-Stream-9
113-
ansible_version: 2.17
114+
ansible_version: "2.17"
114115
- platform: CentOS-Stream-10
115-
ansible_version: 2.17
116+
ansible_version: "2.17"
116117
runs-on: ubuntu-latest
117118
env:
118119
ARTIFACTS_DIR_NAME: "tf_${{ github.event.repository.name }}-${{ github.event.issue.number }}_\

plans/test_playbooks_parallel.fmf

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,10 @@ provision:
1010
- name: managed-node2
1111
role: managed_node
1212
environment:
13-
SR_ANSIBLE_VER: 2.17
13+
# ensure versions are strings!
14+
SR_ANSIBLE_VER: "2.17"
1415
SR_REPO_NAME: cockpit
15-
SR_PYTHON_VERSION: 3.12
16+
SR_PYTHON_VERSION: "3.12"
1617
SR_ONLY_TESTS: "" # tests_default.yml
1718
SR_TEST_LOCAL_CHANGES: true
1819
SR_PR_NUM: ""

0 commit comments

Comments
 (0)