ci: Pass in __bootc_validation as boolean, not string

[richm]

Pass in a YAML true value as __bootc_validation: true using
the --extra-vars option to ensure that __bootc_validation is
treated as a boolean and not a string value.

-e "__bootc_validation: true"

You can also use JSON format:

-e '{"__bootc_validation": true}'

but YAML is simpler in this case.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Update CI workflows to pass __bootc_validation as a boolean, bump tox-lsr to 3.11.1, enhance rerun logic for cancelled test runs, and document local CI testing setup

CI:

• Pass __bootc_validation as a YAML boolean instead of a string in qemu integration tests
• Upgrade tox-lsr to v3.11.1 in CI workflows
• Include cancelled Terraform test runs for rerun detection in the tft_citest_bad workflow

Documentation:

• Add instructions for running CI tests locally with tox-lsr and qemu to contributing.md

[sourcery-ai]

Reviewer's Guide

This PR ensures the __bootc_validation flag is passed as a YAML boolean, upgrades tox-lsr to v3.11.1 across workflows, enhances TF CI failure logic to include cancellations, and adds a local qemu-based CI testing section to contributing.md.

Flow diagram for passing __bootc_validation as boolean in CI

flowchart TD
  A["CI workflow triggers"] --> B["Pass extra-vars to Ansible"]
  B --> C["__bootc_validation: true (YAML boolean)"]
  C --> D["Ansible interprets as boolean"]

Loading

File-Level Changes

Change	Details	Files
Pass __bootc_validation as YAML boolean rather than string	Replaced -e __bootc_validation=true with -e "__bootc_validation: true"	.github/workflows/qemu-kvm-integration-tests.yml
Bump tox-lsr version to 3.11.1 in GitHub workflows	Updated pip3 install of tox-lsr from @3.11.0 to @3.11.1	.github/workflows/qemu-kvm-integration-tests.yml .github/workflows/ansible-lint.yml .github/workflows/ansible-managed-var-comment.yml .github/workflows/ansible-test.yml
Enhance TF CI failure detection to include cancelled runs	Added explanatory comment about TF test cancellations Modified jq filter to select runs with conclusion 'failure' or 'cancelled'	.github/workflows/tft_citest_bad.yml
Add instructions for running CI tests locally via qemu	Inserted 'Running CI Tests Locally' section Detailed steps for installing and using tox-lsr with qemu	contributing.md

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey there - I've reviewed your changes - here's some feedback:

• You’re updating the tox-lsr version in multiple workflows—consider centralizing that version into a single variable or reusable workflow to avoid future drift.
• The new local QEMU testing instructions are very detailed; moving them into a dedicated CI-testing guide could keep contributing.md more focused.
• You have repeated install/setup steps in several workflows—extracting those into a common GitHub Action or composite workflow would reduce duplication.

Prompt for AI Agents

Please address the comments from this code review:
## Overall Comments
- You’re updating the tox-lsr version in multiple workflows—consider centralizing that version into a single variable or reusable workflow to avoid future drift.
- The new local QEMU testing instructions are very detailed; moving them into a dedicated CI-testing guide could keep contributing.md more focused.
- You have repeated install/setup steps in several workflows—extracting those into a common GitHub Action or composite workflow would reduce duplication.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}