Skip to content

ci: fix yum repos to use devel site instead of old site name [citest_skip]#6

Closed
richm wants to merge 1 commit intomainfrom
use-devel-site-yum-repo
Closed

ci: fix yum repos to use devel site instead of old site name [citest_skip]#6
richm wants to merge 1 commit intomainfrom
use-devel-site-yum-repo

Conversation

@richm
Copy link
Copy Markdown
Contributor

@richm richm commented Apr 1, 2026

Some of the older Testing Farm machines refer to the old site name in the yum repos.
Ensure that they use the correct site name.

Signed-off-by: Rich Megginson rmeggins@redhat.com

Summary by Sourcery

Align references and configuration with the renamed trustee_server role and repository across documentation, tests, and CI.

Enhancements:

  • Rename internal distro helper variables to use the trustee_server prefix for consistency with the role name.

CI:

  • Adjust tmt Testing Farm plan filter and plan documentation to use the trustee_server identifier and workflow URLs.

Documentation:

  • Update documentation and contribution guide links to point to the trustee_server repository and issue tracker.
  • Refresh README badges to reference the trustee_server GitHub workflows.

Tests:

  • Update testing examples to clone and reference the trustee_server repository instead of the old name.

…skip]

Some of the older Testing Farm machines refer to the old site name in the yum repos.
Ensure that they use the correct site name.

Signed-off-by: Rich Megginson <rmeggins@redhat.com>
@richm richm requested a review from spetrosi as a code owner April 1, 2026 18:05
@richm richm self-assigned this Apr 1, 2026
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai bot commented Apr 1, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates documentation, CI configuration, and test variable naming to use the new trustee_server role/repository name instead of the legacy trustee_attestation_server name, ensuring Testing Farm/tmt plan filters, GitHub links, and Ansible test vars are consistent with the new naming and CI infrastructure.

File-Level Changes

Change Details Files
Rename role-specific Ansible test variables from the old trustee_attestation_server prefix to the new trustee_server prefix to match the current role name.
  • Update Red Hat-like distro list variable to use the new trustee_server prefix.
  • Update Fedora-inclusive distro list variable and its composition expression to reference the new prefix.
  • Adjust boolean convenience variables that check whether the current distro is Red Hat-like (with and without Fedora) to use the new variable names.
tests/vars/rh_distros_vars.yml
Align documentation and examples with the new trustee_server GitHub repository name and badge URLs.
  • Update contributing guide title and references (issues, help wanted query, code repo) to point to the trustee_server repository.
  • Update CI testing plans README to reference the trustee_server repo for tft.yml links and git-url examples.
  • Update README badges to reference workflows in the trustee_server repository instead of the old name.
contributing.md
plans/README-plans.md
README.md
Ensure Testing Farm/tmt plan filter uses the new role tag for trustee_server so CI selects the correct tests.
  • Change the tmt_plan_filter value in the Testing Farm GitHub workflow to use the trustee_server tag instead of trustee_attestation_server.
.github/workflows/tft.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since this PR is effectively renaming from trustee_attestation_server to trustee_server in several places, it would be good to run a quick project-wide search to ensure there are no remaining references to the old name (including variable names, tags, and URLs) that could cause confusion or mismatched behavior in CI or tests.
  • The renamed Ansible test vars such as __trustee_server_rh_distros are now different from the previous names; please double-check that all playbooks, tasks, and plans that reference the old __trustee_attestation_server_* variables have been updated to avoid runtime undefined variable errors.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since this PR is effectively renaming from `trustee_attestation_server` to `trustee_server` in several places, it would be good to run a quick project-wide search to ensure there are no remaining references to the old name (including variable names, tags, and URLs) that could cause confusion or mismatched behavior in CI or tests.
- The renamed Ansible test vars such as `__trustee_server_rh_distros` are now different from the previous names; please double-check that all playbooks, tasks, and plans that reference the old `__trustee_attestation_server_*` variables have been updated to avoid runtime `undefined variable` errors.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@richm richm closed this Apr 1, 2026
@richm richm deleted the use-devel-site-yum-repo branch April 1, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant