ci: fix yum repos to use devel site instead of old site name [citest_skip]#6
Closed
ci: fix yum repos to use devel site instead of old site name [citest_skip]#6
Conversation
…skip] Some of the older Testing Farm machines refer to the old site name in the yum repos. Ensure that they use the correct site name. Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates documentation, CI configuration, and test variable naming to use the new trustee_server role/repository name instead of the legacy trustee_attestation_server name, ensuring Testing Farm/tmt plan filters, GitHub links, and Ansible test vars are consistent with the new naming and CI infrastructure. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since this PR is effectively renaming from
trustee_attestation_servertotrustee_serverin several places, it would be good to run a quick project-wide search to ensure there are no remaining references to the old name (including variable names, tags, and URLs) that could cause confusion or mismatched behavior in CI or tests. - The renamed Ansible test vars such as
__trustee_server_rh_distrosare now different from the previous names; please double-check that all playbooks, tasks, and plans that reference the old__trustee_attestation_server_*variables have been updated to avoid runtimeundefined variableerrors.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since this PR is effectively renaming from `trustee_attestation_server` to `trustee_server` in several places, it would be good to run a quick project-wide search to ensure there are no remaining references to the old name (including variable names, tags, and URLs) that could cause confusion or mismatched behavior in CI or tests.
- The renamed Ansible test vars such as `__trustee_server_rh_distros` are now different from the previous names; please double-check that all playbooks, tasks, and plans that reference the old `__trustee_attestation_server_*` variables have been updated to avoid runtime `undefined variable` errors.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the older Testing Farm machines refer to the old site name in the yum repos.
Ensure that they use the correct site name.
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Align references and configuration with the renamed trustee_server role and repository across documentation, tests, and CI.
Enhancements:
CI:
Documentation:
Tests: