Conversation
use latest version of codecov @v6 Signed-off-by: Rich Megginson <rmeggins@redhat.com>
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR updates project references from the old trustee_attestation_server name to trustee_server across docs, CI plans, test vars, and badges to match the new repository/role name, and adjusts a tmt plan filter tag accordingly. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The PR title and description mention updating Codecov to v6, but the changes only cover repository/role renames; consider either including the Codecov workflow update in this PR or adjusting the title/message to match the actual changes.
- After renaming the tmt_plan_filter tag from
trustee_attestation_servertotrustee_server, ensure any corresponding tmt plan definitions (e.g., inplans/*.fmf) use the same tag so the filter still matches. - Given the broad rename from
trustee_attestation_servertotrustee_server, it may be worth running a quick search for any remaining references (URLs, badges, variable names) using the old name to keep the role naming consistent.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The PR title and description mention updating Codecov to v6, but the changes only cover repository/role renames; consider either including the Codecov workflow update in this PR or adjusting the title/message to match the actual changes.
- After renaming the tmt_plan_filter tag from `trustee_attestation_server` to `trustee_server`, ensure any corresponding tmt plan definitions (e.g., in `plans/*.fmf`) use the same tag so the filter still matches.
- Given the broad rename from `trustee_attestation_server` to `trustee_server`, it may be worth running a quick search for any remaining references (URLs, badges, variable names) using the old name to keep the role naming consistent.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use latest version of codecov @v6
Signed-off-by: Rich Megginson rmeggins@redhat.com
Summary by Sourcery
Align project naming and CI configuration with the trustee_server role instead of trustee_attestation_server.
CI:
Documentation:
Tests: