refactor: handle INJECT_FACTS_AS_VARS=false by using ansible_facts instead

Ansible 2.20 has deprecated the use of Ansible facts as variables.  For
example, `ansible_distribution` is now deprecated in favor of
`ansible_facts["distribution"]`.  This is due to making the default
setting `INJECT_FACTS_AS_VARS=false`.  For now, this will create WARNING
messages, but in Ansible 2.24 it will be an error.

See https://docs.ansible.com/projects/ansible/latest/porting_guides/porting_guide_core_2.20.html#inject-facts-as-vars

Signed-off-by: Rich Megginson <rmeggins@redhat.com>

Author: richm

README-ostree.md

@@ -20,8 +20,8 @@ Usage:
 .ostree/get_ostree_data.sh packages runtime DISTRO-VERSION FORMAT
 ```
 
-`DISTRO-VERSION` is in the format that Ansible uses for `ansible_distribution`
-and `ansible_distribution_version` - for example, `Fedora-38`, `CentOS-8`,
+`DISTRO-VERSION` is in the format that Ansible uses for `ansible_facts["distribution"]`
+and `ansible_facts["distribution_version"]` - for example, `Fedora-38`, `CentOS-8`,
 `RedHat-9.4`
 
 `FORMAT` is one of `toml`, `json`, `yaml`, `raw`

tasks/main.yml

@@ -24,6 +24,8 @@
     # NOTE: Trying to accomplish this without using sudo on the controller
     # Basically, any task, even package_facts:, will use sudo if using
     # become=true - so just use "exists" test to check for /usr/bin/openssl
+    # If you really want the role to install openssl on the controller, you must run
+    # ansible with become=true e.g. ansible-playbook --become ...
     - name: Ensure OpenSSL is installed on the controller
       package:
         name: openssl

tasks/mesh_conf.yml

@@ -6,7 +6,7 @@
   block:
     - name: Set current IP fact for each host
       set_fact:
-        __vpn_current_ip: "{{ ansible_default_ipv4.address | d(ansible_default_ipv6.address) }}"
+        __vpn_current_ip: "{{ ansible_facts['default_ipv4'].address | d(ansible_facts['default_ipv6'].address) }}"
 
     - name: Set IP with prefix register
       shell: |-

tests/tests_include_vars_from_parent.yml

@@ -30,10 +30,10 @@
         # create all variants like CentOS, CentOS_8.1, CentOS-8.1,
         # CentOS-8, CentOS-8.1
         # more formally:
-        # {{ ansible_distribution }}-{{ ansible_distribution_version }}
-        # {{ ansible_distribution }}-{{ ansible_distribution_major_version }}
-        # {{ ansible_distribution }}
-        # {{ ansible_os_family }}
+        # {{ ansible_facts["distribution"] }}-{{ ansible_facts["distribution_version"] }}
+        # {{ ansible_facts["distribution"] }}-{{ ansible_facts["distribution_major_version"] }}
+        # {{ ansible_facts["distribution"] }}
+        # {{ ansible_facts["os_family"] }}
         # and the same for _ as separator.
         varfiles: "{{ [facts['distribution']] | product(separators) |
           map('join') | product(versions) | map('join') | list +

tests/vars/rh_distros_vars.yml

@@ -14,7 +14,7 @@ __vpn_rh_distros:
 __vpn_rh_distros_fedora: "{{ __vpn_rh_distros + ['Fedora'] }}"
 
 # Use this in conditionals to check if distro is Red Hat or clone
-__vpn_is_rh_distro: "{{ ansible_distribution in __vpn_rh_distros }}"
+__vpn_is_rh_distro: "{{ ansible_facts['distribution'] in __vpn_rh_distros }}"
 
 # Use this in conditionals to check if distro is Red Hat or clone, or Fedora
-__vpn_is_rh_distro_fedora: "{{ ansible_distribution in __vpn_rh_distros_fedora }}"
+__vpn_is_rh_distro_fedora: "{{ ansible_facts['distribution'] in __vpn_rh_distros_fedora }}"

vars/main.yml

@@ -37,8 +37,8 @@ __vpn_rh_distros:
 __vpn_rh_distros_fedora: "{{ __vpn_rh_distros + ['Fedora'] }}"
 
 # Use this in conditionals to check if distro is Red Hat or clone
-__vpn_is_rh_distro: "{{ ansible_distribution in __vpn_rh_distros }}"
+__vpn_is_rh_distro: "{{ ansible_facts['distribution'] in __vpn_rh_distros }}"
 
 # Use this in conditionals to check if distro is Red Hat or clone, or Fedora
-__vpn_is_rh_distro_fedora: "{{ ansible_distribution in __vpn_rh_distros_fedora }}"
+__vpn_is_rh_distro_fedora: "{{ ansible_facts['distribution'] in __vpn_rh_distros_fedora }}"
 # END - DO NOT EDIT THIS BLOCK - rh distros variables