Skip to content

Commit 497f9a2

Browse files
committed
.circleci/config.yml + blobs/xx80/t480(s)_download_clean_deguard_me_pad_tb.sh : unify and fix t480s from t480 25.09 coreboot version bump
Also fix paths in board configs to targets that were renamed to be different for t480/t480s (This is why we hate bitroting PR) Signed-off-by: Thierry Laurion <[email protected]>
1 parent e4a57de commit 497f9a2

File tree

4 files changed

+8
-3
lines changed

4 files changed

+8
-3
lines changed

blobs/xx80/t480_download_clean_deguard_me_pad_tb.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ function download_and_clean() {
8282
# Some more general info on shrinking:
8383
# https://github.com/corna/me_cleaner/wiki/External-flashing#neutralize-and-shrink-intel-me-useful-only-for-coreboot
8484

85+
# MFS is needed for deguard so we whitelist it here and also do not relocate the FTPR partition
8586
python "$me_cleaner" --whitelist MFS -t -O "$me_output" "${me_installer_filename}_extracted/Firmware/${extracted_me_filename}"
8687
rm -rf ./*
8788
popd || exit

blobs/xx80/t480s_download_clean_deguard_me_pad_tb.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,11 +72,15 @@ function download_and_clean() {
7272

7373
extracted_me_filename="1 Inspiron_5468_1.3.0 -- 3 Intel Management Engine (Non-VPro) Update v${ME_version}.bin"
7474

75-
# Neutralize and shrink Intel ME. Note that this doesn't include
75+
# Deactivate, partially neuter and shrink Intel ME. Note that this doesn't include
7676
# --soft-disable to set the "ME Disable" or "ME Disable B" (e.g.,
7777
# High Assurance Program) bits, as they are defined within the Flash
7878
# Descriptor.
7979
# However, the HAP bit must be enabled to make the deguarded ME work. We only clean the ME in this function.
80+
# For ME 11.x this means we must keep the rbe, bup, kernel and syslib modules.
81+
# https://github.com/corna/me_cleaner/wiki/How-does-it-work%3F#me-versions-from-11x-skylake-1
82+
# Furthermore, deguard requires keeping the MFS, the HAP bit set, and we cannot relocate the FTPR partition.
83+
# Some more general info on shrinking:
8084
# https://github.com/corna/me_cleaner/wiki/External-flashing#neutralize-and-shrink-intel-me-useful-only-for-coreboot
8185

8286
# MFS is needed for deguard so we whitelist it here and also do not relocate the FTPR partition

boards/EOL_t480-hotp-maximized/EOL_t480-hotp-maximized.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,4 +97,4 @@ export CONFIG_BOOT_KERNEL_REMOVE="intel_iommu=on intel_iommu=igfx_off"
9797
export CONFIG_BOARD_NAME="Thinkpad T480-hotp-maximized"
9898
export CONFIG_FLASH_OPTIONS="flashprog --progress --programmer internal"
9999

100-
BOARD_TARGETS := xx80_me_blobs
100+
BOARD_TARGETS := t480_me_blobs

boards/EOL_t480-maximized/EOL_t480-maximized.config

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,4 +97,4 @@ export CONFIG_BOOT_KERNEL_REMOVE="intel_iommu=on intel_iommu=igfx_off"
9797
export CONFIG_BOARD_NAME="Thinkpad T480-maximized"
9898
export CONFIG_FLASH_OPTIONS="flashprog --progress --programmer internal"
9999

100-
BOARD_TARGETS := xx80_me_blobs
100+
BOARD_TARGETS := t480_me_blobs

0 commit comments

Comments
 (0)