Add support for Acer Chromebook 515 Plus (CB515-2H) / Google Omnigul Platform #1658

mdrobnak · 2024-04-30T04:22:03Z

Implementation of Issue #1663.

This is implemented using the @MrChromebox Coreboot. Linux 6.1.90, Linux 6.5.13, 6.6.30 all work to recognize the UFS storage. This PR uses 6.6.30.

Version 4.22.01 of Coreboot does not have the Intel ME, VBT, or Flash Descriptor, thus MrChromeBox is used.

Items tested:

Issues:

Sealing Disk Unlock Key into TPM does not work.

Configuration Sources:
Linux Configuration based on linux-nitropad-x.config
Coreboot Configuration based on MrChromeBox UEFI configuration. Modified to have Linux payload as per the wiki's instructions.

tlaurion · 2024-05-01T22:44:03Z

@mdrobnak nice!

sign your commits and do commit --signoff
add the board under .circleci/config.yml

We will move from there? You can also join matrix channel and ping me from there, while I prefer PR to be examples for boards porting.

boards/omnigul/omnigul.config

modules/linux

boards/omnigul/omnigul.config

tlaurion

Thanks for this contribution! now let's make this build! Put as draft this PR until ready to be tested by others and to prevent people from bricking their laptop until ready!

mdrobnak · 2024-05-01T23:10:08Z

@mdrobnak nice!

sign your commits and do commit --signoff

add the board under .circleci/config.yml

We will move from there? You can also join matrix channel and ping me from there, while I prefer PR to be examples for boards porting.

Ok I'll get this going shortly.

tlaurion · 2024-05-24T19:35:13Z

@mdrobnak please merge master in this branch and keep this PR updated with the most verbose trail of what your state is, others might chime in and make your progress less lonely :)

modules/linux

tlaurion · 2024-05-28T16:49:12Z

config/coreboot-omnigul.config

+CONFIG_TPM_GOOGLE=y
+CONFIG_TPM_GOOGLE_CR50=y
+CONFIG_TPM_GOOGLE_IMMEDIATELY_COMMIT_FW_SECDATA=y
+CONFIG_GOOGLE_TPM_IRQ_TIMEOUT_MS=100


Might be too small. Is there timeouts in dmesg?

Not that I've seen. I can try modifying that.

mdrobnak · 2024-05-28T16:52:57Z

Disk Unlock:

user@heads-devel:/media$ cat cbmem_L.log 
TPM2 log:
	Specification: 2.00
	Platform class: PC Client
TPM2 log entry 1:
	PCR: 2
	Event type: Action
	Digests:
		 SHA256: 648fd22dbf689a7facd6f6935170dd740bce45c36a7831032e71eb180078ab0c
	Event data: FMAP: FMAP
TPM2 log entry 2:
	PCR: 2
	Event type: Action
	Digests:
		 SHA256: 03796d2e280f07673cb9f6c013443378ffb8290ea709babb83550af82fc940cd
	Event data: CBFS: bootblock
TPM2 log entry 3:
	PCR: 2
	Event type: Action
	Digests:
		 SHA256: e2fee1a8472d4986e5a142c5d15f162835854ea772f0e86d1379a554d4f4ea21
	Event data: CBFS: fallback/romstage
TPM2 log entry 4:
	PCR: 2
	Event type: Action
	Digests:
		 SHA256: 20f555dbb6678b91b75f4d635df597bca7cc6cf2ff477e22bc6e1df6bbea61cb
	Event data: CBFS: fspm.bin
TPM2 log entry 5:
	PCR: 2
	Event type: Action
	Digests:
		 SHA256: 7c52722fdf3eb612144c9e3747fe05dbbcf9e02811a505f6cdd33494da78fc1d
	Event data: CBFS: spd.bin
TPM2 log entry 6:
	PCR: 2
	Event type: Action
	Digests:
		 SHA256: 388468b7b064bf27b13e49d91f6c80d6313a1ea226d9ebfc82aa260382d1bb30
	Event data: CBFS: fallback/postcar
TPM2 log entry 7:
	PCR: 2
	Event type: Action
	Digests:
		 SHA256: ad2053fd5b97f52d3a25edea9500ba0f697accd467d9a6e0f7a3bc22c0a8270b
	Event data: CBFS: fallback/ramstage
TPM2 log entry 8:
	PCR: 2
	Event type: Action
	Digests:
		 SHA256: 970fbc1d69d801604a09967036dbf1c07c514c30a2835a4a53a5295372346b88
	Event data: CBFS: cpu_microcode_blob.bin
TPM2 log entry 9:
	PCR: 2
	Event type: Action
	Digests:
		 SHA256: 3dc0ba24e5dd1c8a2d7880cf6e40e169eb92e193b68d838ad69be08f6cc9a2a6
	Event data: CBFS: fsps.bin
TPM2 log entry 10:
	PCR: 2
	Event type: Action
	Digests:
		 SHA256: 83c94bebba28305531ac7fa841f5075754fec72582fb8ef770e81bd430aadc49
	Event data: CBFS: vbt.bin
TPM2 log entry 11:
	PCR: 2
	Event type: Action
	Digests:
		 SHA256: c9b940f1866ecd4fb8f23a622a17b1b42b59be2dff09d7bc8e8e1a9fb62a8c5b
	Event data: CBFS: fallback/dsdt.aml
TPM2 log entry 12:
	PCR: 2
	Event type: Action
	Digests:
		 SHA256: 2f045194201a13dcffaadf1b295b5d8b156a51e7ca8fb93b05c8927bc2391d9e
	Event data: CBFS: bootsplash.jpg
TPM2 log entry 13:
	PCR: 2
	Event type: Action
	Digests:
		 SHA256: 42e8453008e55c6383763e0ea91699203443bc52ccb259e8185a3ae3d861d3f8
	Event data: CBFS: fallback/payload
user@heads-devel:/media$

Attaching debug.log as that's larger.
debug.log

tlaurion · 2024-05-28T19:53:33Z

As written under matrix thread for this updated PR at https://matrix.to/#/!pAlHOfxQNPXOgFGTmo:matrix.org/$VKP1ynETRMavsOqy3SqUf_nadPUgyoSC9H_13y8Dpjo?via=matrix.org&via=nitro.chat&via=fairydust.space

The white rabbit to be followed is why CR50 TPM refuses to to add TPM DUK nv region into TPM which doesn't seem supported on CR50 not sure why:

TRACE: /bin/tpmr(32): main
TRACE: /bin/tpmr(413): tpm2_seal
DEBUG: tpm2_seal: file=/tmp/secret/secret.key handle=0x81000003 pcrl=0,1,2,3,4,5,6,7 pcrf=/tmp/secret/pcrf.bin pass=<hidden>
LOG: tpmr stderr: WARNING:esys:src/tss2-esys/api/Esys_PolicyPassword.c:292:Esys_PolicyPassword_Finish() Received TPM Error 
LOG: tpmr stderr: ERROR:esys:src/tss2-esys/api/Esys_PolicyPassword.c:106:Esys_PolicyPassword() Esys Finish ErrorCode (0x000b0143) 
LOG: tpmr stderr: ERROR: Esys_PolicyPassword(0xB0143) - rmt:error(2.0): command code not supported
LOG: tpmr stderr: ERROR: Could not build policyauthvalue TPM
LOG: tpmr stderr: ERROR: Unable to run policypassword

boards/omnigul/omnigul.config

mdrobnak · 2024-05-28T20:45:25Z

Attached are two files:
debug_reset_tpm_sign_reboot.log
That file is boot, reset TPM, sign /boot files, copy logs, reboot. (sealing succeeds with policy)

debug_after_reboot_attempt_duk_seal.log
After rebooting, go to OS boot menu, set default, attempt to add Disk Unlock Key. (selling fails with policy)

Tlaurion edit: fail/success notes in parenthesis

tlaurion · 2024-08-07T15:20:47Z

TLDR: Chromebooks have a fTPM which differs from dTPM (documentation and understanding is missing to be supported correctly from the TPM toolstack), correct @mdrobnak ?

Putting this as draft until this is worked seperately.

tlaurion · 2024-09-06T14:01:57Z

@mdrobnak revisiting because interest at https://matrix.to/#/!pAlHOfxQNPXOgFGTmo:matrix.org/$E4N2td-clfQq3IP4F4v_04oSLABpj-Kcm5rNVvDgi30?via=matrix.org&via=nitro.chat&via=envs.net

Not all boards support TPM DUK, and can today be deactivated as a possibility through CONFIG_TPM_NO_LUKS_DISK_UNLOCK that can be added into board config as can be seen checked at

heads/initrd/bin/kexec-save-default

Line 190 in b28c257

    
           if [ "$CONFIG_TPM" = "y" ] && [ "$CONFIG_TPM_NO_LUKS_DISK_UNLOCK" != "y" ] && [ "$CONFIG_BASIC" != y ]; then

Until TPM DUK (seperate secret sealing nvram region issue figured out), Chromebooks could be supported with this bfeature missing? Thoughts?

mdrobnak · 2024-12-20T04:33:11Z

@mdrobnak revisiting because interest at https://matrix.to/#/!pAlHOfxQNPXOgFGTmo:matrix.org/$E4N2td-clfQq3IP4F4v_04oSLABpj-Kcm5rNVvDgi30?via=matrix.org&via=nitro.chat&via=envs.net

Not all boards support TPM DUK, and can today be deactivated as a possibility through CONFIG_TPM_NO_LUKS_DISK_UNLOCK that can be added into board config as can be seen checked at

heads/initrd/bin/kexec-save-default

Line 190 in b28c257

if [ "$CONFIG_TPM" = "y" ] && [ "$CONFIG_TPM_NO_LUKS_DISK_UNLOCK" != "y" ] && [ "$CONFIG_BASIC" != y ]; then

Until TPM DUK (seperate secret sealing nvram region issue figured out), Chromebooks could be supported with this bfeature missing? Thoughts?

I think that makes perfect sense to do this.

I am updating my PR as I just rebased it off master a few minutes ago, and it seems fine at first glance.

-Matt

tlaurion · 2025-02-13T22:27:06Z

@mdrobnak sorry for the delay. If you could rebase this on master, I think that could be reviewed and merged!

tlaurion · 2025-03-02T18:30:30Z

@mdrobnak ping

mdrobnak · 2025-03-03T02:48:23Z

@tlaurion Sorry, meant to respond earlier. It's been a bit hectic here - I have it on my To-Do list for this week.

Board configuration from: nitropad-nv41. Linux configuration from: linux-nitropad-x.config Coreboot configuration from: MrChromeBox EDK2 configuration for omnigul. Signed-off-by: Matthew Drobnak <[email protected]>

Signed-off-by: Matthew Drobnak <[email protected]>

mdrobnak · 2025-03-06T01:03:10Z

I rebased the bracnh, haven't tested a new flash yet. Should be able to do that tomorrow at some point.

Use MrChromeBox Coreboot and Linux 6.6.30. Add CircleCI Board config. Signed-off-by: Matthew Drobnak <[email protected]>

tlaurion · 2025-03-06T22:00:20Z

Pushed changes in branch https://github.com/tlaurion/heads/tree/mdrobnak-google_omnigul

revert linux to 6.1.8, bump mrchromebox to 24.02, add patches of 24.02.01, uniformize board config, add PR0 requirements (to be tested)

@mdrobnak cherry-pick, amend merge after testing.

mdrobnak · 2025-03-25T12:51:14Z

Initial test build met with error, I haven't gotten back to it yet.

2025-03-21 15:01:26+00:00 CPIO      build/x86/omnigul/tools.cpio
2025-03-21 15:01:26+00:00 UNCHANGED build/x86/omnigul/tools.cpio
e66f30bcd375d1d5f16e919513480b4fe61dbfd68a6e0d84dfa4c3ef308aa83f  /ssdpool/home/mdrobnak/heads-google/build/x86/omnigul/tools.cpio
18902528:/ssdpool/home/mdrobnak/heads-google/build/x86/omnigul/tools.cpio
2025-03-21 15:01:27+00:00 HASHES    build/x86/omnigul/tools.cpio
2025-03-21 15:01:27+00:00 SIZES     build/x86/omnigul/tools.cpio
2025-03-21 15:01:27+00:00 CPIO      build/x86/omnigul/heads.cpio
2025-03-21 15:01:27+00:00 UNCHANGED build/x86/omnigul/heads.cpio
1672750cf86abf26d685f67dc8a19d6a08f11868ae42ac17b06ebbb684f86c89  /ssdpool/home/mdrobnak/heads-google/build/x86/omnigul/heads.cpio
  426496:/ssdpool/home/mdrobnak/heads-google/build/x86/omnigul/heads.cpio
2025-03-21 15:01:27+00:00 HASHES    build/x86/omnigul/heads.cpio
2025-03-21 15:01:27+00:00 SIZES     build/x86/omnigul/heads.cpio
2025-03-21 15:01:27+00:00 MAKE coreboot-mrchromebox
tail /ssdpool/home/mdrobnak/heads-google/build/x86/log/coreboot-mrchromebox.log
-----
cc1: all warnings being treated as errors
cc1: all warnings being treated as errors
firmware/2lib/2misc.c: In function 'vb2_validate_gbb_signature':
firmware/2lib/2misc.c:23:9: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
   23 |         const static uint8_t sig_xor[VB2_GBB_SIGNATURE_SIZE] =
      |         ^~~~~
make[2]: *** [Makefile:1163: /ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox/omnigul/external/vboot_reference-postcar/firmware/lib/cgptlib/cgptlib_internal.o] Error 1
make[2]: *** Waiting for unfinished jobs....
cc1: all warnings being treated as errors
make[2]: *** [Makefile:1164: /ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox/omnigul/external/vboot_reference-romstage/firmware/lib/cgptlib/cgptlib_internal.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:1163: /ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox/omnigul/external/vboot_reference-ramstage/firmware/2lib/2misc.o] Error 1
make[1]: *** [src/security/vboot/Makefile.mk:54: omnigul/external/vboot_reference-ramstage/vboot_fw.a] Error 2
cc1: all warnings being treated as errors
make[2]: *** [Makefile:1163: /ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox/omnigul/external/vboot_reference-postcar/firmware/2lib/2misc.o] Error 1
make[1]: *** [src/security/vboot/Makefile.mk:55: omnigul/external/vboot_reference-postcar/vboot_fw.a] Error 2
cc1: all warnings being treated as errors
make[2]: *** [Makefile:1163: /ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox/omnigul/external/vboot_reference-romstage/firmware/2lib/2misc.o] Error 1
make[1]: *** [src/security/vboot/Makefile.mk:52: omnigul/external/vboot_reference-romstage/vboot_fw.a] Error 2
make[1]: Leaving directory '/ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox'
make: *** [Makefile:570: /ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox/omnigul/.build] Error 1

-Matt

Input for linuxboot#1658 (Sorry but bitrot is a thing. 24.12 is 2024/12 coreboot, which is already old. Nobody supports old versions of things. So if things break, this needs to be at least reported on a recent branch upstream, where here, upstream is MrChromebox coreboot fork) make -C "/home/user/heads/build/x86/coreboot-mrchromebox/omnigul" -C /home/user/heads/build/x86/coreboot-mrchromebox obj=/home/user/heads/build/x86/coreboot-mrchromebox/omnigul DOTCONFIG=/home/user/heads/build/x86/coreboot-mrchromebox/omnigul/.config XGCCPATH=/home/user/heads/build/x86/coreboot-24.02.01/util/crossgcc/xgcc/bin/ BUILD_TIMELESS=1 -j1 --load-average=1 make[1]: Entering directory '/home/user/heads/build/x86/coreboot-mrchromebox' Updating git submodules. Skipping submodule '3rdparty/amd_blobs' Skipping submodule '3rdparty/blobs' Skipping submodule '3rdparty/cmocka' Skipping submodule '3rdparty/fsp' Skipping submodule '3rdparty/intel-microcode' Skipping submodule '3rdparty/qc_blobs' fatal: remote error: upload-pack: not our ref 7fd3d98a73e64f628c730e079769f0737e00ebc3 fatal: Fetched in submodule path '3rdparty/vboot', but it did not contain 7fd3d98a73e64f628c730e079769f0737e00ebc3. Direct fetching of that commit failed. Then make in debug 'reset && ./docker_repro.sh make -d BOARD=omnigul V=1 CPUS=1' excerpt: [...] FIRMWARE_ARCH=x86 CC="/home/user/heads/build/x86/coreboot-24.02.01/util/crossgcc/xgcc/bin/i386-elf-gcc" CFLAGS="-I/home/user/heads/build/x86/coreboot-mrchromebox/src -I/home/user/heads/build/x86/coreboot-mrchromebox/src/include -I/home/user/heads/build/x86/coreboot-mrchromebox/src/commonlib/include -I/home/user/heads/build/x86/coreboot-mrchromebox/src/commonlib/bsd/include -I/home/user/heads/build/x86/coreboot-mrchromebox/3rdparty/vboot/firmware/include -include /home/user/heads/build/x86/coreboot-mrchromebox/src/include/kconfig.h -include /home/user/heads/build/x86/coreboot-mrchromebox/src/include/rules.h -include /home/user/heads/build/x86/coreboot-mrchromebox/src/commonlib/bsd/include/commonlib/bsd/compiler.h -I/home/user/heads/build/x86/coreboot-mrchromebox/3rdparty -D__BUILD_DIR__=\"omnigul\" -D__TIMELESS__ -I/home/user/heads/build/x86/coreboot-mrchromebox/src/soc/intel/alderlake -I/home/user/heads/build/x86/coreboot-mrchromebox/src/soc/intel/alderlake/include -I/home/user/heads/build/x86/coreboot-mrchromebox/src/drivers/intel/fsp2_0/include -I/home/user/heads/build/x86/coreboot-mrchromebox/"3rdparty/fsp/RaptorLakeFspBinPkg/Client/RaptorLakeP/Include/" -I/home/user/heads/build/x86/coreboot-mrchromebox/src/mainboard/google/brya/variants/baseboard/include -I/home/user/heads/build/x86/coreboot-mrchromebox/src/mainboard/google/brya/variants/baseboard/brya/include -I/home/user/heads/build/x86/coreboot-mrchromebox/src/mainboard/google/brya/variants/omnigul/include -I/home/user/heads/build/x86/coreboot-mrchromebox/src/soc/intel/common/basecode/include/ -I/home/user/heads/build/x86/coreboot-mrchromebox/src/soc/intel/common/block/include/ -I/home/user/heads/build/x86/coreboot-mrchromebox/src/soc/intel/common/pch/include/ -I/home/user/heads/build/x86/coreboot-mrchromebox/src/vendorcode/intel/edk2/edk2-stable202005/MdePkg/Include -I/home/user/heads/build/x86/coreboot-mrchromebox/src/vendorcode/intel/edk2/edk2-stable202005/IntelFsp2Pkg/Include -I/home/user/heads/build/x86/coreboot-mrchromebox/src/vendorcode/intel/edk2/edk2-stable202005/MdeModulePkg/Include -I/home/user/heads/build/x86/coreboot-mrchromebox/src/soc/intel/common/block/fast_spi -I/home/user/heads/build/x86/coreboot-mrchromebox/src/arch/x86/include -I/home/user/heads/build/x86/coreboot-mrchromebox/src/vendorcode/intel/edk2/edk2-stable202005/MdePkg/Include/Ia32 -D__ARCH_x86_32__ -pipe -g -nostdinc -std=gnu11 -nostdlib -Wall -Wundef -Wstrict-prototypes -Wmissing-prototypes -Wwrite-strings -Wredundant-decls -Wno-trigraphs -Wimplicit-fallthrough -Wshadow -Wdate-time -Wtype-limits -Wvla -Wold-style-definition -Wdangling-else -Wmissing-include-dirs -fno-common -ffreestanding -fno-builtin -fomit-frame-pointer -fstrict-aliasing -ffunction-sections -fdata-sections -fno-pie -Wold-style-declaration -Wno-packed-not-aligned -fconserve-stack -Wnull-dereference -Wlogical-op -Wduplicated-cond -Wno-array-compare -Werror -Os -Wno-address-of-packed-member --param=min-pagesize=1024 -m32 -fuse-ld=bfd -fno-stack-protector -Wl,--build-id=none -fno-delete-null-pointer-checks -Wlogical-op -march=i686 -mno-mmx -mno-sse -D__ROMSTAGE__ -I/home/user/heads/build/x86/coreboot-mrchromebox/omnigul -Wno-missing-prototypes -DVBOOT_DEBUG" VBOOT2="y" EC_EFS="" X86_SHA_EXT="" VB2_X86_RSA_ACCELERATION="" ARMV8_CRYPTO_EXT="" make -C 3rdparty/vboot BUILD=/home/user/heads/build/x86/coreboot-mrchromebox/omnigul/external/vboot_reference-romstage V=1 USE_FLASHROM=0 fwlib Live child 0x18606460 (omnigul/external/vboot_reference-romstage/vboot_fw.a) PID 2751 GNU Make 4.4.1 Built for x86_64-pc-linux-gnu Copyright (C) 1988-2023 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <https://gnu.org/licenses/gpl.html> This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Reading makefiles... Updating makefiles.... Considering target file 'GNUmakefile'. File 'GNUmakefile' does not exist. Looking for an implicit rule for 'GNUmakefile'. No implicit rule found for 'GNUmakefile'. Finished prerequisites of target file 'GNUmakefile'. Must remake target 'GNUmakefile'. Failed to remake target file 'GNUmakefile'. Considering target file 'makefile'. File 'makefile' does not exist. Looking for an implicit rule for 'makefile'. No implicit rule found for 'makefile'. Finished prerequisites of target file 'makefile'. Must remake target 'makefile'. Failed to remake target file 'makefile'. Considering target file 'Makefile'. File 'Makefile' does not exist. Looking for an implicit rule for 'Makefile'. No implicit rule found for 'Makefile'. Finished prerequisites of target file 'Makefile'. Must remake target 'Makefile'. Failed to remake target file 'Makefile'. Updating goal targets.... Considering target file 'fwlib'. File 'fwlib' does not exist. Looking for an implicit rule for 'fwlib'. No implicit rule found for 'fwlib'. Finished prerequisites of target file 'fwlib'. Must remake target 'fwlib'. make[2]: *** No rule to make target 'fwlib'. Stop. Reaping losing child 0x18606460 PID 2751 make[1]: *** [src/security/vboot/Makefile.mk:52: omnigul/external/vboot_reference-romstage/vboot_fw.a] Error 2 Seems like something is wrong with mrchromebox + 24.02.04/24.12. Reporting to MrChromebox would help Signed-off-by: Thierry Laurion <[email protected]>

…hes, cp Pr0 patch from 24.12, save coreboot config Input for linuxboot#1658 Repro: echo "bogus" | sudo tee build/x86/coreboot-mrchromebox/.canary #make sure coreboot witches to proper fork+commit+applies patch ./docker_repro.sh make BOARD=omnigul #Builds 24.12 shared crossgcc buildstack + clone + patch + builds with previous coreboot config ./docker_repro.sh make BOARD=omnigul coreboot.modify_defconfig_in_place # review defconfig: remove things deviating on default on which we are unsure ./docker_repro.sh make BOARD=omnigul coreboot.modify_and_save_oldconfig_in_place # review changes. ./docker_repro.sh make BOARD=omnigul # check if builds Builds locally. Todo: - review changes of config - easy to do with './docker_repro.sh make BOARD=omnigul coreboot.modify_defconfig_in_place' which shows deviation from boards defaults. Signed-off-by: Thierry Laurion <[email protected]>

tlaurion · 2025-03-26T15:06:19Z

Initial test build met with error, I haven't gotten back to it yet.

2025-03-21 15:01:26+00:00 CPIO      build/x86/omnigul/tools.cpio
2025-03-21 15:01:26+00:00 UNCHANGED build/x86/omnigul/tools.cpio
e66f30bcd375d1d5f16e919513480b4fe61dbfd68a6e0d84dfa4c3ef308aa83f  /ssdpool/home/mdrobnak/heads-google/build/x86/omnigul/tools.cpio
18902528:/ssdpool/home/mdrobnak/heads-google/build/x86/omnigul/tools.cpio
2025-03-21 15:01:27+00:00 HASHES    build/x86/omnigul/tools.cpio
2025-03-21 15:01:27+00:00 SIZES     build/x86/omnigul/tools.cpio
2025-03-21 15:01:27+00:00 CPIO      build/x86/omnigul/heads.cpio
2025-03-21 15:01:27+00:00 UNCHANGED build/x86/omnigul/heads.cpio
1672750cf86abf26d685f67dc8a19d6a08f11868ae42ac17b06ebbb684f86c89  /ssdpool/home/mdrobnak/heads-google/build/x86/omnigul/heads.cpio
  426496:/ssdpool/home/mdrobnak/heads-google/build/x86/omnigul/heads.cpio
2025-03-21 15:01:27+00:00 HASHES    build/x86/omnigul/heads.cpio
2025-03-21 15:01:27+00:00 SIZES     build/x86/omnigul/heads.cpio
2025-03-21 15:01:27+00:00 MAKE coreboot-mrchromebox
tail /ssdpool/home/mdrobnak/heads-google/build/x86/log/coreboot-mrchromebox.log
-----
cc1: all warnings being treated as errors
cc1: all warnings being treated as errors
firmware/2lib/2misc.c: In function 'vb2_validate_gbb_signature':
firmware/2lib/2misc.c:23:9: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
   23 |         const static uint8_t sig_xor[VB2_GBB_SIGNATURE_SIZE] =
      |         ^~~~~
make[2]: *** [Makefile:1163: /ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox/omnigul/external/vboot_reference-postcar/firmware/lib/cgptlib/cgptlib_internal.o] Error 1
make[2]: *** Waiting for unfinished jobs....
cc1: all warnings being treated as errors
make[2]: *** [Makefile:1164: /ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox/omnigul/external/vboot_reference-romstage/firmware/lib/cgptlib/cgptlib_internal.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:1163: /ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox/omnigul/external/vboot_reference-ramstage/firmware/2lib/2misc.o] Error 1
make[1]: *** [src/security/vboot/Makefile.mk:54: omnigul/external/vboot_reference-ramstage/vboot_fw.a] Error 2
cc1: all warnings being treated as errors
make[2]: *** [Makefile:1163: /ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox/omnigul/external/vboot_reference-postcar/firmware/2lib/2misc.o] Error 1
make[1]: *** [src/security/vboot/Makefile.mk:55: omnigul/external/vboot_reference-postcar/vboot_fw.a] Error 2
cc1: all warnings being treated as errors
make[2]: *** [Makefile:1163: /ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox/omnigul/external/vboot_reference-romstage/firmware/2lib/2misc.o] Error 1
make[1]: *** [src/security/vboot/Makefile.mk:52: omnigul/external/vboot_reference-romstage/vboot_fw.a] Error 2
make[1]: Leaving directory '/ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox'
make: *** [Makefile:570: /ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox/omnigul/.build] Error 1

-Matt

Sorry about bitrotting things once more. T480 and all other board bumped to coreboot 24.12, so I did so and left commit log notes for you to review under tlaurion@c03aeaf which should build (it built locally).

Builds are happening at https://app.circleci.com/pipelines/github/tlaurion/heads/3260/workflows/6221b495-5b55-4949-8f68-2616f2f31302 and should finish in an hour or so.

So if we act somehow fast here (not another 6 months) maintaining this board once merged should be easy enough.

Please see testing notes under pending for merge doc per linuxboot/heads-wiki#184

rendered at https://notgivenby.github.io/heads-wiki/Porting/ until merged
- Specifically for https://notgivenby.github.io/heads-wiki/Porting/#testing

Extract here for testing TODOs:

CC @mdrobnak

tlaurion · 2025-03-26T15:21:57Z

Initial test build met with error, I haven't gotten back to it yet.

2025-03-21 15:01:26+00:00 CPIO      build/x86/omnigul/tools.cpio
2025-03-21 15:01:26+00:00 UNCHANGED build/x86/omnigul/tools.cpio
e66f30bcd375d1d5f16e919513480b4fe61dbfd68a6e0d84dfa4c3ef308aa83f  /ssdpool/home/mdrobnak/heads-google/build/x86/omnigul/tools.cpio
18902528:/ssdpool/home/mdrobnak/heads-google/build/x86/omnigul/tools.cpio
2025-03-21 15:01:27+00:00 HASHES    build/x86/omnigul/tools.cpio
2025-03-21 15:01:27+00:00 SIZES     build/x86/omnigul/tools.cpio
2025-03-21 15:01:27+00:00 CPIO      build/x86/omnigul/heads.cpio
2025-03-21 15:01:27+00:00 UNCHANGED build/x86/omnigul/heads.cpio
1672750cf86abf26d685f67dc8a19d6a08f11868ae42ac17b06ebbb684f86c89  /ssdpool/home/mdrobnak/heads-google/build/x86/omnigul/heads.cpio
  426496:/ssdpool/home/mdrobnak/heads-google/build/x86/omnigul/heads.cpio
2025-03-21 15:01:27+00:00 HASHES    build/x86/omnigul/heads.cpio
2025-03-21 15:01:27+00:00 SIZES     build/x86/omnigul/heads.cpio
2025-03-21 15:01:27+00:00 MAKE coreboot-mrchromebox
tail /ssdpool/home/mdrobnak/heads-google/build/x86/log/coreboot-mrchromebox.log
-----
cc1: all warnings being treated as errors
cc1: all warnings being treated as errors
firmware/2lib/2misc.c: In function 'vb2_validate_gbb_signature':
firmware/2lib/2misc.c:23:9: error: 'static' is not at beginning of declaration [-Werror=old-style-declaration]
   23 |         const static uint8_t sig_xor[VB2_GBB_SIGNATURE_SIZE] =
      |         ^~~~~
make[2]: *** [Makefile:1163: /ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox/omnigul/external/vboot_reference-postcar/firmware/lib/cgptlib/cgptlib_internal.o] Error 1
make[2]: *** Waiting for unfinished jobs....
cc1: all warnings being treated as errors
make[2]: *** [Makefile:1164: /ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox/omnigul/external/vboot_reference-romstage/firmware/lib/cgptlib/cgptlib_internal.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: *** [Makefile:1163: /ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox/omnigul/external/vboot_reference-ramstage/firmware/2lib/2misc.o] Error 1
make[1]: *** [src/security/vboot/Makefile.mk:54: omnigul/external/vboot_reference-ramstage/vboot_fw.a] Error 2
cc1: all warnings being treated as errors
make[2]: *** [Makefile:1163: /ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox/omnigul/external/vboot_reference-postcar/firmware/2lib/2misc.o] Error 1
make[1]: *** [src/security/vboot/Makefile.mk:55: omnigul/external/vboot_reference-postcar/vboot_fw.a] Error 2
cc1: all warnings being treated as errors
make[2]: *** [Makefile:1163: /ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox/omnigul/external/vboot_reference-romstage/firmware/2lib/2misc.o] Error 1
make[1]: *** [src/security/vboot/Makefile.mk:52: omnigul/external/vboot_reference-romstage/vboot_fw.a] Error 2
make[1]: Leaving directory '/ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox'
make: *** [Makefile:570: /ssdpool/home/mdrobnak/heads-google/build/x86/coreboot-mrchromebox/omnigul/.build] Error 1

-Matt

(As for reason of why vboot failed: it was because the commit searched by coreboot fork used commit to be used for vboot submodule didn't exist. Cannot report bug for old version, but modules/coreboot 24.12, reusing 24.12 buildstack for all most Heads used boards upstream were bumped to 24.12 under #1908 so I invested time moving this forward instead of reporting bug for 24.02.01 which is now more than year old (Coreboot release versioning scheme changed to YY.MM: 24.02 is Feb 2024, 24.12 is December 24.12: most downstream coreboot forks used into Heads are either under 24.12 or will be soon, so it was logical for me to do this instead of fixing what doen't work in downstream forks, patching etc).

Sorry again for PR bitrotting side effects. We shouldbe good to merge soon if all is good on your side testing wise @mdrobnak

mdrobnak · 2025-04-03T01:37:40Z

Good news is that initial testing with your updated items does seem to work just fine. I'm hoping to get things cleaned up and run through yout test checklist next week.

mdrobnak · 2025-04-12T03:45:38Z

These are the only options when going through Coreboot that caught my eye, not sure if they are as desired:

 [ ] Validate Intel firmware descriptor
 [ ] Lock down chipset in coreboot 
 Protect flash regions (Unlock flash regions)  --->
 [*] Support Intel PCI-e WiFi adapters
 [*] Support MediaTek PCI-e WiFi adapters
 Boot media protection mechanism (Lock boot media using the controller)  --->
 Boot media protected regions (Write-protect the whole boot medium)  --->
 [*] Perform MP Initialization by FSP using coreboot MP PPI service (NEW)
 [*] Total Memory Encryption (TME)/Multi-key TME (MKTME) (NEW)

Aside from the version string...that's really the only thing I changed.

As far as that testing guide...I'll re-do the stuff that doesn't require me to takt this thing aapart and re-instrall stuff... I have tested those items in the past and they did work as expected..

-Matt

tlaurion · 2025-04-12T04:09:34Z

These are the only options when going through Coreboot that caught my eye, not sure if they are as desired:
 [ ] Validate Intel firmware descriptor
 [ ] Lock down chipset in coreboot 
 Protect flash regions (Unlock flash regions)  --->
 [*] Support Intel PCI-e WiFi adapters
 [*] Support MediaTek PCI-e WiFi adapters
 Boot media protection mechanism (Lock boot media using the controller)  --->
 Boot media protected regions (Write-protect the whole boot medium)  --->
 [*] Perform MP Initialization by FSP using coreboot MP PPI service (NEW)
 [*] Total Memory Encryption (TME)/Multi-key TME (MKTME) (NEW)
Aside from the version string...that's really the only thing I changed.

As far as that testing guide...I'll re-do the stuff that doesn't require me to takt this thing aapart and re-instrall stuff... I have tested those items in the past and they did work as expected..

-Matt

Will reverify the configs against other boards when I have a chance.

Cannot merge if untested. Cannot test if unsure of configs. Not fresh in my mind anymore, will try to find time to check in the next days.

mdrobnak · 2025-05-05T13:43:55Z

I will leave my branch on my fork up, but at this point I do not have the resources to dedicate to this. It was slightly over a year ago I opened this PR. I appreciate all that has been done on this project, but to me this exercise felt like a constantly changing target. I wish you success with the project. At this time, I'm closing this PR.

tlaurion · 2025-05-06T01:44:40Z

@mdrobnak if I do a superseeding PR with changes needed, is there a date forward you would be willing to test Circleci rom with readiness to revert to backup in chance of a brick or are we willing to leave this work go to waste?

Sorry for the feeling of this being a moving target. I'll try to find time to update the porting guide with timely testing requirements for pull requests to not bitrot otherwise yes, this is a moving target until I can version bump merged stuff all at once across all boards.

If there is no interest in testing this in a timely manner it's OK as well, I'll make sure there is common understanding in the porting guide as well.

mdrobnak · 2025-05-06T02:22:50Z

I tested the initial flash procedures the last time around. I am not reverting the box back to ChromeOS and doing all of this again. I will not re-test that. That is not a small time investment. Sorry.

The main reason for the time delay was the lack of doing disk unlock with the CR50. Had we said "this is OK without this" we would have been done significantly sooner, and we would not be in this spot.

Again, I like the project, I wish you the best, but I'm out.

-Matt

tlaurion reviewed May 1, 2024

View reviewed changes

boards/omnigul/omnigul.config Outdated Show resolved Hide resolved

tlaurion reviewed May 1, 2024

View reviewed changes

modules/linux Outdated Show resolved Hide resolved

tlaurion reviewed May 1, 2024

View reviewed changes

boards/omnigul/omnigul.config Show resolved Hide resolved

tlaurion requested changes May 1, 2024

View reviewed changes

tlaurion marked this pull request as draft May 1, 2024 22:49

mdrobnak force-pushed the google_omnigul branch from 018b4c7 to 557c088 Compare May 4, 2024 04:40

mdrobnak mentioned this pull request May 5, 2024

Add support for Acer Chromebook 515 Plus (CB515-2H) / Google Omnigul Platform #1663

Open

mdrobnak force-pushed the google_omnigul branch 2 times, most recently from a291bcf to 0edf836 Compare May 28, 2024 03:11

mdrobnak marked this pull request as ready for review May 28, 2024 16:41

tlaurion self-assigned this May 28, 2024

tlaurion reviewed May 28, 2024

View reviewed changes

modules/linux Outdated Show resolved Hide resolved

tlaurion reviewed May 28, 2024

View reviewed changes

mdrobnak force-pushed the google_omnigul branch from 0edf836 to 5c5f61e Compare May 28, 2024 18:54

tlaurion reviewed May 28, 2024

View reviewed changes

boards/omnigul/omnigul.config Show resolved Hide resolved

tlaurion marked this pull request as draft August 7, 2024 15:20

This was referenced Nov 16, 2024

Chromebook cr50: not able to seal secret in nvram tpm2-software/tpm2-tools#3434

Open

TPM 2.0 with Cr50 MrChromebox/firmware#626

Open

mdrobnak force-pushed the google_omnigul branch from aad0461 to 7388cab Compare December 20, 2024 04:37

tlaurion added the port new board addition from existing coreboot port label Feb 13, 2025

mdrobnak added 5 commits March 6, 2025 00:53

Add support for MrChromeBox coreboot fork.

75ccfe5

Signed-off-by: Matthew Drobnak <[email protected]>

Add Support for Linux 6.6.30 (same patches a 4.9.80).

0eb2b7f

Signed-off-by: Matthew Drobnak <[email protected]>

Update omnigul base linux config (Nitropad NV41) to Linux 6.6.

c5f02af

Signed-off-by: Matthew Drobnak <[email protected]>

Save Omnigul coreboot config in oldconfig format before making changes.

f25c0f7

Signed-off-by: Matthew Drobnak <[email protected]>

mdrobnak force-pushed the google_omnigul branch from 7388cab to a8d7776 Compare March 6, 2025 01:00

Add support for Acer Chromebook 515 Plus (CB515-2H) / Google Omnigul

37c6886

Use MrChromeBox Coreboot and Linux 6.6.30. Add CircleCI Board config. Signed-off-by: Matthew Drobnak <[email protected]>

mdrobnak force-pushed the google_omnigul branch from a8d7776 to 37c6886 Compare March 6, 2025 20:24

mdrobnak marked this pull request as ready for review March 6, 2025 20:24

mdrobnak requested a review from tlaurion March 6, 2025 20:24

tlaurion mentioned this pull request Mar 26, 2025

update the porting guide linuxboot/heads-wiki#184

Merged

mdrobnak closed this May 5, 2025

tlaurion mentioned this pull request May 5, 2025

t480s port #1966

Draft

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Acer Chromebook 515 Plus (CB515-2H) / Google Omnigul Platform #1658

Add support for Acer Chromebook 515 Plus (CB515-2H) / Google Omnigul Platform #1658

mdrobnak commented Apr 30, 2024 •

edited

Loading

tlaurion commented May 1, 2024

tlaurion left a comment

mdrobnak commented May 1, 2024

tlaurion commented May 24, 2024

tlaurion May 28, 2024

mdrobnak May 28, 2024

mdrobnak commented May 28, 2024

tlaurion commented May 28, 2024

mdrobnak commented May 28, 2024 •

edited by tlaurion

Loading

tlaurion commented Aug 7, 2024

tlaurion commented Sep 6, 2024

mdrobnak commented Dec 20, 2024

tlaurion commented Feb 13, 2025

tlaurion commented Mar 2, 2025

mdrobnak commented Mar 3, 2025

mdrobnak commented Mar 6, 2025

tlaurion commented Mar 6, 2025

mdrobnak commented Mar 25, 2025

tlaurion commented Mar 26, 2025 •

edited

Loading

tlaurion commented Mar 26, 2025

mdrobnak commented Apr 3, 2025

mdrobnak commented Apr 12, 2025

tlaurion commented Apr 12, 2025

mdrobnak commented May 5, 2025

tlaurion commented May 6, 2025 •

edited

Loading

mdrobnak commented May 6, 2025

Add support for Acer Chromebook 515 Plus (CB515-2H) / Google Omnigul Platform #1658

Add support for Acer Chromebook 515 Plus (CB515-2H) / Google Omnigul Platform #1658

Conversation

mdrobnak commented Apr 30, 2024 • edited Loading

tlaurion commented May 1, 2024

tlaurion left a comment

Choose a reason for hiding this comment

mdrobnak commented May 1, 2024

tlaurion commented May 24, 2024

tlaurion May 28, 2024

Choose a reason for hiding this comment

mdrobnak May 28, 2024

Choose a reason for hiding this comment

mdrobnak commented May 28, 2024

tlaurion commented May 28, 2024

mdrobnak commented May 28, 2024 • edited by tlaurion Loading

tlaurion commented Aug 7, 2024

tlaurion commented Sep 6, 2024

mdrobnak commented Dec 20, 2024

tlaurion commented Feb 13, 2025

tlaurion commented Mar 2, 2025

mdrobnak commented Mar 3, 2025

mdrobnak commented Mar 6, 2025

tlaurion commented Mar 6, 2025

mdrobnak commented Mar 25, 2025

tlaurion commented Mar 26, 2025 • edited Loading

tlaurion commented Mar 26, 2025

mdrobnak commented Apr 3, 2025

mdrobnak commented Apr 12, 2025

tlaurion commented Apr 12, 2025

mdrobnak commented May 5, 2025

tlaurion commented May 6, 2025 • edited Loading

mdrobnak commented May 6, 2025

mdrobnak commented Apr 30, 2024 •

edited

Loading

mdrobnak commented May 28, 2024 •

edited by tlaurion

Loading

tlaurion commented Mar 26, 2025 •

edited

Loading

tlaurion commented May 6, 2025 •

edited

Loading