-
Notifications
You must be signed in to change notification settings - Fork 140
feat: add privacy configuration for control center #2944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added a new privacy configuration file for the control center module. This configuration defines a permission blacklist setting that allows the system to manage and cache restricted permissions. The setting includes support for Chinese localization and is marked as private with read-write permissions for authorized access. Log: Added privacy configuration with permission blacklist support Influence: 1. Verify the configuration file is properly loaded by the control center 2. Test that the permission blacklist setting can be read and written correctly 3. Check Chinese localization displays properly in the UI 4. Ensure private visibility restricts unauthorized access to the setting 5. Validate that the configuration structure follows the expected dsg format feat: 为控制中心添加隐私配置文件 新增控制中心模块的隐私配置文件。此配置定义了一个权限黑名单设置,允许系统 管理和缓存受限权限。该设置包含中文本地化支持,并标记为私有,仅允许授权访 问的读写权限。 Log: 新增支持权限黑名单的隐私配置 Influence: 1. 验证控制中心是否正确加载配置文件 2. 测试权限黑名单设置能否正确读写 3. 检查中文本地化在界面中是否正确显示 4. 确保私有可见性限制了对该设置的未授权访问 5. 验证配置结构是否符合预期的 dsg 格式
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds a new privacy configuration JSON for the control center module, defining a private, read‑write permission blacklist setting with Chinese localization and ensuring it follows the expected DSG configuration format. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've left some high level feedback:
- Compare the new org.deepin.dde.control-center.privacy.json structure and key naming with existing privacy config JSONs to ensure the dsg schema, field names, and types are fully consistent across modules.
- Verify that the permission blacklist’s default value and scope (e.g., whether it starts empty or pre-populated) match the intended behavior of the control center so that enabling this config doesn’t unexpectedly block existing permissions.
- Check that all localized fields (including descriptions, categories, and any help text) are provided both in Chinese and other supported locales, and that the localization keys follow the same pattern as other privacy settings.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Compare the new org.deepin.dde.control-center.privacy.json structure and key naming with existing privacy config JSONs to ensure the dsg schema, field names, and types are fully consistent across modules.
- Verify that the permission blacklist’s default value and scope (e.g., whether it starts empty or pre-populated) match the intended behavior of the control center so that enabling this config doesn’t unexpectedly block existing permissions.
- Check that all localized fields (including descriptions, categories, and any help text) are provided both in Chinese and other supported locales, and that the localization keys follow the same pattern as other privacy settings.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
deepin pr auto review这是一个关于 DDE (Deepin Desktop Environment) 控制中心隐私配置的 JSON 配置文件 diff。该文件用于定义一个新的配置项 以下是对该文件的审查意见,分为语法逻辑、代码质量、代码性能和代码安全四个方面: 1. 语法逻辑
2. 代码质量
3. 代码性能
4. 代码安全
总结与建议修改该配置文件整体结构合规,但在国际化和描述完整性上有所欠缺。建议修改如下: {
"magic": "dsg.config.meta",
"version": "1.0",
"contents": {
"permissionBlacklist": {
"value": "",
"serial": 0,
"flags": [],
"name": "permission_blacklist",
"name[zh_CN]": "权限黑名单",
"name": "Permission Blacklist",
"description[zh_CN]": "用于缓存应用程序权限黑名单",
"description": "Cache for storing application permission blacklists",
"permissions": "readwrite",
"visibility": "private"
}
}
}主要变更点:
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mhduiy, yixinshark The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/forcemerge |
|
This pr force merged! (status: blocked) |
Added a new privacy configuration file for the control center module. This configuration defines a permission blacklist setting that allows the system to manage and cache restricted permissions. The setting includes support for Chinese localization and is marked as private with read-write permissions for authorized access.
Log: Added privacy configuration with permission blacklist support
Influence:
feat: 为控制中心添加隐私配置文件
新增控制中心模块的隐私配置文件。此配置定义了一个权限黑名单设置,允许系统
管理和缓存受限权限。该设置包含中文本地化支持,并标记为私有,仅允许授权访
问的读写权限。
Log: 新增支持权限黑名单的隐私配置
Influence:
Summary by Sourcery
Add a new privacy configuration for the control center module to define and manage a permission blacklist setting with proper visibility and localization.
New Features:
Enhancements: