fix

Author: skwowet

services/apps/cache_worker/src/activities.ts

@@ -1,7 +1,7 @@
 import {
   checkOrganizationExists,
   dropOrgIdFromRedis,
-  getOrgIdsFromRedis,
+  getOrganizationIdsFromRedis,
   syncOrganization,
 } from './activities/computeAggs/organization'
 import {
@@ -44,7 +44,7 @@ export {
   getActivePlatforms,
   findNewActivityPlatforms,
   updateMemberMergeSuggestionsLastGeneratedAt,
-  getOrgIdsFromRedis,
+  getOrganizationIdsFromRedis,
   dropOrgIdFromRedis,
   checkOrganizationExists,
   syncOrganization,

services/apps/cache_worker/src/activities/computeAggs/organization.ts

@@ -9,11 +9,10 @@ interface IScanResult {
   totalSize: number
 }
 
-export async function getOrgIdsFromRedis(batchSize = 100): Promise<IScanResult> {
-  let organizationIds: string[] = []
+export async function getOrganizationIdsFromRedis(batchSize = 100): Promise<IScanResult> {
   try {
     const totalSize = await svc.redis.sCard('organizationIdsForAggComputation')
-    organizationIds = await svc.redis.sendCommand([
+    const organizationIds = await svc.redis.sendCommand<string[]>([
       'SRANDMEMBER',
       'organizationIdsForAggComputation',
       batchSize.toString(),

services/apps/cache_worker/src/workflows/compute-orgs-agg/getAndComputeOrgAggs.ts

@@ -21,17 +21,15 @@ dailyGetAndComputeOrgAggs is a Temporal workflow that:
     cancelled if the parent workflow stops.
 */
 export async function dailyGetAndComputeOrgAggs(): Promise<void> {
-  const testRun = true
-  const { organizationIds, totalSize } = await activity.getOrgIdsFromRedis()
+  const { organizationIds, totalSize } = await activity.getOrganizationIdsFromRedis()
 
-  console.log('organizationIds', organizationIds)
-  console.log('totalSize', totalSize)
-
-  if (organizationIds.length === 0) {
-    console.log('No more organizations to process!')
+  if (!totalSize) {
+    console.log('No organizations found - finishing workflow!')
     return
   }
 
+  console.log(`Found ${totalSize} organizations for aggs computation!`)
+
   const info = workflowInfo()
 
   await Promise.all(
@@ -52,7 +50,5 @@ export async function dailyGetAndComputeOrgAggs(): Promise<void> {
   )
 
   // Continue with the next batch
-  if (!testRun) {
-    await continueAsNew<typeof dailyGetAndComputeOrgAggs>()
-  }
+  await continueAsNew<typeof dailyGetAndComputeOrgAggs>()
 }