Fix issues with merge suggestions (#2909)

Co-authored-by: Yeganathan S <hilariousengineer@protonmail.com>

Author: joanagmaia

services/apps/merge_suggestions_worker/src/activities/memberMergeSuggestions.ts

@@ -286,6 +286,7 @@ export async function getMembers(
         MemberField.DISPLAY_NAME,
         MemberField.ATTRIBUTES,
       ],
+      orderBy: `${MemberField.ID} asc`,
       limit: batchSize,
     })
 

services/apps/merge_suggestions_worker/src/memberSimilarityCalculator.ts

@@ -46,13 +46,6 @@ class MemberSimilarityCalculator {
       return 0.2
     }
 
-    // check displayName match
-    if (
-      similarMember.keyword_displayName.toLowerCase() === primaryMember.displayName.toLowerCase()
-    ) {
-      return this.decideMemberSimilarityUsingAdditionalChecks(primaryMember, similarMember)
-    }
-
     // We check if there are any verified<->unverified email matches between primary & similar members
     if (
       (similarMemberUnverifiedEmails &&
@@ -114,6 +107,13 @@ class MemberSimilarityCalculator {
       }
     }
 
+    // check displayName match
+    if (
+      similarMember.keyword_displayName.toLowerCase() === primaryMember.displayName.toLowerCase()
+    ) {
+      return this.decideMemberSimilarityUsingAdditionalChecks(primaryMember, similarMember)
+    }
+
     // calculate similarity percentage
     const identityLength = similarPrimaryIdentity?.value.length || 0