Trigger merge suggestions on profile updates (#2953)

Author: skwowet

backend/src/services/member/memberIdentityService.ts

@@ -9,6 +9,7 @@ import {
   deleteMemberIdentity,
   fetchMemberIdentities,
   findMemberIdentityById,
+  touchMemberUpdatedAt,
   updateMemberIdentity,
 } from '@crowd/data-access-layer/src/members'
 import { LoggerBase } from '@crowd/logging'
@@ -73,6 +74,8 @@ export default class MemberIdentityService extends LoggerBase {
           // Create member identity
           await createMemberIdentity(qx, tenantId, memberId, data)
 
+          await touchMemberUpdatedAt(qx, memberId)
+
           // List all member identities
           const list = await fetchMemberIdentities(qx, memberId)
 
@@ -149,6 +152,8 @@ export default class MemberIdentityService extends LoggerBase {
             await createMemberIdentity(qx, tenantId, memberId, identity)
           }
 
+          await touchMemberUpdatedAt(qx, memberId)
+
           // List all member identities
           const list = await fetchMemberIdentities(qx, memberId)
 
@@ -212,6 +217,8 @@ export default class MemberIdentityService extends LoggerBase {
           // Update member identity with new data
           await updateMemberIdentity(qx, memberId, id, data)
 
+          await touchMemberUpdatedAt(qx, memberId)
+
           // List all member identities
           const list = await fetchMemberIdentities(qx, memberId)
 
@@ -248,6 +255,8 @@ export default class MemberIdentityService extends LoggerBase {
       // Delete member identity
       await deleteMemberIdentity(qx, memberId, id)
 
+      await touchMemberUpdatedAt(qx, memberId)
+
       // List all member identities
       const list = await fetchMemberIdentities(qx, memberId)
 

services/apps/merge_suggestions_worker/src/activities/memberMergeSuggestions.ts

@@ -277,7 +277,8 @@ export async function getMembers(
         and: [
           { [MemberField.TENANT_ID]: { eq: tenantId } },
           afterMemberId ? { [MemberField.ID]: { gt: afterMemberId } } : null,
-          lastGeneratedAt ? { [MemberField.CREATED_AT]: { gt: lastGeneratedAt } } : null,
+          // Include members updated after the last generation to cover both new and modified ones
+          lastGeneratedAt ? { [MemberField.UPDATED_AT]: { gt: lastGeneratedAt } } : null,
         ],
       },
       fields: [

services/apps/merge_suggestions_worker/src/activities/organizationMergeSuggestions.ts

@@ -35,7 +35,8 @@ export async function getOrganizations(
         and: [
           { [OrganizationField.TENANT_ID]: { eq: tenantId } },
           afterOrganizationId ? { [OrganizationField.ID]: { gt: afterOrganizationId } } : null,
-          lastGeneratedAt ? { [OrganizationField.CREATED_AT]: { gt: lastGeneratedAt } } : null,
+          // Include organizations updated after the last generation to cover both new and modified ones
+          lastGeneratedAt ? { [OrganizationField.UPDATED_AT]: { gt: lastGeneratedAt } } : null,
           organizationIds ? { [OrganizationField.ID]: { in: organizationIds } } : null,
           // TODO filter by organizationIds,
         ],
@@ -47,6 +48,7 @@ export async function getOrganizations(
         OrganizationField.LOCATION,
         OrganizationField.INDUSTRY,
       ],
+      orderBy: `${OrganizationField.ID} asc`,
       limit: batchSize,
     })
 

services/libs/data-access-layer/src/members/others.ts

@@ -78,3 +78,7 @@ export async function updateMemberReach(
     },
   )
 }
+
+export async function touchMemberUpdatedAt(qx: QueryExecutor, memberId: string): Promise<void> {
+  return qx.result(`UPDATE members SET updatedAt = NOW() WHERE id = $(memberId)`, { memberId })
+}