yfquotes@thegli: Auto-refresh expired authentication parameters (#1319)

- Detect and replace expired authorization parameters
- Correct documentation for automatic refresh after import
- Update DOW 30 component symbols

Author: thegli

yfquotes@thegli/CHANGELOG.md

@@ -1,3 +1,16 @@
+### 0.15.2 - November 20, 2024
+
+Features:
+
+- update Hungarian translation (courtesy of [bossbob88](https://github.com/bossbob88))
+- update Finnish translation (courtesy of [MahtiAnkka](https://github.com/MahtiAnkka))
+
+Bugfixes:
+
+- correct documentation for automatic refresh after import
+- detect and replace expired authorization parameters
+- update DOW 30 component symbols
+
 ### 0.15.1 - September 12, 2024
 
 Features:

yfquotes@thegli/README.md

@@ -23,7 +23,7 @@ Either follow the installation instructions on [Cinnamon spices](https://cinnamo
 
 Check out the desklet configuration settings, and choose the data refresh period, the list of quotes to show, and quote details to display. The default list contains the Dow 30 companies.
 
-> Note that **any changes in the quotes list are not applied immediately** (anymore). This is true for manual changes as well as for import settings from a file.  
+> Note that **manual changes in the quotes list are not immediately applied** (anymore).  
 Press the "Refresh quotes data" button to execute an immediate data update, or wait until the next automatic refresh is triggered (depending on the configured interval).
 
 ### Individual Quote Design

yfquotes@thegli/files/yfquotes@thegli/desklet.js

@@ -183,6 +183,18 @@ YahooFinanceQuoteUtils.prototype = {
         return false;
     },
 
+    isUnauthorizedStatus: function(soupMessage) {
+        if (soupMessage) {
+            if (IS_SOUP_2) {
+                return soupMessage.status_code === Soup.KnownStatusCode.UNAUTHORIZED;
+            } else {
+                // get_status() throws exception on any value missing in enum SoupStatus, so better check reason_phrase
+                return soupMessage.get_reason_phrase() === "Unauthorized";
+            }
+        }
+        return false;
+    },
+
     getMessageStatusInfo: function(soupMessage) {
         if (soupMessage) {
             if (IS_SOUP_2) {
@@ -432,6 +444,10 @@ YahooFinanceQuoteReader.prototype = {
                     } catch (e) {
                         logError(e);
                     }
+                } else if (_that.quoteUtils.isUnauthorizedStatus(message)) {
+                    logDebug("Current authorization parameters have expired. Discarding them.");
+                    _crumb = null;
+                    callback.call(_that, _that.buildErrorResponse(_("Authorization parameters have expired")), true);
                 } else {
                     logWarning("Error retrieving url " + requestUrl + ". Status: " + _that.quoteUtils.getMessageStatusInfo(message));
                     callback.call(_that, _that.buildErrorResponse(_("Yahoo Finance service not available!\\nStatus: ") + _that.quoteUtils.getMessageStatusInfo(message)));
@@ -451,6 +467,10 @@ YahooFinanceQuoteReader.prototype = {
                     } catch (e) {
                         logError(e);
                     }
+                } else if (_that.quoteUtils.isUnauthorizedStatus(message)) {
+                    logDebug("Current authorization parameters have expired. Discarding them.");
+                    _crumb = null;
+                    callback.call(_that, _that.buildErrorResponse(_("Authorization parameters have expired")), true);
                 } else {
                     logWarning("Error retrieving url " + requestUrl + ". Status: " + _that.quoteUtils.getMessageStatusInfo(message));
                     callback.call(_that, _that.buildErrorResponse(_("Yahoo Finance service not available!\\nStatus: ") + _that.quoteUtils.getMessageStatusInfo(message)));
@@ -922,7 +942,7 @@ StockQuoteDesklet.prototype = {
         logDebug("fetchFinanceDataAndRender. quotes=" + quoteSymbolsArg + ", custom User-Agent: " + customUserAgent);
         const _that = this;
 
-        this.quoteReader.getFinanceData(quoteSymbolsArg, customUserAgent, function(response) {
+        this.quoteReader.getFinanceData(quoteSymbolsArg, customUserAgent, function(response, instantTimer = false) {
             logDebug("YF query response: " + response);
             let parsedResponse = JSON.parse(response);
             _lastResponses.set(_that.id, {
@@ -931,7 +951,7 @@ StockQuoteDesklet.prototype = {
                 responseError: parsedResponse.quoteResponse.error,
                 lastUpdated: new Date()
             });
-            _that.setUpdateTimer();
+            _that.setUpdateTimer(instantTimer);
             _that.render();
         });
     },
@@ -1032,10 +1052,15 @@ StockQuoteDesklet.prototype = {
         this.render();
     },
 
-    setUpdateTimer: function() {
+    setUpdateTimer: function(instantTimer = false) {
         logDebug("setUpdateTimer");
         if (this.updateInProgress) {
-            this.updateId = Mainloop.timeout_add(this.delayMinutes * 60000, Lang.bind(this, this.onQuotesListChanged));
+            let delaySeconds = this.delayMinutes * 60;
+            if (instantTimer) {
+                logDebug("add instant timer");
+                delaySeconds = 1;
+            }
+            this.updateId = Mainloop.timeout_add_seconds(delaySeconds, Lang.bind(this, this.onQuotesListChanged));
             logDebug("new updateId " + this.updateId);
             this.updateInProgress = false;
         }

yfquotes@thegli/files/yfquotes@thegli/metadata.json

@@ -3,6 +3,6 @@
     "name": "Yahoo Finance Quotes",
     "prevent-decorations": true,
     "max-instances": "10",
-    "version": "0.15.1",
+    "version": "0.15.2",
     "uuid": "yfquotes@thegli"
 }

yfquotes@thegli/files/yfquotes@thegli/po/ca.po

@@ -8,7 +8,7 @@ msgstr ""
 "Project-Id-Version: yfquotes@thegli 0.13.0\n"
 "Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-desklets/"
 "issues\n"
-"POT-Creation-Date: 2024-09-12 23:49+0200\n"
+"POT-Creation-Date: 2024-11-20 20:33+0100\n"
 "PO-Revision-Date: 2024-09-10 20:15+0200\n"
 "Last-Translator: Odyssey <[email protected]>\n"
 "Language-Team: \n"
@@ -22,46 +22,50 @@ msgstr ""
 msgid "No quotes data to display"
 msgstr "No hi ha dades de cotitzacions per mostrar"
 
-#. desklet.js:415
+#. desklet.js:427
 msgid "Empty quotes list. Open settings and add some symbols."
 msgstr ""
 "Llista de cotitzacions buida. Obriu la configuració i afegiu-hi alguns "
 "símbols."
 
-#. desklet.js:437 desklet.js:456
+#. desklet.js:450 desklet.js:473
+msgid "Authorization parameters have expired"
+msgstr ""
+
+#. desklet.js:453 desklet.js:476
 msgid "Yahoo Finance service not available!\\nStatus: "
 msgstr "El servei de Yahoo finances no està disponible!\\nEstat: "
 
-#. desklet.js:815
+#. desklet.js:835
 msgid "Updated at "
 msgstr "Actualitzat a les "
 
-#. desklet.js:848
+#. desklet.js:868
 msgid "Error: "
 msgstr "Error: "
 
-#. desklet.js:963
+#. desklet.js:983
 msgid ""
 "Failed to retrieve authorization parameter! Unable to fetch quotes data."
 "\\nStatus: "
 msgstr ""
 "Error en recuperar el paràmetre d'autorització. No s'han pogut obtenir les "
 "dades de les cotitzacions.\\nEstat: "
 
-#. desklet.js:989
+#. desklet.js:1009
 msgid "Consent processing failed! Unable to fetch quotes data.\\nStatus: "
 msgstr ""
 "No s'ha pogut processar el consentiment! No s'han pogut obtenir les dades de "
 "les cotitzacions.\\nEstat: "
 
-#. desklet.js:994
+#. desklet.js:1014
 msgid ""
 "Consent processing not completed! Unable to fetch quotes data.\\nStatus: "
 msgstr ""
 "No s'ha completat el processament del consentiment. No s'han pogut obtenir "
 "les dades de les cotitzacions.\\nEstat: "
 
-#. desklet.js:1017
+#. desklet.js:1037
 msgid ""
 "Failed to retrieve authorization crumb! Unable to fetch quotes data."
 "\\nStatus: "

yfquotes@thegli/files/yfquotes@thegli/po/da.po

@@ -7,7 +7,7 @@ msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-desklets/"
 "issues\n"
-"POT-Creation-Date: 2024-09-12 23:49+0200\n"
+"POT-Creation-Date: 2024-11-20 20:33+0100\n"
 "PO-Revision-Date: 2023-12-08 08:06+0100\n"
 "Last-Translator: Alan Mortensen <[email protected]>\n"
 "Language-Team: \n"
@@ -22,41 +22,45 @@ msgstr ""
 msgid "No quotes data to display"
 msgstr ""
 
-#. desklet.js:415
+#. desklet.js:427
 msgid "Empty quotes list. Open settings and add some symbols."
 msgstr ""
 
-#. desklet.js:437 desklet.js:456
+#. desklet.js:450 desklet.js:473
+msgid "Authorization parameters have expired"
+msgstr ""
+
+#. desklet.js:453 desklet.js:476
 msgid "Yahoo Finance service not available!\\nStatus: "
 msgstr "Yahoo Finance er ikke tilgængelig!\\nStatus: "
 
-#. desklet.js:815
+#. desklet.js:835
 msgid "Updated at "
 msgstr "Opdateret "
 
-#. desklet.js:848
+#. desklet.js:868
 msgid "Error: "
 msgstr "Fejl: "
 
-#. desklet.js:963
+#. desklet.js:983
 msgid ""
 "Failed to retrieve authorization parameter! Unable to fetch quotes data."
 "\\nStatus: "
 msgstr ""
 "Kunne ikke hente godkendelsesparameter! Kunne ikke hente kursdata.\n"
 "Status: "
 
-#. desklet.js:989
+#. desklet.js:1009
 msgid "Consent processing failed! Unable to fetch quotes data.\\nStatus: "
 msgstr "Samtykkebehandling mislykkedes! Kunne ikke hente kursdata.\\nStatus: "
 
-#. desklet.js:994
+#. desklet.js:1014
 msgid ""
 "Consent processing not completed! Unable to fetch quotes data.\\nStatus: "
 msgstr ""
 "Samtykkebehandling ikke gennemført! Kunne ikke hente kursdata.\\nStatus: "
 
-#. desklet.js:1017
+#. desklet.js:1037
 msgid ""
 "Failed to retrieve authorization crumb! Unable to fetch quotes data."
 "\\nStatus: "

yfquotes@thegli/files/yfquotes@thegli/po/de.po

@@ -7,7 +7,7 @@ msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-desklets/"
 "issues\n"
-"POT-Creation-Date: 2024-09-12 23:49+0200\n"
+"POT-Creation-Date: 2024-11-20 20:33+0100\n"
 "PO-Revision-Date: 2023-08-28 16:36+0200\n"
 "Last-Translator: \n"
 "Language-Team: \n"
@@ -21,45 +21,49 @@ msgstr ""
 msgid "No quotes data to display"
 msgstr "Keine Finanzdaten vorhanden"
 
-#. desklet.js:415
+#. desklet.js:427
 msgid "Empty quotes list. Open settings and add some symbols."
 msgstr ""
 "Liste der Symbole ist leer. Öffne die Einstellungen und füge Symbole hinzu."
 
-#. desklet.js:437 desklet.js:456
+#. desklet.js:450 desklet.js:473
+msgid "Authorization parameters have expired"
+msgstr "Autorisierungsparameter sind abgelaufen"
+
+#. desklet.js:453 desklet.js:476
 msgid "Yahoo Finance service not available!\\nStatus: "
 msgstr "Yahoo Finance Service nicht verfügbar!\\nStatus: "
 
-#. desklet.js:815
+#. desklet.js:835
 msgid "Updated at "
 msgstr "Aktualisiert um "
 
-#. desklet.js:848
+#. desklet.js:868
 msgid "Error: "
 msgstr "Fehler: "
 
-#. desklet.js:963
+#. desklet.js:983
 msgid ""
 "Failed to retrieve authorization parameter! Unable to fetch quotes data."
 "\\nStatus: "
 msgstr ""
 "Empfang von Autorisierungsparameter ist fehlgeschlagen! Finanzdaten-Abfrage "
 "nicht möglich.\\nStatus: "
 
-#. desklet.js:989
+#. desklet.js:1009
 msgid "Consent processing failed! Unable to fetch quotes data.\\nStatus: "
 msgstr ""
 "Consent-Erteilung ist fehlgeschlagen! Finanzdaten-Abfrage nicht möglich."
 "\\nStatus: "
 
-#. desklet.js:994
+#. desklet.js:1014
 msgid ""
 "Consent processing not completed! Unable to fetch quotes data.\\nStatus: "
 msgstr ""
 "Consent-Erteilung nicht abgeschlossen! Finanzdaten-Abfrage nicht möglich."
 "\\nStatus: "
 
-#. desklet.js:1017
+#. desklet.js:1037
 msgid ""
 "Failed to retrieve authorization crumb! Unable to fetch quotes data."
 "\\nStatus: "

yfquotes@thegli/files/yfquotes@thegli/po/es.po

@@ -7,7 +7,7 @@ msgstr ""
 "Project-Id-Version: \n"
 "Report-Msgid-Bugs-To: https://github.com/linuxmint/cinnamon-spices-desklets/"
 "issues\n"
-"POT-Creation-Date: 2024-09-12 23:49+0200\n"
+"POT-Creation-Date: 2024-11-20 20:33+0100\n"
 "PO-Revision-Date: 2024-09-03 10:48-0400\n"
 "Last-Translator: \n"
 "Language-Team: \n"
@@ -21,45 +21,49 @@ msgstr ""
 msgid "No quotes data to display"
 msgstr "No hay datos de cotizaciones para mostrar"
 
-#. desklet.js:415
+#. desklet.js:427
 msgid "Empty quotes list. Open settings and add some symbols."
 msgstr ""
 "Lista de cotizaciones vacía. Abra la configuración y añada algunos símbolos."
 
-#. desklet.js:437 desklet.js:456
+#. desklet.js:450 desklet.js:473
+msgid "Authorization parameters have expired"
+msgstr ""
+
+#. desklet.js:453 desklet.js:476
 msgid "Yahoo Finance service not available!\\nStatus: "
 msgstr "El servicio de Yahoo Finanzas no está disponible: "
 
-#. desklet.js:815
+#. desklet.js:835
 msgid "Updated at "
 msgstr "Actualizado en "
 
-#. desklet.js:848
+#. desklet.js:868
 msgid "Error: "
 msgstr "Error: "
 
-#. desklet.js:963
+#. desklet.js:983
 msgid ""
 "Failed to retrieve authorization parameter! Unable to fetch quotes data."
 "\\nStatus: "
 msgstr ""
 "Error al recuperar el parámetro de autorización. No se han podido recuperar "
 "los datos de las cotizaciones: "
 
-#. desklet.js:989
+#. desklet.js:1009
 msgid "Consent processing failed! Unable to fetch quotes data.\\nStatus: "
 msgstr ""
 "No se ha podido procesar el consentimiento. No se han podido recuperar los "
 "datos de las cotizaciones: "
 
-#. desklet.js:994
+#. desklet.js:1014
 msgid ""
 "Consent processing not completed! Unable to fetch quotes data.\\nStatus: "
 msgstr ""
 "No se ha completado el procesamiento del consentimiento. No se han podido "
 "recuperar los datos de las cotizaciones: "
 
-#. desklet.js:1017
+#. desklet.js:1037
 msgid ""
 "Failed to retrieve authorization crumb! Unable to fetch quotes data."
 "\\nStatus: "