gTile@shuairan : keyboard support for multi monitor grid

[ChrisCheney]

 * Extension version/Build date : 1.0.0
 * Cinnamon version : 3.8.9
 * Distribution - Mint 19
 * Graphics hardware : Intel modesetting

Notify author of extension

@shuairan

Issue

I have 3 monitors, and when trying to move windows with gTile on a multi monitor setup it appears it can only set the grid range on the primary monitor even if meta-g is hit while on a secondary screen.

It appears the only thing that currently works for multi monitor is the auto tile feature.

Steps to reproduce

1. Hit meta-g
2. Notice it comes up on all screens.
3. Notice it only makes grid adjustments and moves the window to the primary screen.

Expected behaviour

Be able to make grid adjustments on non-primary screens.

[ChrisCheney]

I just tested gTile under Gnome 3, which the Cinnamon version is forked from, and it works properly as expected above so it is likely something minor keeping it from working on the Cinnamon version.

[jaszhix]

This is currently unmaintained. I fixed it up so it would load without errors, but there are still a number of code quality issues affecting it.

I would be wary of calling multi-monitor bugs minor, needles are minor, until they're in a haystack.

[jaszhix]

Gave this a quick test - not reproducing any issues on my tri-monitor setup. Its supposed to appear on all three screens, the monitor you make the grid adjustment on is the one where it is tiled. Are you seeing something different?

Also from the issue template

 * Snippet or attachment of ~/.xsession-errors

[ChrisCheney]

Based on what you have said it appears the issue is that when I activate gTile and then use the arrows to try to configure the size they automatically appear on the primary monitor instead of the monitor I am using. I'm not sure why that is happening.

`
$ cat xsession-errors.txt
dbus-update-activation-environment: setting DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/bus
dbus-update-activation-environment: setting DISPLAY=:0
dbus-update-activation-environment: setting XAUTHORITY=/home/ccheney/.Xauthority
dbus-update-activation-environment: setting GTK_MODULES=gail:atk-bridge
dbus-update-activation-environment: setting QT_ACCESSIBILITY=1
dbus-update-activation-environment: setting CCACHE_COMPRESS=1
dbus-update-activation-environment: setting LANG=en_US.UTF-8
dbus-update-activation-environment: setting GDM_LANG=en_US
dbus-update-activation-environment: setting DISPLAY=:0
dbus-update-activation-environment: setting MANDATORY_PATH=/usr/share/gconf/cinnamon.mandatory.path
dbus-update-activation-environment: setting XDG_GREETER_DATA_DIR=/var/lib/lightdm-data/ccheney
dbus-update-activation-environment: setting USER=ccheney
dbus-update-activation-environment: setting DESKTOP_SESSION=cinnamon
dbus-update-activation-environment: setting DEFAULTS_PATH=/usr/share/gconf/cinnamon.default.path
dbus-update-activation-environment: setting PWD=/home/ccheney
dbus-update-activation-environment: setting HOME=/home/ccheney
dbus-update-activation-environment: setting QT_ACCESSIBILITY=1
dbus-update-activation-environment: setting CCACHE_DIR=/home/ccheney/work/ccache
dbus-update-activation-environment: setting XDG_SESSION_TYPE=x11
dbus-update-activation-environment: setting XDG_DATA_DIRS=/usr/share/cinnamon:/usr/share/gnome:/home/ccheney/.local/share/flatpak/exports/share:/var/lib/flatpak/exports/share:/usr/local/share:/usr/share:/var/lib/snapd/desktop
dbus-update-activation-environment: setting USE_CCACHE=1
dbus-update-activation-environment: setting XDG_SESSION_DESKTOP=cinnamon
dbus-update-activation-environment: setting GTK_MODULES=gail:atk-bridge
dbus-update-activation-environment: setting SHELL=/bin/bash
dbus-update-activation-environment: setting XDG_SEAT_PATH=/org/freedesktop/DisplayManager/Seat0
dbus-update-activation-environment: setting IM_CONFIG_PHASE=1
dbus-update-activation-environment: setting GPG_AGENT_INFO=/run/user/1000/gnupg/S.gpg-agent:0:1
dbus-update-activation-environment: setting SHLVL=1
dbus-update-activation-environment: setting LANGUAGE=en_US
dbus-update-activation-environment: setting GDMSESSION=cinnamon
dbus-update-activation-environment: setting LOGNAME=ccheney
dbus-update-activation-environment: setting DBUS_SESSION_BUS_ADDRESS=unix:path=/run/user/1000/bus
dbus-update-activation-environment: setting XDG_RUNTIME_DIR=/run/user/1000
dbus-update-activation-environment: setting XAUTHORITY=/home/ccheney/.Xauthority
dbus-update-activation-environment: setting XDG_SESSION_PATH=/org/freedesktop/DisplayManager/Session3
dbus-update-activation-environment: setting XDG_CONFIG_DIRS=/etc/xdg/xdg-cinnamon:/etc/xdg
dbus-update-activation-environment: setting PATH=/home/ccheney/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin
dbus-update-activation-environment: setting _=/usr/bin/dbus-update-activation-environment
[cinnamon-settings-daemon-smartcard] Failed to start: no suitable smartcard driver could be found

(csd-color:4949): color-plugin-WARNING **: 22:53:34.000: could not find device: property match 'XRANDR_name'='HDMI-2' does not exist

(csd-color:4949): color-plugin-WARNING **: 22:53:34.005: could not find device: property match 'XRANDR_name'='HDMI-2' does not exist

(csd-color:4949): color-plugin-WARNING **: 22:53:34.005: could not find device: property match 'XRANDR_name'='HDMI-2' does not exist
[cinnamon-settings-daemon-smartcard] Failed to start: no suitable smartcard driver could be found

(csd-color:4949): color-plugin-WARNING **: 22:53:34.012: could not find device: property match 'XRANDR_name'='HDMI-2' does not exist

(nm-applet:5082): Gtk-WARNING **: 22:53:35.074: Can't set a parent on widget which has a parent
Cjs-Message: 22:53:35.093: JS LOG: About to start Cinnamon
Cjs-Message: 22:53:35.137: JS LOG: [LookingGlass/info] Cinnamon.AppSystem.get_default() started in 42 ms
Cjs-Message: 22:53:35.142: JS LOG: [LookingGlass/info] loading user theme: /usr/share/themes/Linux Mint/cinnamon/cinnamon.css
Cjs-Message: 22:53:35.154: JS LOG: [LookingGlass/info] added icon directory: /usr/share/themes/Linux Mint/cinnamon
** Message: 22:53:35.154: nemo-desktop: session is cinnamon, establishing proxy
Cjs-Message: 22:53:35.237: JS LOG: [LookingGlass/info] PlacesManager: Updating devices
St-Message: 22:53:35.240: cogl npot texture sizes SUPPORTED
Cjs-Message: 22:53:35.247: JS LOG: [LookingGlass/info] loaded at Sun Nov 18 2018 22:53:35 GMT-0600 (CST)
Cjs-Message: 22:53:35.247: JS LOG: Cinnamon started at Sun Nov 18 2018 22:53:35 GMT-0600 (CST)
Cjs-Message: 22:53:35.277: JS LOG: [LookingGlass/info] SearchProviderManager started in 0 ms
openGL version 4.5 detected (GL3 Cogl Driver)
MetaSyncRing disabled: couldn't find required GL extensions, or the minimum safe openGL version was not met
Cjs-Message: 22:53:35.488: JS LOG: [LookingGlass/info] Loaded applet removable-drives@cinnamon.org in 68 ms
Cjs-Message: 22:53:35.504: JS LOG: [LookingGlass/info] Loaded applet show-desktop@cinnamon.org in 16 ms
Cjs-Message: 22:53:35.555: JS LOG: [LookingGlass/info] Loaded applet calendar@cinnamon.org in 50 ms
Cjs-Message: 22:53:35.599: JS LOG: [LookingGlass/info] Loaded applet user@cinnamon.org in 44 ms
Cjs-Message: 22:53:35.599: JS LOG: [LookingGlass/info] Loaded applet show-desktop@cinnamon.org in 0 ms
Cjs-Message: 22:53:35.599: JS LOG: [LookingGlass/info] Loaded applet user@cinnamon.org in 0 ms
Cjs-Message: 22:53:35.600: JS LOG: [LookingGlass/info] Loaded applet removable-drives@cinnamon.org in 2 ms
Cjs-Message: 22:53:35.600: JS LOG: [LookingGlass/info] Loaded applet calendar@cinnamon.org in 0 ms
Cjs-Message: 22:53:35.606: JS LOG: [LookingGlass/info] Loaded extension transparent-panels@germanfr in 6 ms
Cjs-Message: 22:53:35.613: JS LOG: [LookingGlass/info] Loaded applet systray@cinnamon.org in 6 ms
Cjs-Message: 22:53:35.655: JS LOG: [LookingGlass/info] Loaded applet keyboard@cinnamon.org in 42 ms
Cjs-Message: 22:53:35.659: JS WARNING: [/home/ccheney/.local/share/cinnamon/desklets/googleCalendar@javahelps.com/lib/xdate.js 13]: test for equality (==) mistyped as assignment (=)?

(cinnamon:5050): Cjs-WARNING **: 22:53:35.661: Some code accessed the property 'XDate' on the module 'utility'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.

(cinnamon:5050): Cjs-WARNING **: 22:53:35.661: Some code accessed the property 'SpawnReader' on the module 'utility'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.

(cinnamon:5050): Cjs-WARNING **: 22:53:35.661: Some code accessed the property 'CalendarUtility' on the module 'utility'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.
Cjs-Message: 22:53:35.674: JS LOG: [LookingGlass/info] Role locked: notifications
Cjs-Message: 22:53:35.680: JS LOG: [LookingGlass/info] Loaded applet notifications@cinnamon.org in 26 ms
Cjs-Message: 22:53:35.680: JS LOG: [LookingGlass/info] Loaded applet keyboard@cinnamon.org in 0 ms
Cjs-Message: 22:53:35.682: JS WARNING: [/usr/share/cinnamon/js/misc/fileUtils.js line 210 > Function 69]: reference to undefined property "eventsList"
Cjs-Message: 22:53:35.684: JS WARNING: [/home/ccheney/.local/share/cinnamon/desklets/googleCalendar@javahelps.com/lib/xdate.js 13]: reference to undefined property "-1"
Cjs-Message: 22:53:35.690: JS WARNING: [/home/ccheney/.local/share/cinnamon/desklets/googleCalendar@javahelps.com/lib/utility.js 50]: assignment to undeclared variable res
Cjs-Message: 22:53:35.697: JS LOG: [LookingGlass/info] Loaded desklet googleCalendar@javahelps.com in 16 ms
Cjs-Message: 22:53:35.723: JS LOG: [LookingGlass/info] Loaded applet power@cinnamon.org in 26 ms
Cjs-Message: 22:53:35.785: JS LOG: [LookingGlass/info] Role locked: panellauncher
Cjs-Message: 22:53:35.829: JS LOG: [LookingGlass/info] Loaded applet panel-launchers@cinnamon.org in 106 ms
Cjs-Message: 22:53:35.830: JS LOG: [LookingGlass/info] DeskletManager started in 554 ms
Cjs-Message: 22:53:35.831: JS LOG: [LookingGlass/info] Loaded applet panel-launchers@cinnamon.org in 0 ms
Cjs-Message: 22:53:35.874: JS LOG: [LookingGlass/info] Loaded applet weather@mockturtl in 44 ms
Cjs-Message: 22:53:35.909: JS LOG: [LookingGlass/info] Loaded extension gTile@shuairan in 34 ms
Cjs-Message: 22:53:35.909: JS LOG: [LookingGlass/info] Loaded applet weather@mockturtl in 0 ms
Cjs-Message: 22:53:35.909: JS LOG: [LookingGlass/info] ExtensionSystem started in 632 ms
Cjs-Message: 22:53:35.947: JS LOG: [LookingGlass/info] Loaded applet IcingTaskManager@json in 38 ms
Cjs-Message: 22:53:35.947: JS LOG: [LookingGlass/info] Loaded applet IcingTaskManager@json in 0 ms
Cjs-Message: 22:53:36.039: JS LOG: [LookingGlass/info] Loaded applet sound@cinnamon.org in 92 ms
Cjs-Message: 22:53:36.093: JS LOG: network applet: Cannot find connection for active (or connection cannot be read)
Cjs-Message: 22:53:36.095: JS LOG: [LookingGlass/info] Loaded applet network@cinnamon.org in 56 ms
Cjs-Message: 22:53:36.836: JS LOG: [LookingGlass/info] Loaded applet menu@cinnamon.org in 742 ms
Cjs-Message: 22:53:36.836: JS LOG: [LookingGlass/info] Loaded applet menu@cinnamon.org in 0 ms
Cjs-Message: 22:53:36.837: JS LOG: [LookingGlass/info] AppletManager started in 1588 ms
Cjs-Message: 22:53:36.839: JS LOG: [LookingGlass/info] Cinnamon took 1746 ms to start
Cjs-Message: 22:53:36.904: JS LOG: Invalid network device type, is 14
Cjs-Message: 22:53:36.904: JS LOG: network applet: Found connection for active
Cjs-Message: 22:53:37.128: JS LOG: [LookingGlass/info] Hiding systray: network
Cinnamon warning: Log level 16: STACK_OP_RAISE_ABOVE: sibling window 0x440001c not in stack
Cjs-Message: 22:53:40.644: JS LOG: [LookingGlass/info] Adding systray: blueberry-tray.py (24x24px)
Cjs-Message: 22:53:55.868: JS LOG: [LookingGlass/info] Adding systray: mintupdate.py (24x24px)
`

[ChrisCheney]

Here is a video showing the issue. Hopefully its clear enough. I scaled it down since the original size is 4320x3840

https://youtu.be/AIeLA21EDUY

It works correctly on the right (primary) monitor, but when moved to the left one it still does the grid for the right monitor anyway.

[jaszhix]

Ok, I was testing with mouse gestures, but can reproduce it with arrow keys.

[tabcodes]

So this bug is old and cold, but after getting a decent widescreen monitor, it started to irk me- so I took a stab at fixing it.

If there's some rule against self-promotion here I apologize, but I (may have) sort of succeeded- I forked shuairan's excellent work and made some tweaks to it. You can find my version here.

[jkirk]

I can confirm, this issue has been resolved with the latest update.