st: Print the js stack for a couple of critical warnings that

can be difficult to track down.

Author: mtwebster

src/st/meson.build

@@ -91,6 +91,7 @@ st_private_headers = [
     'croco/libcroco-config.h',
     'croco/libcroco.h',
     'st-background-effect.h',
+    'st-debug.h',
     'st-private.h',
     'st-table-private.h',
     'st-theme-private.h',
@@ -107,6 +108,7 @@ st_gir_sources = [
     'st-box-layout-child.c',
     'st-button.c',
     'st-clipboard.c',
+    'st-debug.c',
     'st-drawing-area.c',
     'st-entry.c',
     'st-focus-manager.c',
@@ -174,6 +176,7 @@ st_h = configure_file(
 )
 
 libst_deps = [
+    cjs,
     clutter,
     cogl,
     cogl_path,

src/st/st-debug.c

@@ -0,0 +1,15 @@
+/* -*- mode: C; c-file-style: "gnu"; indent-tabs-mode: nil; -*- */
+
+#include <cjs/gjs.h>
+
+
+/**
+ * st_debug_dump_js_stack:
+ *
+ * Prints out the gjs stack
+ */
+void
+st_dump_js_stack (void)
+{
+    gjs_dumpstack ();
+}

src/st/st-debug.h

@@ -0,0 +1,3 @@
+/* -*- mode: C; c-file-style: "gnu"; indent-tabs-mode: nil; -*- */
+
+void st_dump_js_stack (void);

src/st/st-label.c

@@ -40,6 +40,7 @@
 
 #include <clutter/clutter.h>
 
+#include "st-debug.h"
 #include "st-label.h"
 #include "st-private.h"
 #include "st-widget.h"
@@ -330,6 +331,7 @@ st_label_get_text (StLabel *label)
   if (ctext == NULL) {
     g_printerr ("Cinnamon WARNING: Possible orphan label being accessed via st_label_get_text().  Check your timers and handlers!\n"
                 "Address: %p\n", (void *) label);
+    st_dump_js_stack ();
     priv->orphan = TRUE;
     return NULL;
   }

src/st/st-widget.c

@@ -35,6 +35,7 @@
 #include "st-widget.h"
 
 #include "st-background-effect.h"
+#include "st-debug.h"
 #include "st-label.h"
 #include "st-private.h"
 #include "st-texture-cache.h"
@@ -583,6 +584,7 @@ st_widget_get_theme_node (StWidget *widget)
         {
           g_critical ("st_widget_get_theme_node called on the widget %s which is not in the stage.",
                     st_describe_actor (CLUTTER_ACTOR (widget)));
+          st_dump_js_stack ();
           return g_object_new (ST_TYPE_THEME_NODE, NULL);
         }