configure.ac: missing dep: libkeybinder3

[lots0logs]

Traceback (most recent call last):
  File "/usr/bin/cinnamon-killer-daemon", line 11, in <module>
    gi.require_version('Keybinder', '3.0')
  File "/usr/lib/python3.6/site-packages/gi/__init__.py", line 118, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace Keybinder not available

[leigh123linux]

Why is this needed in configure?, it's not a compile dep.
It's only a runtime dep.

[lots0logs]

Because if its not in configure file then it can go unnoticed by anyone who builds Cinnamon and more importantly, distro package maintainers.

[leigh123linux]

There as loads of undeclared python deps

https://github.com/linuxmint/Cinnamon/blob/master/debian/control#L89

And others like metacity, gnome-panel, tint2 and more.

Adding keybinder is totally pointless!!

You can't make stuff idiot proof, what are you going to add next? eg: make, gcc-c++

[lots0logs]

It's not pointless. You're right it's only one out of many that are missing but its a lot easier to add them as they are discovered and less time consuming than it is to go through and find all of them at once. Seems like you already know of several without even having to check, so why don't you submit a PR as well? Then we'd be even closer to solving the overall issue that is missing and undocumented deps for Cinnamon 😃

[leigh123linux]

As a distro package maintainer I know it is pointless to add crap to the buildroot that isn't required for the package to build.
I also know it's my duty as a distro package maintainer to check the package runs and add any missing runtime deps to the packaging.

[lots0logs]

Well as a distro package maintainer myself, I know that its a PIA to have to waste time trying to figure out dependencies for a program because the developers couldn't take a few minutes to clearly document them. Also, just because a program runs does not mean you've packaged it with all the necessary dependencies. Case in point being libkeybinder. Cinnamon will run just fine without it. That is until you try and use the kill cinnamon keyboard shortcut and it doesn't work.

[leigh123linux]

Ok, why don't you document them instead of saddling configure with unneeded deps?

[clefebvre]

Hi,

I agree with you both. These should be listed but they're not build deps. Maybe in README.md instead?

[lots0logs]

@clefebvre Something like this perhaps?

[icarter09]

@lots0logs can this issue be closed?

[Vahan86]

@icarter09, can we close this issue since there is no response from OP?