-
Notifications
You must be signed in to change notification settings - Fork 60
Add support for login-window-alignment/offset and logo-positioning + dev documentation #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… + dev documentation Keep old defaults Add settings-keys, config-schema-keys Add documentation of new config-keys to readme
thanks @rnbdsh, this is really cool, here's my review:
|
Waiting on this to get merged :) |
Hi, I think what @clefebvre mentioned above needs to be done here:
I'm not sure the default logo position is even worthwhile, it's pretty dumb half off the bottom of the screen. (At least that's where it ends up for me) - I'd be ok with doing away with it entirely, but other may not share that opinion. A couple of other things:
We always have to consider how to present these types of customizations to the user - we'd like to keep this accessible to all users, and it's far easier for everyone to understand simple alignments, and less likely to cause them issues - you prevent them from getting into trouble. The two respective (logo and main) settings could be strings like previously mentioned - 'upper-left', 'upper-right', etc...
Sorry for the length - we would like to see this get in. If you need any guidance or assistance don't hesitate to ask. Thanks |
The original post was from ~1 year ago, and I currently don't have time to get into GTK/vala again. I initially tried something like this 9-position variant but GtkAlignment didn't behave the way i expected, that's why I chose the X/Y method. |
I'm going to close this for now then. If there is additional interest down the road we can revisit. |
Not sure of the etiquette here as I'm new to github but I was trying to work out how to position the login window, because the default placement conflicts with features of the backgrounds I've chosen, and found this thread; just like to express my interest in this feature being made available. Thank you! |
Keep old defaults
Add settings-keys, config-schema-keys and documentation of new config-keys to readme
Add documentation on how to develop for this, as setting up automake-autogen-gnome-vala-make was 1/3 of the work for me. (Maybe move to different .md file?)
Should fix #92 and #105 + allow left-center-right alignment
REQUIRES SCHEMA RECOMPILE FOR TESTING (see README with improved dev tips)