Skip to content

Add support for login-window-alignment/offset and logo-positioning + dev documentation #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rnbwdsh
Copy link

@rnbwdsh rnbwdsh commented Feb 5, 2019

Keep old defaults
Add settings-keys, config-schema-keys and documentation of new config-keys to readme
Add documentation on how to develop for this, as setting up automake-autogen-gnome-vala-make was 1/3 of the work for me. (Maybe move to different .md file?)

Should fix #92 and #105 + allow left-center-right alignment
REQUIRES SCHEMA RECOMPILE FOR TESTING (see README with improved dev tips)

… + dev documentation

Keep old defaults
Add settings-keys, config-schema-keys
Add documentation of new config-keys to readme
@clefebvre
Copy link
Member

thanks @rnbdsh, this is really cool, here's my review:

  • The implementation is clean and it works very well.
  • We should also add support for the additional settings in lightdm-settings.
  • The position coordinates are hard to use and don't adapt well to different monitors. That makes it tedious for distributions to set defaults, and tedious also for users using monitors of different resolutions. I'd recommend using enums (i.e. "top-left, top-center, top-right, etc...") instead, and have the greeter calculate the appropriate coordinates based on that, on the resolution, on the presence of a panel, on the size of the logo etc etc..

@clefebvre clefebvre changed the title Adding support for login-window-alignment/offset and logo-positioning + dev documentation [Next] Adding support for login-window-alignment/offset and logo-positioning + dev documentation Jul 1, 2019
@clefebvre clefebvre changed the title [Next] Adding support for login-window-alignment/offset and logo-positioning + dev documentation Adding support for login-window-alignment/offset and logo-positioning + dev documentation Aug 19, 2019
@clefebvre clefebvre changed the title Adding support for login-window-alignment/offset and logo-positioning + dev documentation Add support for login-window-alignment/offset and logo-positioning + dev documentation Nov 22, 2019
@clefebvre clefebvre changed the title Add support for login-window-alignment/offset and logo-positioning + dev documentation [Next] Add support for login-window-alignment/offset and logo-positioning + dev documentation Nov 22, 2019
@codic12
Copy link

codic12 commented Dec 1, 2019

Waiting on this to get merged :)

@clefebvre clefebvre changed the title [Next] Add support for login-window-alignment/offset and logo-positioning + dev documentation Add support for login-window-alignment/offset and logo-positioning + dev documentation Jan 4, 2020
@mtwebster
Copy link
Member

Hi, I think what @clefebvre mentioned above needs to be done here:

  • Logo: upper-left, upper, upper-right, left, center, right, lower-left, lower, lower-right, maybe default
  • Main window alignment: I don't understand why there is an alignment setting as well as x and y positions, why not just have the same positioning method as for the logo - 9 positions

I'm not sure the default logo position is even worthwhile, it's pretty dumb half off the bottom of the screen. (At least that's where it ends up for me) - I'd be ok with doing away with it entirely, but other may not share that opinion.

A couple of other things:

  • There's nothing stopping you from positioning stuff entirely out of bounds of the monitor.
  • x and y are transposed in the main box offsets (you adjust the y and x moves)

We always have to consider how to present these types of customizations to the user - we'd like to keep this accessible to all users, and it's far easier for everyone to understand simple alignments, and less likely to cause them issues - you prevent them from getting into trouble.

The two respective (logo and main) settings could be strings like previously mentioned - 'upper-left', 'upper-right', etc...

  • The main window alignment, you should probably keep using the GtkAlignment positioning, since the absolute size of this may not be very well-defined - you could just use 0, .5, 1 for both directions.
  • The logo size you'd need to do some calculations based on the image and monitor size, but since both are well-defined, it wouldn't be complicated.

Sorry for the length - we would like to see this get in. If you need any guidance or assistance don't hesitate to ask.

Thanks

@rnbwdsh
Copy link
Author

rnbwdsh commented Jan 10, 2020

The original post was from ~1 year ago, and I currently don't have time to get into GTK/vala again.

I initially tried something like this 9-position variant but GtkAlignment didn't behave the way i expected, that's why I chose the X/Y method.

@mtwebster
Copy link
Member

I'm going to close this for now then. If there is additional interest down the road we can revisit.

@mtwebster mtwebster closed this Jan 13, 2020
@areographe
Copy link

Not sure of the etiquette here as I'm new to github but I was trying to work out how to position the login window, because the default placement conflicts with features of the backgrounds I've chosen, and found this thread; just like to express my interest in this feature being made available. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: custom login window position
5 participants