@@ -42,10 +42,12 @@ def test_translateSambaToIpp():
4242 assert printers .translateSambaToIpp ("\\ \\ \\ printer1" ) == (False , None )
4343
4444
45+ @mock .patch ("subprocess.run" )
4546@mock .patch ("subprocess.call" )
4647@mock .patch ("linuxmusterLinuxclient7.hooks.user.isRoot" )
4748@mock .patch ("linuxmusterLinuxclient7.hooks.user.username" )
48- def test_installPrinter (mockUserUsername , mockUserIsRoot , mockSubprocessCall ):
49+ def test_installPrinter (mockUserUsername , mockUserIsRoot , mockSubprocessCall , mockSubprocessRun ):
50+ mockSubprocessRun .return_value = CompletedProcess (args = ["lpstat" , "-l" , "-p" , "printer1" ], returncode = 1 )
4951 mockSubprocessCall .return_value = 0
5052 mockUserIsRoot .return_value = True
5153 mockUserUsername .return_value = "user1"
@@ -66,10 +68,12 @@ def test_installPrinter(mockUserUsername, mockUserIsRoot, mockSubprocessCall):
6668 assert printers .installPrinter ("ipp://linuxmuster.lan/printers/printer1" , "printer2" )
6769 assert _getCallsTo (mockSubprocessCall , "sudo" )[- 1 ] == ['sudo' , '/usr/share/linuxmuster-linuxclient7/scripts/sudoTools' , 'install-printer' , '--path' , 'ipp://linuxmuster.lan/printers/printer1' , '--name' , 'printer2' ]
6870
71+ @mock .patch ("subprocess.run" )
6972@mock .patch ("subprocess.call" )
7073@mock .patch ("linuxmusterLinuxclient7.hooks.user.isRoot" )
7174@mock .patch ("linuxmusterLinuxclient7.hooks.user.username" )
72- def test_installPrinterError (mockUserUsername , mockUserIsRoot , mockSubprocessCall ):
75+ def test_installPrinterError (mockUserUsername , mockUserIsRoot , mockSubprocessCall , mockSubprocessRun ):
76+ mockSubprocessRun .return_value = CompletedProcess (args = ["lpstat" , "-l" , "-p" , "printer1" ], returncode = 1 )
7377 mockSubprocessCall .return_value = 124
7478 mockUserIsRoot .return_value = True
7579 mockUserUsername .return_value = "user1"
@@ -90,7 +94,7 @@ def test_uninstallAllPrintersOfUser(mockSubprocessRun, mockSubprocessCall):
9094 mockSubprocessRun .return_value = CompletedProcess (args = ["lpstat" , "-U" , "user1" , "-p" ], returncode = 0 , stdout = lpstatStdout )
9195
9296 assert printers .uninstallAllPrintersOfUser ("user1" )
93- assert _getCallsTo ( mockSubprocessRun , "/usr/bin/lpstat" )[ - 1 ] == [ '/usr/bin/lpstat' , '-U' , 'user1' , '-p' ]
97+ assert [ '/usr/bin/lpstat' , '-U' , 'user1' , '-p' ] in _getCallsTo ( mockSubprocessRun , "/usr/bin/lpstat" )
9498 assert _getCallsTo (mockSubprocessCall , "timeout" ) == [["timeout" , "10" , "/usr/sbin/lpadmin" , "-x" , "printer1" ], ["timeout" , "10" , "/usr/sbin/lpadmin" , "-x" , "printer2" ]]
9599
96100 mockSubprocessRun .return_value = CompletedProcess (args = ["lpstat" , "-U" , "user1" , "-p" ], returncode = 1 )
@@ -109,6 +113,51 @@ def test_uninstallAllPrintersOfUserError(mockSubprocessRun, mockSubprocessCall):
109113 mockSubprocessRun .return_value = CompletedProcess (args = ["lpstat" , "-U" , "user1" , "-p" ], returncode = 0 , stdout = lpstatStdout )
110114 mockSubprocessCall .return_value = 124
111115 assert not printers .uninstallAllPrintersOfUser ("user1" )
116+
117+ @mock .patch ("subprocess.run" )
118+ def test_getAllowedUsersOfPrinter (mockSubprocessRun ):
119+ lpstatStdout = "printer printer1 is idle.\n \t Users allowed:\n \t \t user1\n \t \t user2\n \t Forms allowed:\n \t \t (none)\n "
120+ mockSubprocessRun .return_value = CompletedProcess (args = ["lpstat" , "-l" , "-p" , "printer1" ], returncode = 0 , stdout = lpstatStdout )
121+ assert printers ._getAllowedUsersOfPrinter ("printer1" ) == ["user1" , "user2" ]
122+ assert mockSubprocessRun .call_args .kwargs ["env" ]["LC_ALL" ] == "C"
123+
124+ lpstatStdout = "printer printer1 is idle.\n \t Users allowed:\n \t \t (all)\n \t Forms allowed:\n \t \t (none)\n "
125+ mockSubprocessRun .return_value = CompletedProcess (args = ["lpstat" , "-l" , "-p" , "printer1" ], returncode = 0 , stdout = lpstatStdout )
126+ assert printers ._getAllowedUsersOfPrinter ("printer1" ) == []
127+
128+ mockSubprocessRun .return_value = CompletedProcess (args = ["lpstat" , "-l" , "-p" , "printer1" ], returncode = 1 , stdout = "" )
129+ assert printers ._getAllowedUsersOfPrinter ("printer1" ) == []
130+
131+ @mock .patch ("subprocess.run" )
132+ @mock .patch ("subprocess.call" )
133+ @mock .patch ("linuxmusterLinuxclient7.hooks.user.isRoot" )
134+ def test_installPrinterKeepsAllowedUsers (mockUserIsRoot , mockSubprocessCall , mockSubprocessRun ):
135+ mockUserIsRoot .return_value = True
136+ mockSubprocessCall .return_value = 0
137+ lpstatStdout = "printer printer1 is idle.\n \t Users allowed:\n \t \t user1\n \t Forms allowed:\n \t \t (none)\n "
138+ mockSubprocessRun .return_value = CompletedProcess (args = ["lpstat" , "-l" , "-p" , "printer1" ], returncode = 0 , stdout = lpstatStdout )
139+
140+ assert printers .installPrinter ("ipp://linuxmuster.lan/printers/printer1" , "printer1" , "user2" )
141+ assert _getCallsTo (mockSubprocessCall , "timeout" )[- 1 ][- 2 :] == ["-u" , "allow:user1,user2" ]
142+
143+ assert printers .installPrinter ("ipp://linuxmuster.lan/printers/printer1" , "printer1" , "user1" )
144+ assert _getCallsTo (mockSubprocessCall , "timeout" )[- 1 ][- 2 :] == ["-u" , "allow:user1" ]
145+
146+ @mock .patch ("subprocess.call" )
147+ @mock .patch ("subprocess.run" )
148+ def test_uninstallAllPrintersOfUserKeepsPrinterForOtherUsers (mockSubprocessRun , mockSubprocessCall ):
149+ mockSubprocessCall .return_value = 0
150+ lpstatPrinters = CompletedProcess (args = ["lpstat" , "-U" , "user1" , "-p" ], returncode = 0 , stdout = "printer printer1 is idle. enabled since Sat 02 Jul 2022 06:07:39 PM CEST" )
151+ lpstatAllowedUsers = CompletedProcess (args = ["lpstat" , "-l" , "-p" , "printer1" ], returncode = 0 , stdout = "printer printer1 is idle.\n \t Users allowed:\n \t \t user1\n \t \t user2\n \t Forms allowed:\n \t \t (none)\n " )
152+ mockSubprocessRun .side_effect = [lpstatPrinters , lpstatAllowedUsers ]
153+
154+ assert printers .uninstallAllPrintersOfUser ("user1" )
155+ assert _getCallsTo (mockSubprocessCall , "timeout" ) == [["timeout" , "10" , "/usr/sbin/lpadmin" , "-p" , "printer1" , "-u" , "allow:user2" ]]
156+
157+ mockSubprocessCall .return_value = 1
158+ mockSubprocessRun .side_effect = [lpstatPrinters , lpstatAllowedUsers ]
159+ assert not printers .uninstallAllPrintersOfUser ("user1" )
160+
112161# --------------------
113162# - Helper functions -
114163# --------------------
0 commit comments