Skip to content

Commit 08f9075

Browse files
authored
Merge pull request #503 from flying-elephant/fix-bt-irq
HID: wacom: fix out-of-bounds read in wacom_intuos_bt_irq
2 parents 2b49066 + 09bc480 commit 08f9075

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

4.18/wacom_wac.c

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1224,10 +1224,20 @@ static int wacom_intuos_bt_irq(struct wacom_wac *wacom, size_t len)
12241224

12251225
switch (data[0]) {
12261226
case 0x04:
1227+
if (len < 32) {
1228+
dev_warn(wacom->pen_input->dev.parent,
1229+
"Report 0x04 too short: %zu bytes\n", len);
1230+
break;
1231+
}
12271232
wacom_intuos_bt_process_data(wacom, data + i);
12281233
i += 10;
12291234
fallthrough;
12301235
case 0x03:
1236+
if (i == 1 && len < 22) {
1237+
dev_warn(wacom->pen_input->dev.parent,
1238+
"Report 0x03 too short: %zu bytes\n", len);
1239+
break;
1240+
}
12311241
wacom_intuos_bt_process_data(wacom, data + i);
12321242
i += 10;
12331243
wacom_intuos_bt_process_data(wacom, data + i);

0 commit comments

Comments
 (0)