update README, group name and add test logging

Author: lion7

README.md

@@ -17,11 +17,11 @@ The default configuration of ExternalDNS needs altering for this integration to
 If you are deploying with the [official Helm chart](https://artifacthub.io/packages/helm/external-dns/external-dns) you can accomplish this by including this in your values file:
 
 ```yaml
-extraArgs: 
-  - --managed-record-types=A      # ┐
-  - --managed-record-types=AAAA   # ├ Default values
-  - --managed-record-types=CNAME  # ┘
-  - --managed-record-types=TXT    # ─ New value
+managedRecordTypes: 
+  - A      # ┐
+  - AAAA   # ├ Default values
+  - CNAME  # ┘
+  - TXT    # ─ New value
 
 sources:
   - service # ┬ Default values
@@ -35,7 +35,72 @@ Any supported version of cert-manager supports DNS webhooks, for documentation o
 
 ## Installing
 
-TODO
+### Using Helm
+
+The webhook can be installed using Helm:
+
+```bash
+# Add the repository
+helm repo add cert-manager-webhook-external-dns oci://ghcr.io/lion7/cert-manager-webhook-external-dns
+
+# Install the webhook
+helm install cert-manager-webhook-external-dns \
+  cert-manager-webhook-external-dns/cert-manager-webhook-external-dns \
+  --namespace cert-manager \
+  --create-namespace
+```
+
+### Using OCI Registry
+
+You can also install directly from the OCI registry:
+
+```bash
+helm install cert-manager-webhook-external-dns \
+  oci://ghcr.io/lion7/cert-manager-webhook-external-dns \
+  --namespace cert-manager \
+  --create-namespace
+```
+
+### Configuration
+
+The default values should work for most installations. You can customize the installation by creating a values file:
+
+```yaml
+# values.yaml
+image:
+  repository: ghcr.io/lion7/cert-manager-webhook-external-dns
+  tag: latest
+  pullPolicy: IfNotPresent
+
+replicaCount: 1
+
+resources:
+  limits:
+    cpu: 100m
+    memory: 128Mi
+  requests:
+    cpu: 100m
+    memory: 128Mi
+
+# Webhook configuration
+webhook:
+  port: 8443
+
+# cert-manager configuration
+certManager:
+  namespace: cert-manager
+  serviceAccountName: cert-manager
+```
+
+Then install with:
+
+```bash
+helm install cert-manager-webhook-external-dns \
+  oci://ghcr.io/lion7/cert-manager-webhook-external-dns \
+  --namespace cert-manager \
+  --create-namespace \
+  -f values.yaml
+```
 
 ## Usage
 
@@ -52,7 +117,7 @@ spec:
     solvers:
     - dns01:
         webhook:
-          groupName: external-dns.acme.cert-manager.io
+          groupName: cert-manager-webhook.lion7.dev
           solverName: external-dns
 ```
 

deploy/external-dns-webhook/values.yaml

@@ -8,7 +8,7 @@
 # The name will need to be referenced in each Issuer's `webhook` stanza to
 # inform cert-manager of where to send ChallengePayload resources in order to
 # solve the DNS01 challenge.
-groupName: external-dns.acme.cert-manager.io
+groupName: cert-manager-webhook.lion7.dev
 
 replicaCount: 1
 

main.go

@@ -30,7 +30,7 @@ var (
 
 	// GroupName is the Kubernetes group name that will be forwarded to this
 	// extension-apiserver.
-	GroupName = "external-dns.acme.cert-manager.io"
+	GroupName = "cert-manager-webhook.lion7.dev"
 
 	// RequestTimeout is the timeout for each request
 	RequestTimeout = time.Second * 5

testing/registry.go

@@ -3,6 +3,7 @@ package testing
 import (
 	"context"
 	"fmt"
+	"log"
 	"strings"
 	"sync"
 	"testing"
@@ -28,6 +29,8 @@ func NewTestRegistry(t *testing.T, addr string, domains ...string) *Registry {
 		records: make(map[endpoint.EndpointKey]*endpoint.Endpoint),
 	}
 
+	log.Printf("[TEST REGISTRY] Starting DNS server on %s for domains: %v", addr, domains)
+
 	server := &dns.Server{
 		Addr:    addr,
 		Net:     "udp",
@@ -39,6 +42,7 @@ func NewTestRegistry(t *testing.T, addr string, domains ...string) *Registry {
 	}()
 
 	t.Cleanup(func() {
+		log.Printf("[TEST REGISTRY] Shutting down DNS server")
 		_ = server.Shutdown()
 	})
 
@@ -54,22 +58,33 @@ func (r *Registry) Records(ctx context.Context) ([]*endpoint.Endpoint, error) {
 		records = append(records, record.DeepCopy())
 	}
 
+	log.Printf("[TEST REGISTRY] Records() returning %d records", len(records))
+	for _, record := range records {
+		log.Printf("[TEST REGISTRY]   - %s %s %v", record.DNSName, record.RecordType, record.Targets)
+	}
+
 	return records, nil
 }
 
 func (r *Registry) ApplyChanges(ctx context.Context, changes *plan.Changes) error {
 	r.mu.Lock()
 	defer r.mu.Unlock()
 
+	log.Printf("[TEST REGISTRY] ApplyChanges() - Create: %d, Update: %d, Delete: %d",
+		len(changes.Create), len(changes.UpdateNew), len(changes.Delete))
+
 	for _, change := range changes.Create {
+		log.Printf("[TEST REGISTRY]   CREATE: %s %s %v", change.DNSName, change.RecordType, change.Targets)
 		r.records[change.Key()] = change.DeepCopy()
 	}
 
 	for _, change := range changes.UpdateNew {
+		log.Printf("[TEST REGISTRY]   UPDATE: %s %s %v", change.DNSName, change.RecordType, change.Targets)
 		r.records[change.Key()] = change.DeepCopy()
 	}
 
 	for _, change := range changes.Delete {
+		log.Printf("[TEST REGISTRY]   DELETE: %s %s %v", change.DNSName, change.RecordType, change.Targets)
 		delete(r.records, change.Key())
 	}
 
@@ -103,9 +118,12 @@ func (r *Registry) handleDNSRequest(w dns.ResponseWriter, req *dns.Msg) {
 }
 
 func (r *Registry) addDNSAnswer(q dns.Question, msg *dns.Msg, req *dns.Msg) error {
+	log.Printf("[TEST REGISTRY] DNS Query: %s %s", q.Name, dns.TypeToString[q.Qtype])
+
 	switch q.Qtype {
 	// Always return loopback for any A query
 	case dns.TypeA:
+		log.Printf("[TEST REGISTRY]   A record query for %s, returning 127.0.0.1", q.Name)
 		rr, err := dns.NewRR(fmt.Sprintf("%s 5 IN A 127.0.0.1", q.Name))
 		if err != nil {
 			return err
@@ -121,8 +139,12 @@ func (r *Registry) addDNSAnswer(q dns.Question, msg *dns.Msg, req *dns.Msg) erro
 		}
 
 		found := false
+		queryName := strings.TrimSuffix(q.Name, ".")
+		log.Printf("[TEST REGISTRY]   TXT record query for %s", queryName)
+
 		for _, record := range records {
-			if record.DNSName == strings.TrimSuffix(q.Name, ".") && record.RecordType == endpoint.RecordTypeTXT {
+			if record.DNSName == queryName && record.RecordType == endpoint.RecordTypeTXT {
+				log.Printf("[TEST REGISTRY]   Found matching record: %s -> %v", record.DNSName, record.Targets)
 				for _, target := range record.Targets {
 					rr, err := dns.NewRR(fmt.Sprintf("%s 5 IN TXT %s", q.Name, target))
 					if err != nil {
@@ -136,6 +158,7 @@ func (r *Registry) addDNSAnswer(q dns.Question, msg *dns.Msg, req *dns.Msg) erro
 		}
 
 		if !found {
+			log.Printf("[TEST REGISTRY]   No TXT record found for %s, returning NXDOMAIN", queryName)
 			msg.SetRcode(req, dns.RcodeNameError)
 			return nil
 		}

testing/solver.go

@@ -69,14 +69,14 @@ func (s *Solver) Initialize(config *rest.Config, stopCh <-chan struct{}) error {
 	}
 
 	// Create source for new config
-	source, err := source.NewCRDSource(restClient, "", "DNSEndpoint", "", labels.Everything(), runtimeScheme, false)
+	crdSource, err := source.NewCRDSource(restClient, "", "DNSEndpoint", "", labels.Everything(), runtimeScheme, false)
 	if err != nil {
 		return err
 	}
 
 	// Setup the external-dns controller
 	externalDNS := controller.Controller{
-		Source:             source,
+		Source:             crdSource,
 		Registry:           s.Registry,
 		Policy:             &plan.SyncPolicy{},
 		DomainFilter:       s.Registry.domains,