Skip to content

Commit b9fc9b4

Browse files
authored
ci: drop pull_request_target from PR checks workflow (llm-d#1326)
The dual-event registration was a workaround for PRs created with GITHUB_TOKEN, which do not fire pull_request. Both PR-creating workflows in this repo now use App-installation tokens, which do fire pull_request, so pull_request_target is redundant and only produces duplicate SKIPPED check rows on every PR. Signed-off-by: Etai Lev Ran <elevran@gmail.com>
1 parent a232d49 commit b9fc9b4

1 file changed

Lines changed: 0 additions & 10 deletions

File tree

.github/workflows/ci-pr-checks.yaml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,6 @@ on:
88
pull_request:
99
branches:
1010
- main
11-
pull_request_target:
12-
branches:
13-
- main
14-
types: [ opened, synchronize, reopened ]
1511

1612
permissions:
1713
contents: read
@@ -23,12 +19,6 @@ concurrency:
2319

2420
jobs:
2521
check-changes:
26-
# pull_request_target fires even when GITHUB_TOKEN creates the PR (e.g. the
27-
# release-notes bot). pull_request does not. We register pull_request_target
28-
# so bot-created PRs get a "skipped" conclusion that satisfies branch
29-
# protection, but we skip all real work: pull_request already covers human
30-
# PRs, and running twice would cause the concurrency group to cancel one run.
31-
if: github.event_name != 'pull_request_target'
3222
runs-on: ubuntu-latest
3323
outputs:
3424
src: ${{ steps.filter.outputs.src }}

0 commit comments

Comments
 (0)