build: specify python version

Author: partizipation

.gitignore

@@ -27,7 +27,6 @@ coverage/
 venv/
 /pyvenv.cfg
 /pip-selfcheck.json
-.python-version
 
 # Node
 node_modules/

.python-version

@@ -0,0 +1 @@
+3.11.6

Makefile

@@ -2,6 +2,8 @@ VIRTUAL_ENV ?= venv
 NODE_BIN = node_modules/.bin
 SOURCE_DIRS = adhocracy-plus apps tests
 ARGUMENTS=$(filter-out $(firstword $(MAKECMDGOALS)), $(MAKECMDGOALS))
+PYTHON_MIN_VERSION = 3.11
+PYTHON_MAX_VERSION = 3.13
 
 # for mac os gsed is needed (brew install gnu-sed and brew install gsed)
 SED = sed
@@ -57,9 +59,16 @@ help:
 
 .PHONY: install
 install:
+	if [ ! -f $(VIRTUAL_ENV)/bin/python3 ]; then python3 -m venv $(VIRTUAL_ENV); fi
+	@python_version=`$(VIRTUAL_ENV)/bin/python3 -c 'import sys; print(".".join(map(str, sys.version_info[:2])))'`; \
+	if echo "$$python_version" | awk -F. -v min="$(PYTHON_MIN_VERSION)" -v max="$(PYTHON_MAX_VERSION)" \
+		'{ if ($$1 == 3 && $$2 >= min && $$2 < max) print "yes" }' | grep -q yes; then \
+		echo "Python version $$python_version is compatible"; \
+	else \
+		echo "Warning: Python version $$python_version detected. This project requires Python >= $(PYTHON_MIN_VERSION) and < $(PYTHON_MAX_VERSION)"; \
+	fi
 	npm install --no-save
 	npm run build
-	if [ ! -f $(VIRTUAL_ENV)/bin/python3 ]; then python3 -m venv $(VIRTUAL_ENV); fi
 	$(VIRTUAL_ENV)/bin/python -m pip install --upgrade -r requirements/dev.txt
 	$(VIRTUAL_ENV)/bin/python manage.py migrate
 

README.md

@@ -14,11 +14,14 @@ adhocracy+ is designed to make online participation easy and accessible to every
 ### Requirements
 
  * nodejs (+ npm) 
- * python 3.x (+ venv + pip)
+ * python>=3.11,<3.13
+    * We recommend using pyenv or similar to run a supported python version.
+    * The latest supported version is listed in `.python-version`, which pyenv will automatically follow.
  * libpq (only if postgres should be used)
  * sqlite3 [with JSON1 enabled](https://code.djangoproject.com/wiki/JSON1Extension)
  * redis (in production, not needed for development)
  * pillow-heif (required for macOS M1 Monterey and newer versions)
+ * libmagic (macOS users will need to install, for example with `brew install libmagic`)
 
 ### Installation
 

changelog/0001.md

@@ -0,0 +1,8 @@
+### Added
+
+- Specify python version in new .python-version file, which pyenv ingests
+
+### Changed
+
+- README mentions supported python versions
+- `make install` will now output a warning if the dev user is running a non-supported python version