fix liqoctl output

Author: aleoli

cmd/liqoctl/cmd/root.go

@@ -43,6 +43,7 @@ func NewRootCommand(ctx context.Context) *cobra.Command {
 			rootCmd.PersistentFlags().AddGoFlag(f)
 		}
 	})
+
 	rateFlagset := flag.NewFlagSet("rate-limiting", flag.PanicOnError)
 	restcfg.InitFlags(rateFlagset)
 	rootCmd.PersistentFlags().AddGoFlagSet(rateFlagset)

pkg/liqoctl/install/handler.go

@@ -19,16 +19,22 @@ import (
 	"fmt"
 
 	"github.com/spf13/cobra"
+	"k8s.io/klog/v2"
 
 	"github.com/liqotech/liqo/pkg/liqoctl/common"
 	"github.com/liqotech/liqo/pkg/liqoctl/generate"
 	installprovider "github.com/liqotech/liqo/pkg/liqoctl/install/provider"
 	installutils "github.com/liqotech/liqo/pkg/liqoctl/install/utils"
+	logsutils "github.com/liqotech/liqo/pkg/utils/logs"
 )
 
 // HandleInstallCommand implements the "install" command. It detects which provider has to be used, generates the chart
 // with provider-specific values. Finally, it performs the installation on the target cluster.
 func HandleInstallCommand(ctx context.Context, cmd *cobra.Command, baseCommand, providerName string) error {
+	if !klog.V(4).Enabled() {
+		klog.SetLogFilter(logsutils.LogFilter{})
+	}
+
 	config := common.GetLiqoctlRestConfOrDie()
 	providerInstance := getProviderInstance(providerName)
 

pkg/liqoctl/install/k3s/provider.go

@@ -230,7 +230,7 @@ func (k *k3sProvider) validateAPIServer() error {
 	hostname := apiServerURL.Hostname()
 	for i := range localhostValues {
 		if hostname == localhostValues[i] {
-			return fmt.Errorf("cannot use localhost (%v) as API Server address", hostname)
+			return fmt.Errorf("cannot use localhost (%v) as API Server address, set an external address in your kubeconfig", hostname)
 		}
 	}
 

pkg/utils/logs/doc.go

@@ -0,0 +1,16 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+// Package logs contains shared utility methods for logging.
+package logs

pkg/utils/logs/logfilter.go

@@ -0,0 +1,55 @@
+// Copyright 2019-2021 The Liqo Authors
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package logs
+
+import (
+	"fmt"
+	"strings"
+)
+
+// LogFilter implements the klog LogFilter interface, to filter log messages in the liqoctl install command.
+type LogFilter struct{}
+
+// Filter filters the helm CRDs installation errors.
+func (l LogFilter) Filter(args []interface{}) []interface{} {
+	if len(args) == 0 {
+		return args
+	}
+
+	err, ok := args[0].(error)
+	if !ok {
+		return args
+	}
+
+	if strings.
+		Contains(err.Error(), "couldn't get resource list for") && strings.
+		Contains(err.Error(), "the server could not find the requested resource") {
+		// since we cannot cancel the log, we change the error message to "continuing"
+		return []interface{}{
+			fmt.Errorf("continuing"),
+		}
+	}
+	return args
+}
+
+// FilterF does nothing (i.e, only passes through the arguments), as not used in this context.
+func (l LogFilter) FilterF(format string, args []interface{}) (f string, a []interface{}) {
+	return format, args
+}
+
+// FilterS does nothing (i.e, only passes through the arguments), as not used in this context.
+func (l LogFilter) FilterS(msg string, keysAndValues []interface{}) (m string, a []interface{}) {
+	return msg, keysAndValues
+}