fix(firewall): update SetDataType references to maintain consistency

Author: riccardotornesello

apis/networking/v1beta1/firewall/set_types.go

@@ -20,7 +20,7 @@ type SetDataType string
 
 // Possible SetDataType values.
 const (
-	SetTypeIPAddr SetDataType = "ipv4_addr"
+	SetDataTypeIPAddr SetDataType = "ipv4_addr"
 )
 
 // Set represents a nftables set

pkg/firewall/set.go

@@ -230,7 +230,7 @@ func getSetDataType(dataType *firewallapi.SetDataType) (nftables.SetDatatype, er
 	}
 
 	switch *dataType {
-	case firewallapi.SetTypeIPAddr:
+	case firewallapi.SetDataTypeIPAddr:
 		return nftables.TypeIPAddr, nil
 	default:
 		return nftables.SetDatatype{}, fmt.Errorf("unsupported set data type: %s", *dataType)

pkg/firewall/utils/set.go

@@ -34,7 +34,7 @@ func ConvertSetData(data *string, dataType *firewallapi.SetDataType) ([]byte, er
 	}
 
 	switch *dataType {
-	case firewallapi.SetTypeIPAddr:
+	case firewallapi.SetDataTypeIPAddr:
 		ip := net.ParseIP(*data)
 		if ip == nil {
 			return nil, fmt.Errorf("set element has invalid IP value %s", *data)

pkg/webhooks/firewallconfiguration/match.go

@@ -57,7 +57,7 @@ func checkMatchIPValue(mIP *firewallapi.MatchIP, sets []firewallapi.Set) error {
 			return fmt.Errorf("named set %s does not exist", mIP.Value)
 		}
 
-		if matchedSet.KeyType != firewallapi.SetTypeIPAddr {
+		if matchedSet.KeyType != firewallapi.SetDataTypeIPAddr {
 			return fmt.Errorf("named set %s is not of type IP", mIP.Value)
 		}
 	default: