refactor: change internal fabric name

Author: cheina97

pkg/gateway/fabric/geneve/internalnode_controller.go

@@ -73,7 +73,7 @@ func (r *InternalNodeReconciler) Reconcile(ctx context.Context, req ctrl.Request
 	klog.V(4).Infof("Reconciling internalnode %s", req.String())
 
 	// The internal fabric has the same name of the gateway resource.
-	internalFabricName := r.Options.GwOptions.Name
+	internalFabricName := r.Options.GwOptions.RemoteClusterID
 	id, err := geneve.GetGeneveTunnelID(ctx, r.Client, internalFabricName, internalnode.Name)
 	if err != nil {
 		return ctrl.Result{}, fmt.Errorf("internalnodecontroller waiting for geneve tunnel creation (with id %q): %w", id, err)

pkg/liqo-controller-manager/networking/forge/gatewayclient.go

@@ -34,7 +34,7 @@ const (
 
 // defaultGatewayClientName returns the default name for a GatewayClient.
 func defaultGatewayClientName(remoteClusterID liqov1beta1.ClusterID) string {
-	return string(remoteClusterID)
+	return "nomebrutto"
 }
 
 // GwClientOptions encapsulate the options to forge a GatewayClient.

pkg/liqo-controller-manager/networking/internal-network/client-controller/client_controller.go

@@ -106,9 +106,14 @@ func (r *ClientReconciler) ensureInternalFabric(ctx context.Context, gwClient *n
 		return fmt.Errorf("internal endpoint not found for the gateway client %q", gwClient.Name)
 	}
 
+	internalFabricName, err := getters.RetrieveClusterIDFromObject(gwClient)
+	if err != nil {
+		return fmt.Errorf("unable to retrieve the cluster ID from the gateway client %q", gwClient.Name)
+	}
+
 	internalFabric := &networkingv1beta1.InternalFabric{
 		ObjectMeta: metav1.ObjectMeta{
-			Name:      gwClient.Name,
+			Name:      string(internalFabricName),
 			Namespace: gwClient.Namespace,
 		},
 	}

pkg/liqo-controller-manager/networking/internal-network/server-controller/server_controller.go

@@ -106,9 +106,14 @@ func (r *ServerReconciler) ensureInternalFabric(ctx context.Context, gwServer *n
 		return fmt.Errorf("internal endpoint not found for the gateway server %q", gwServer.Name)
 	}
 
+	internalFabricName, err := getters.RetrieveClusterIDFromObject(gwServer)
+	if err != nil {
+		return fmt.Errorf("unable to retrieve the cluster ID from the gateway server %q", gwServer.Name)
+	}
+
 	internalFabric := &networkingv1beta1.InternalFabric{
 		ObjectMeta: metav1.ObjectMeta{
-			Name:      gwServer.Name,
+			Name:      string(internalFabricName),
 			Namespace: gwServer.Namespace,
 		},
 	}

pkg/utils/getters/dataGetters.go

@@ -180,3 +180,18 @@ func RetrieveClusterIDsFromObjectsLabels[T metav1.Object](objectList []T) []stri
 	}
 	return slices.Collect(maps.Keys(clusterIDs))
 }
+
+// RetrieveClusterIDFromObjectLabels retrieves the remote cluster ID from the labels of a generic kubernetes object.
+func RetrieveClusterIDFromObject[T metav1.Object](object T) (liqov1beta1.ClusterID, error) {
+	labels := object.GetLabels()
+	if labels == nil {
+		return "", fmt.Errorf("object %s/%s has no labels", object.GetNamespace(), object.GetName())
+	}
+
+	clusterID, ok := labels[liqoconsts.RemoteClusterID]
+	if !ok || clusterID == "" {
+		return "", fmt.Errorf("object %s/%s has no remote cluster ID label", object.GetNamespace(), object.GetName())
+	}
+
+	return liqov1beta1.ClusterID(clusterID), nil
+}