Skip to content

Commit 460a67a

Browse files
committed
small fixes for the release
1 parent 6adf440 commit 460a67a

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.github/workflows/integration.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -301,6 +301,7 @@ jobs:
301301
with:
302302
artifacts: ".cr-release-packages/*"
303303
generateReleaseNotes: true
304+
token: ${{ secrets.CI_TOKEN }}
304305
allowUpdates: true
305306
tag: ${{ needs.configure.outputs.commit-ref }}
306307
name: ${{ needs.configure.outputs.commit-ref }}
@@ -324,7 +325,7 @@ jobs:
324325
- uses: ncipollo/release-action@v1
325326
with:
326327
artifacts: "./liqoctl/**/*"
327-
generateReleaseNotes: true
328+
token: ${{ secrets.CI_TOKEN }}
328329
allowUpdates: true
329330
tag: ${{ needs.configure.outputs.commit-ref }}
330331
name: ${{ needs.configure.outputs.commit-ref }}

docs/conf.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@
100100

101101
# __get_download_url returns the download URL for the given file, for the latest or the given GitHub release.
102102
def __get_download_url(file: str) -> str:
103-
if not 'current_version' in html_context or not __is_sem_version(html_context['current_version']):
103+
if 'current_version' not in html_context or not __is_sem_version(html_context['current_version']):
104104
return f"https://github.com/liqotech/liqo/releases/latest/download/{file}"
105105
else:
106106
return f"https://github.com/liqotech/liqo/releases/download/{html_context['current_version']}/{file}"
@@ -137,11 +137,11 @@ def generate_liqoctl_install(platform: str, arch: str) -> str:
137137

138138
# __is_sem_version returns True if the given string is a semantic version or the 'stable' string.
139139
def __is_sem_version(version: str) -> bool:
140-
return version == 'stable' or semver.VersionInfo.isvalid(version)
140+
return version == 'stable' or semver.VersionInfo.isvalid(version.lstrip("v"))
141141

142142
# generate_liqoctl_version_warning generates the liqoctl version warning when the documentation is not for a released version.
143143
def generate_liqoctl_version_warning() -> str:
144-
if not 'github_version' in html_context or not __is_sem_version(html_context['github_version']):
144+
if 'github_version' not in html_context or not __is_sem_version(html_context['github_version']):
145145
return "```{warning}\n\
146146
The following instructions will guide you through the installation of the **latest stable version of *liqoctl***, which might exhibit a different behavior compared to the one shown in the rest of this documentation. If you want to use the latest *liqoctl* version, [build it from source](InstallationLiqoctlFromSource).\n\
147147
```\n"

0 commit comments

Comments
 (0)