Cleanup old consts and tests

Author: fra98

deployments/liqo/README.md

@@ -145,7 +145,6 @@
 | networking.gatewayTemplates.server.service.annotations | object | `{"service.beta.kubernetes.io/aws-load-balancer-type":"nlb"}` | Annotations for the server service. |
 | networking.iptables | object | `{"mode":"nf_tables"}` | Iptables configuration tuning. |
 | networking.iptables.mode | string | `"nf_tables"` | Select the iptables mode to use. Possible values are "legacy" and "nf_tables". |
-| networking.legacy | bool | `false` | Set to "true" to install the legacy networking stack. |
 | networking.mtu | int | `1340` | Set the MTU for the interfaces managed by liqo: vxlan, tunnel and veth interfaces. The value is used by the gateway and route operators. The default value is configured to ensure correct behavior regardless of the combination of the underlying environments (e.g., cloud providers). This guarantees improved compatibility at the cost of possible limited performance drops. |
 | networking.reflectIPs | bool | `true` | Reflect pod IPs and EnpointSlices to the remote clusters. |
 | networking.securityMode | string | `"FullPodToPod"` | Select the mode to enforce security on connectivity among clusters. Possible values are "FullPodToPod" and "IntraClusterTrafficSegregation"  |

deployments/liqo/templates/_helpers.tpl

@@ -130,22 +130,6 @@ Create the file name of a cluster role starting from a prefix, it accepts a dict
 {{- printf "files/%s-%s" .prefix "ClusterRole.yaml" }}
 {{- end }}
 
-{{/*
-Gateway pod labels.
-If you change any value here, please make sure that you change it also in the source code.
-*/}}
-{{- define "liqo.gatewayPodLabels" -}}
-net.liqo.io/gateway: "standby"
-{{- end }}
-
-{{/*
-Label selector used by the gateway service to select the right gateway pod.
-If you change any value here, please make sure that you change it also in the source code.
-*/}}
-{{- define "liqo.gatewaySelector" -}}
-net.liqo.io/gateway: "active"
-{{- end }}
-
 {{/*
 Auth pod labels
 */}}
@@ -167,13 +151,6 @@ Webhook pod labels
 webhook.liqo.io/backend: "liqo-webhook"
 {{- end }}
 
-{{/*
-Gateway service labels
-*/}}
-{{- define "liqo.gatewayServiceLabels" -}}
-net.liqo.io/gateway: "true"
-{{- end }}
-
 {{/*
 Pre-delete hook Annotations
 */}}

deployments/liqo/templates/liqo-controller-manager-deployment.yaml

@@ -2,7 +2,6 @@
 {{- $ctrlManagerConfig := (merge (dict "name" "controller-manager" "module" "controller-manager" "version" .Values.controllerManager.image.version) .) -}}
 {{- $kubeletConfig :=  (merge (dict "name" "virtual-kubelet" "module" "virtualkubelet" "version" .Values.virtualKubelet.image.version) .) -}}
 {{- $webhookConfig := (merge (dict "name" "webhook" "module" "webhook") .) -}}
-{{- $netManagerConfig := (merge (dict "name" "network-manager" "module" "networking") .) -}}
 {{- $ipamConfig := (merge (dict "name" "ipam" "module" "ipam") .) -}}
 
 {{- $vkargs := .Values.virtualKubelet.extra.args }}
@@ -123,8 +122,6 @@ spec:
           {{- else if not .Values.networking.enabled }}
           - --ipam-server=
           - --networking-enabled=false
-          {{- else if .Values.networking.legacy }}
-          - --ipam-server={{ include "liqo.prefixedName" $netManagerConfig }}.{{ .Release.Namespace }}:6000
           {{- else }}
           - --ipam-server={{ include "liqo.prefixedName" $ipamConfig }}.{{ .Release.Namespace }}:6000
           {{- end }}

deployments/liqo/templates/liqo-ipam-deployment.yaml

@@ -1,4 +1,4 @@
-{{- if and (.Values.networking.enabled) (not .Values.ipam.external.enabled) (not .Values.networking.legacy ) }}
+{{- if and (.Values.networking.enabled) (not .Values.ipam.external.enabled) }}
 
 {{- $ipamConfig := (merge (dict "name" "ipam" "module" "ipam" "version" .Values.ipam.internal.image.version) .) -}}
 {{- $ha := (gt .Values.ipam.internal.replicas 1.0) -}}

deployments/liqo/templates/liqo-ipam-rbac.yaml

@@ -1,7 +1,7 @@
 ---
 {{- $ipamConfig := (merge (dict "name" "ipam" "module" "ipam") .) -}}
 
-{{- if and (.Values.networking.enabled) (not .Values.ipam.external.enabled) (not .Values.networking.legacy ) }}
+{{- if and (.Values.networking.enabled) (not .Values.ipam.external.enabled) }}
 
 apiVersion: v1
 kind: ServiceAccount

deployments/liqo/templates/liqo-ipam-service.yaml

@@ -1,4 +1,4 @@
-{{- if and (.Values.networking.enabled) (not .Values.ipam.external.enabled) (not .Values.networking.legacy ) }}
+{{- if and (.Values.networking.enabled) (not .Values.ipam.external.enabled) }}
 
 {{- $ipamConfig := (merge (dict "name" "ipam" "module" "ipam") .) -}}
 {{- $ha := (gt .Values.ipam.internal.replicas 1.0) -}}

deployments/liqo/values.yaml

@@ -24,8 +24,6 @@ apiServer:
   trustedCA: false
 
 networking:
-  # -- Set to "true" to install the legacy networking stack.
-  legacy: false
   # -- Use the default Liqo networking module.
   enabled: true
   # -- Reflect pod IPs and EnpointSlices to the remote clusters.

docs/faq/faq.md

@@ -79,8 +79,6 @@ It is highly recommended to first unpeer all existing foreignclusters before upg
 If using `liqoctl unpeer` command does not fix the problem (probably due to some cluster setup misconfiguration), you can try to manually unpeer the cluster by force deleting all Liqo resources associated with that ForeignCluster.
 To do this, force delete all resources (look also in the tenant namespace) with the following types (possibly in this order):
 
-* `TunnelEndpoint`
-* `NetworkConfig`
 * `ResourceOffers`
 * `ResourceRequests`
 * `NamespaceMap`

internal/crdReplicator/crdReplicator_operator_test.go

@@ -38,7 +38,6 @@ var _ = Describe("CRD Replicator Operator Tests", func() {
 		foreignClusterName  = "foreign-cluster"
 		resourceRequestName = "resource-request"
 		resourceOfferName   = "resource-offer"
-		networkConfigName   = "network-config"
 
 		authURL = "https://foo.bar"
 	)

internal/crdReplicator/reflection/manager_test.go

@@ -127,7 +127,7 @@ var _ = Describe("Manager tests", func() {
 
 		AfterEach(func() { cancel() })
 
-		CreateNetworkConfig := func() error {
+		CreateReplicatedResource := func() error {
 			obj := &unstructured.Unstructured{}
 			obj.SetGroupVersionKind(objGVK)
 			obj.SetNamespace(objNamespace)
@@ -144,14 +144,14 @@ var _ = Describe("Manager tests", func() {
 			return func() {
 				JustBeforeEach(func() {
 					if alreadyPresent && !skipCreation {
-						Expect(CreateNetworkConfig()).To(Succeed())
+						Expect(CreateReplicatedResource()).To(Succeed())
 					}
 
 					manager.Start(ctx, res)
 					manager.registerHandler(gvr, localNamespace, func(key item) { receiver <- key })
 
 					if !alreadyPresent && !skipCreation {
-						Expect(CreateNetworkConfig()).To(Succeed())
+						Expect(CreateReplicatedResource()).To(Succeed())
 					}
 				})
 
@@ -166,7 +166,7 @@ var _ = Describe("Manager tests", func() {
 							JustBeforeEach(func() {
 								manager.unregisterHandler(gvr, localNamespace)
 								// Create the object only once the handler has been unregistered, to prevent race conditions.
-								Expect(CreateNetworkConfig()).To(Succeed())
+								Expect(CreateReplicatedResource()).To(Succeed())
 							})
 							It("should not trigger the handler", func() { Consistently(receiver).ShouldNot(Receive()) })
 						})