feat: avoid kyverno dependency in tests

Author: cheina97

pkg/liqoctl/test/network/client/k8s.go

@@ -95,7 +95,7 @@ func initConfigAndClient(ctx context.Context, kubeconfig string, cl *Client, cfg
 	sname := string(name)
 
 	cfg[sname] = cfgtmp
-	if cl.ConsumerName == "" {
+	if kubeconfig == "" {
 		cl.ConsumerName = sname
 		cl.Consumer = cltmp
 		cl.ConsumerDynamic = cldyntmp

pkg/liqoctl/test/network/setup/kyverno.go

@@ -22,8 +22,10 @@ import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/runtime/schema"
+	"k8s.io/client-go/dynamic"
 
 	"github.com/liqotech/liqo/pkg/liqoctl/test/network/client"
+	"github.com/liqotech/liqo/pkg/liqoctl/test/network/flags"
 )
 
 // KyvernoPolicyGroupVersionResource specifies the group version resource used to register the objects.
@@ -32,32 +34,54 @@ var KyvernoPolicyGroupVersionResource = schema.GroupVersionResource{Group: "kyve
 // KyvernoPolicyKind is the kind of the Kyverno policy.
 const KyvernoPolicyKind = "Policy"
 
+// IsKyvernoAvailable checks if Kyverno is available.
+func IsKyvernoAvailable(ctx context.Context, cl *dynamic.DynamicClient) bool {
+	_, err := cl.Resource(KyvernoPolicyGroupVersionResource).
+		Namespace(NamespaceName).List(ctx, metav1.ListOptions{})
+	return err == nil
+}
+
 // CreatePolicy creates the Kyverno policies.
-func CreatePolicy(ctx context.Context, cl *client.Client) error {
-	policy := ForgeKyvernoPodAntiaffinityPolicy(cl.ConsumerName, false)
-	if _, err := cl.ConsumerDynamic.Resource(KyvernoPolicyGroupVersionResource).
-		Namespace(NamespaceName).Create(ctx, policy, metav1.CreateOptions{}); err != nil && !apierrors.IsAlreadyExists(err) {
-		return fmt.Errorf("consumer failed to create policy: %w", err)
-	}
+func CreatePolicy(ctx context.Context, cl *client.Client, opts *flags.Options) error {
+	var kyvernoNotInstalled bool
+	printer := opts.Topts.LocalFactory.Printer
+	if IsKyvernoAvailable(ctx, cl.ConsumerDynamic) {
+		policy := ForgeKyvernoPodAntiaffinityPolicy(cl.ConsumerName, false)
+		if _, err := cl.ConsumerDynamic.Resource(KyvernoPolicyGroupVersionResource).
+			Namespace(NamespaceName).Create(ctx, policy, metav1.CreateOptions{}); err != nil && !apierrors.IsAlreadyExists(err) {
+			return fmt.Errorf("consumer failed to create policy: %w", err)
+		}
 
-	policy = ForgeKyvernoPodAntiaffinityPolicy(cl.ConsumerName, true)
-	if _, err := cl.ConsumerDynamic.Resource(KyvernoPolicyGroupVersionResource).
-		Namespace(NamespaceName).Create(ctx, policy, metav1.CreateOptions{}); err != nil && !apierrors.IsAlreadyExists(err) {
-		return fmt.Errorf("consumer failed to create policy: %w", err)
+		policy = ForgeKyvernoPodAntiaffinityPolicy(cl.ConsumerName, true)
+		if _, err := cl.ConsumerDynamic.Resource(KyvernoPolicyGroupVersionResource).
+			Namespace(NamespaceName).Create(ctx, policy, metav1.CreateOptions{}); err != nil && !apierrors.IsAlreadyExists(err) {
+			return fmt.Errorf("consumer failed to create policy: %w", err)
+		}
+	} else {
+		kyvernoNotInstalled = true
+		printer.Logger.Warn("Kyverno not available on consumer, skipping policy creation.")
 	}
 
 	for k := range cl.Providers {
-		policy := ForgeKyvernoPodAntiaffinityPolicy(k, false)
-		if _, err := cl.ProvidersDynamic[k].Resource(KyvernoPolicyGroupVersionResource).
-			Namespace(NamespaceName).Create(ctx, policy, metav1.CreateOptions{}); err != nil && !apierrors.IsAlreadyExists(err) {
-			return fmt.Errorf("provider %q failed to create policy: %w", k, err)
-		}
-		policy = ForgeKyvernoPodAntiaffinityPolicy(k, true)
-		if _, err := cl.ProvidersDynamic[k].Resource(KyvernoPolicyGroupVersionResource).
-			Namespace(NamespaceName).Create(ctx, policy, metav1.CreateOptions{}); err != nil && !apierrors.IsAlreadyExists(err) {
-			return fmt.Errorf("provider %q failed to create policy: %w", k, err)
+		if IsKyvernoAvailable(ctx, cl.ProvidersDynamic[k]) {
+			policy := ForgeKyvernoPodAntiaffinityPolicy(k, false)
+			if _, err := cl.ProvidersDynamic[k].Resource(KyvernoPolicyGroupVersionResource).
+				Namespace(NamespaceName).Create(ctx, policy, metav1.CreateOptions{}); err != nil && !apierrors.IsAlreadyExists(err) {
+				return fmt.Errorf("provider %q failed to create policy: %w", k, err)
+			}
+			policy = ForgeKyvernoPodAntiaffinityPolicy(k, true)
+			if _, err := cl.ProvidersDynamic[k].Resource(KyvernoPolicyGroupVersionResource).
+				Namespace(NamespaceName).Create(ctx, policy, metav1.CreateOptions{}); err != nil && !apierrors.IsAlreadyExists(err) {
+				return fmt.Errorf("provider %q failed to create policy: %w", k, err)
+			}
+		} else {
+			kyvernoNotInstalled = true
+			printer.Logger.Warn(fmt.Sprintf("Kyverno not available on provider %q, skipping policy creation.", k))
 		}
 	}
+	if kyvernoNotInstalled {
+		printer.Logger.Warn("Pods may not be scheduled on every node. Install Kyverno on all clusters for comprehensive tests.")
+	}
 	return nil
 }
 

pkg/liqoctl/test/network/setup/setup.go

@@ -37,7 +37,7 @@ func MakeInfrastructure(ctx context.Context, cl *client.Client, opts *flags.Opti
 		return 0, fmt.Errorf("error offloading namespace: %w", err)
 	}
 
-	if err := CreatePolicy(ctx, cl); err != nil {
+	if err := CreatePolicy(ctx, cl, opts); err != nil {
 		return 0, fmt.Errorf("error creating policy: %w", err)
 	}