refactor: remove useless chain type comparison

riccardotornesello · fra98 · adamjensenbot · commit a69ef286a7ce · 2025-11-21T18:07:03.000+01:00
Co-authored-by: Francesco Torta &lt;62566275+fra98@users.noreply.github.com&gt;
diff --git a/pkg/liqo-controller-manager/networking/internal-network/gw-masq-bypass/leftovers.go b/pkg/liqo-controller-manager/networking/internal-network/gw-masq-bypass/leftovers.go
@@ -88,7 +88,7 @@ func (r *PodReconciler) processFirewallConfiguration(ctx context.Context, fwcfgl
 
 		chain := fwcfglist.Items[i].Spec.Table.Chains[0]
 
-		if chain.Type == "" || chain.Type != firewall.ChainTypeNAT {
+		if chain.Type != firewall.ChainTypeNAT {
 			return fmt.Errorf("firewall configuration table chain should be of type NAT, not %s", chain.Type)
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ func (r *PodReconciler) processFirewallConfiguration(ctx context.Context, fwcfgl`
`88`	`88`
`89`	`89`	`chain := fwcfglist.Items[i].Spec.Table.Chains[0]`
`90`	`90`
`91`		`- if chain.Type == "" \|\| chain.Type != firewall.ChainTypeNAT {`
	`91`	`+ if chain.Type != firewall.ChainTypeNAT {`
`92`	`92`	`return fmt.Errorf("firewall configuration table chain should be of type NAT, not %s", chain.Type)`
`93`	`93`	`}`
`94`	`94`