fix(reflection): allow scheduling pods with name > 63

Author: fra98

pkg/virtualKubelet/forge/secrets.go

@@ -57,7 +57,7 @@ func init() {
 
 // IsServiceAccountSecret returns whether the current object contains remotely reflected service account tokens.
 func IsServiceAccountSecret(obj metav1.Object) bool {
-	return serviceAccountSecretSelector.Matches(labels.Set(obj.GetLabels()))
+	return serviceAccountSecretSelector.Matches(labels.Merge(obj.GetLabels(), obj.GetAnnotations()))
 }
 
 // RemoteSecret forges the apply patch for the reflected secret, given the local one.
@@ -97,14 +97,14 @@ func RemoteServiceAccountSecret(tokens *ServiceAccountPodTokens, targetName, tar
 // RemoteServiceAccountSecretLabels returns the labels assigned to the secret holding service account tokens.
 func RemoteServiceAccountSecretLabels(tokens *ServiceAccountPodTokens) labels.Set {
 	return map[string]string{
-		LiqoSASecretForPodNameKey:        tokens.PodName,
 		LiqoSASecretForServiceAccountKey: tokens.ServiceAccountName,
 	}
 }
 
 // RemoteServiceAccountSecretAnnotations returns the annotations assigned to the secret holding service account tokens.
 func RemoteServiceAccountSecretAnnotations(tokens *ServiceAccountPodTokens) labels.Set {
 	return map[string]string{
+		LiqoSASecretForPodNameKey: tokens.PodName,
 		LiqoSASecretForPodUIDKey:  string(tokens.PodUID),
 		LiqoSASecretExpirationKey: tokens.EarliestExpiration().Format(time.RFC3339),
 	}

pkg/virtualKubelet/reflection/configuration/serviceaccount.go

@@ -101,8 +101,8 @@ func RemoteSASecretNamespacedKeyer(namespace, nodename string) func(metadata met
 			return []types.NamespacedName{}
 		}
 
-		// The label is certainly present, since it matched the selector.
-		po := metadata.GetLabels()[forge.LiqoSASecretForPodNameKey]
+		// The annotation is certainly present, since it matched the selector.
+		po := metadata.GetAnnotations()[forge.LiqoSASecretForPodNameKey]
 		return []types.NamespacedName{{Namespace: namespace, Name: po}}
 	}
 }