Merge pull request #23 from imikho/master

Fix wrong logic in check signature

Author: viplifes

app/code/LiqpayMagento/LiqPay/Helper/Data.php

@@ -118,11 +118,15 @@ public function checkOrderIsLiqPayPayment(\Magento\Sales\Api\Data\OrderInterface
     public function securityOrderCheck($data, $receivedPublicKey, $receivedSignature)
     {
         if ($this->isSecurityCheck()) {
-            $privateKey = $this->getPrivateKey();
             $publicKey = $this->getPublicKey();
+            if ($publicKey !== $receivedPublicKey) {
+                return false;
+            }            
+            
+            $privateKey = $this->getPrivateKey();
             $generatedSignature = base64_encode(sha1($privateKey . $data . $privateKey, 1));
-            return $privateKey && $publicKey
-                && $receivedSignature == $generatedSignature || $publicKey == $receivedPublicKey;
+            
+            return $receivedSignature === $generatedSignature;
         } else {
             return true;
         }
@@ -132,4 +136,4 @@ public function getLogger()
     {
         return $this->_logger;
     }
-}
+}