Pass nonce=0 to client.simulateCalls() (#903)

* Fix simulateCalls() by overriding the nonce

* Upgrade dependencies

Author: bpierre

frontend/app/package.json

@@ -25,22 +25,22 @@
     "@liquity2/uikit": "workspace:*",
     "@next/bundle-analyzer": "15.3.1",
     "@react-spring/web": "^10.0.0-beta.0",
-    "@tanstack/react-query": "^5.75.2",
+    "@tanstack/react-query": "^5.75.4",
     "@vercel/analytics": "^1.5.0",
     "@wagmi/core": "^2.17.1",
     "abitype": "^1.0.8",
     "blo": "^2.0.0",
     "connectkit": "^1.9.0",
     "dnum": "^2.14.0",
     "focus-trap-react": "^11.0.3",
-    "geist": "^1.4.1",
+    "geist": "^1.4.2",
     "next": "15.3.1",
     "react": "19.1.0",
     "react-dom": "19.1.0",
     "sharp": "^0.34.1",
     "ts-pattern": "^5.7.0",
-    "valibot": "^1.0.0",
-    "viem": "^2.28.3",
+    "valibot": "^1.1.0",
+    "viem": "^2.29.0",
     "wagmi": "^2.15.2"
   },
   "devDependencies": {
@@ -51,8 +51,8 @@
     "@testing-library/jest-dom": "^6.6.3",
     "@testing-library/react": "^16.3.0",
     "@testing-library/user-event": "^14.6.1",
-    "@types/node": "^22.15.3",
-    "@types/react": "19.1.2",
+    "@types/node": "^22.15.12",
+    "@types/react": "19.1.3",
     "@types/react-dom": "19.1.3",
     "@vitejs/plugin-react": "^4.4.1",
     "@vitest/coverage-v8": "^3.1.3",

frontend/app/src/tx-flows/legacyRedeemCollateral.tsx

@@ -3,8 +3,7 @@ import type { Address } from "@/src/types";
 
 import { CollateralRegistry } from "@/src/abi/CollateralRegistry";
 import { Amount } from "@/src/comps/Amount/Amount";
-import { LOCAL_STORAGE_PREFIX } from "@/src/constants";
-import { dnum18, jsonParseWithDnum, jsonStringifyWithDnum } from "@/src/dnum-utils";
+import { dnum18, jsonStringifyWithDnum } from "@/src/dnum-utils";
 import { LEGACY_CHECK } from "@/src/env";
 import { TransactionDetailsRow } from "@/src/screens/TransactionsScreen/TransactionsScreen";
 import { TransactionStatus } from "@/src/screens/TransactionsScreen/TransactionStatus";
@@ -52,7 +51,7 @@ export const legacyRedeemCollateral: FlowDeclaration<LegacyRedeemCollateralReque
             <Amount
               key="start"
               value={boldChange}
-              fallback="fetching…"
+              fallback={estimatedGains.isError ? "loading error." : "fetching…"}
               suffix=" BOLD"
             />,
             <>Estimated BOLD that will be redeemed.</>,
@@ -69,7 +68,7 @@ export const legacyRedeemCollateral: FlowDeclaration<LegacyRedeemCollateralReque
                 <Amount
                   key="start"
                   value={collChange}
-                  fallback="fetching…"
+                  fallback={estimatedGains.isError ? "loading error." : "fetching…"}
                   suffix={` ${symbol_}`}
                 />,
                 <>Estimated {symbol_} you will receive.</>,
@@ -175,22 +174,6 @@ export function useSimulatedBalancesChange({
         throw new Error("LEGACY_CHECK is not defined");
       }
 
-      let stored: v.InferOutput<typeof StoredBalancesChangeSchema> | null = null;
-      try {
-        stored = v.parse(
-          StoredBalancesChangeSchema,
-          jsonParseWithDnum(
-            localStorage.getItem(
-              `${LOCAL_STORAGE_PREFIX}:simulatedBalancesChange`,
-            ) ?? "",
-          ),
-        );
-      } catch (_) {}
-
-      if (stored && stored.stringifiedRequest === jsonStringifyWithDnum(request)) {
-        return stored.balanceChanges;
-      }
-
       const [chain] = wagmiConfig.chains;
       const [rpcUrl] = chain.rpcUrls.default.http;
       const client = createPublicClient({ chain, transport: http(rpcUrl) });
@@ -212,17 +195,25 @@ export function useSimulatedBalancesChange({
       const simulation = await client.simulateCalls({
         account,
         calls: [
+          // 1. get balances before
           boldBalanceCall,
           ...branchesBalanceCalls,
+
+          // 2. redeem
           {
             to: LEGACY_CHECK.COLLATERAL_REGISTRY,
             abi: CollateralRegistry,
             functionName: "redeemCollateral",
             args: [request.amount[0], 0n, request.maxFee[0]],
           },
+
+          // 3. get balances after
           boldBalanceCall,
           ...branchesBalanceCalls,
         ],
+
+        // This is needed to avoid a “nonce too low” error with certain RPCs
+        stateOverrides: [{ address: account, nonce: 0 }],
       });
 
       const getBalancesFromSimulated = (position: number) => {
@@ -246,24 +237,14 @@ export function useSimulatedBalancesChange({
       const balancesBefore = getBalancesFromSimulated(0);
       const balancesAfter = getBalancesFromSimulated(LEGACY_CHECK.BRANCHES.length + 2);
 
-      const balanceChanges = balancesBefore.map((balanceBefore, index) => {
+      return balancesBefore.map((balanceBefore, index) => {
         const balanceAfter = balancesAfter[index];
         if (!balanceAfter) throw new Error();
         return {
           symbol: balanceBefore.symbol,
           change: dn.sub(balanceAfter.balance, balanceBefore.balance),
         };
       });
-
-      localStorage.setItem(
-        `${LOCAL_STORAGE_PREFIX}:simulatedBalancesChange`,
-        jsonStringifyWithDnum({
-          stringifiedRequest: jsonStringifyWithDnum(request),
-          balanceChanges,
-        }),
-      );
-
-      return balanceChanges;
     },
   });
 }

frontend/app/src/tx-flows/redeemCollateral.tsx

@@ -206,17 +206,25 @@ export function useSimulatedBalancesChange({
       const simulation = await client.simulateCalls({
         account,
         calls: [
+          // 1. get balances before
           boldBalanceCall,
           ...branchesBalanceCalls,
+
+          // 2. redeem
           {
             to: CollateralRegistry.address,
             abi: CollateralRegistry.abi,
             functionName: "redeemCollateral",
             args: [request.amount[0], 0n, request.maxFee[0]],
           },
+
+          // 3. get balances after
           boldBalanceCall,
           ...branchesBalanceCalls,
         ],
+
+        // This is needed to avoid a “nonce too low” error with certain RPCs
+        stateOverrides: [{ address: account, nonce: 0 }],
       });
 
       const getBalancesFromSimulated = (position: number) => {