Skip to content

Commit 00d12d8

Browse files
committed
Update MySQL image tag determination to use MLRun API image tag instead of appVersion in values.yaml and helper template.
1 parent 6005d7c commit 00d12d8

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

stable/mlrun/templates/_helpers.tpl

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -184,15 +184,15 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this
184184
{{- end -}}
185185

186186
{{/*
187-
Determine MySQL image tag based on MLRun appVersion.
187+
Determine MySQL image tag based on MLRun API image tag.
188188
- If db.image.tag is explicitly set in values, use that (allows override)
189-
- Otherwise, use MySQL 8.0 for appVersion < 1.11.0, and MySQL 8.4 for appVersion >= 1.11.0
189+
- Otherwise, use MySQL 8.0 for api.image.tag < 1.11.0, and MySQL 8.4 for api.image.tag >= 1.11.0
190190
*/}}
191191
{{- define "mlrun.db.mysqlTag" -}}
192192
{{- if .Values.db.image.tag -}}
193193
{{- .Values.db.image.tag -}}
194194
{{- else -}}
195-
{{- if semverCompare "<1.11.0" .Chart.AppVersion -}}
195+
{{- if semverCompare "<1.11.0" .Values.api.image.tag -}}
196196
{{- print "8.0" -}}
197197
{{- else -}}
198198
{{- print "8.4" -}}

stable/mlrun/values.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -395,9 +395,9 @@ db:
395395

396396
image:
397397
repository: mysql
398-
# MySQL tag is automatically determined based on MLRun appVersion:
399-
# - MySQL 8.0 for appVersion < 1.11.0
400-
# - MySQL 8.4 for appVersion >= 1.11.0
398+
# MySQL tag is automatically determined based on MLRun API image tag:
399+
# - MySQL 8.0 for api.image.tag < 1.11.0
400+
# - MySQL 8.4 for api.image.tag >= 1.11.0
401401
# Set this value explicitly to override the automatic selection
402402
tag: ""
403403
pullPolicy: IfNotPresent

0 commit comments

Comments
 (0)