Refactor MySQL image tag handling in values.yaml and db-deployment.yaml to support automatic version selection based on MLRun appVersion. Add helper function for determining MySQL tag, allowing explicit overrides.

Author: liranbg

stable/mlrun/templates/_helpers.tpl

@@ -183,6 +183,23 @@ We truncate at 63 chars because some Kubernetes name fields are limited to this
 {{- printf "%s-init" (include "mlrun.db.fullname" .) | trunc 63 | trimSuffix "-" -}}
 {{- end -}}
 
+{{/*
+Determine MySQL image tag based on MLRun appVersion.
+- If db.image.tag is explicitly set in values, use that (allows override)
+- Otherwise, use MySQL 8.0 for appVersion < 1.11.0, and MySQL 8.4 for appVersion >= 1.11.0
+*/}}
+{{- define "mlrun.db.mysqlTag" -}}
+{{- if .Values.db.image.tag -}}
+{{- .Values.db.image.tag -}}
+{{- else -}}
+{{- if semverCompare "<1.11.0" .Chart.AppVersion -}}
+{{- print "8.0" -}}
+{{- else -}}
+{{- print "8.4" -}}
+{{- end -}}
+{{- end -}}
+{{- end -}}
+
 
 {{/*
 This is to couple nuclio and mlrun charts, and comes to workaround the fact that the same

stable/mlrun/templates/db-deployment.yaml

@@ -28,7 +28,7 @@ spec:
       terminationGracePeriodSeconds: 120
       initContainers:
         - name: init-mysql
-          image: "{{ .Values.db.image.repository }}:{{ .Values.db.image.tag }}"
+          image: "{{ .Values.db.image.repository }}:{{ include "mlrun.db.mysqlTag" . }}"
           imagePullPolicy: {{ .Values.db.image.pullPolicy }}
           resources:
             {{- toYaml .Values.db.resources | nindent 12 }}
@@ -47,7 +47,7 @@ spec:
         - name: {{ template "mlrun.name" . }}-{{ .Values.db.name }}
           securityContext:
             {{- toYaml .Values.db.securityContext | nindent 12 }}
-          image: "{{ .Values.db.image.repository }}:{{ .Values.db.image.tag }}"
+          image: "{{ .Values.db.image.repository }}:{{ include "mlrun.db.mysqlTag" . }}"
           imagePullPolicy: {{ .Values.db.image.pullPolicy }}
           command: ["/bin/bash", "/etc/config/mysql/v3io-mysql.sh"]
           ports:

stable/mlrun/values.yaml

@@ -395,7 +395,11 @@ db:
 
   image:
     repository: mysql
-    tag: "8.4"
+    # MySQL tag is automatically determined based on MLRun appVersion:
+    # - MySQL 8.0 for appVersion < 1.11.0
+    # - MySQL 8.4 for appVersion >= 1.11.0
+    # Set this value explicitly to override the automatic selection
+    tag: ""
     pullPolicy: IfNotPresent
     pullSecrets: []