ide warnings

lucaneg · lucaneg · commit 10a2bde015fb · 2025-05-19T16:06:24.000+02:00
diff --git a/src/main/java/it/unipr/analysis/StackElement.java b/src/main/java/it/unipr/analysis/StackElement.java
@@ -12,6 +12,7 @@
 import org.apache.logging.log4j.Logger;
 
 public class StackElement implements BaseLattice<StackElement>, Comparable<StackElement> {
+	@SuppressWarnings("unused")
 	private static final Logger log = LogManager.getLogger(StackElement.class);
 
 	private static final Number ZERO_INT = new Number(0);
diff --git a/src/main/java/it/unipr/cfg/Callblackbox.java b/src/main/java/it/unipr/cfg/Callblackbox.java
@@ -45,7 +45,6 @@ public <A extends AbstractState<A>> AnalysisState<A> forwardSemantics(AnalysisSt
 
 	@Override
 	protected int compareSameClass(Statement o) {
-		// TODO Auto-generated method stub
 		return 0;
 	}
 }
diff --git a/src/main/java/it/unipr/cfg/Coinbase.java b/src/main/java/it/unipr/cfg/Coinbase.java
@@ -51,7 +51,6 @@ CoinbaseOperator.INSTANCE, getLocation()),
 
 	@Override
 	protected int compareSameClass(Statement o) {
-		// TODO Auto-generated method stub
 		return 0;
 	}
 }
diff --git a/src/main/java/it/unipr/cfg/EVMCFG.java b/src/main/java/it/unipr/cfg/EVMCFG.java
@@ -36,6 +36,7 @@
 import org.apache.logging.log4j.Logger;
 
 public class EVMCFG extends CFG {
+	@SuppressWarnings("unused")
 	private static final Logger log = LogManager.getLogger(EVMCFG.class);
 
 	private Set<BasicBlock> _basicBlocks;
@@ -554,6 +555,7 @@ private boolean dfs(Statement start, Statement target, Set<Statement> visited) {
 	 * 
 	 * @return True if the target is reachable from the start, false otherwise.
 	 */
+	@SuppressWarnings("unused")
 	private boolean bfs(Statement start, Statement target, Set<Statement> visited) {
 		Queue<Statement> queue = new LinkedList<>();
 		queue.offer(start);
diff --git a/src/main/java/it/unipr/cfg/Getloca.java b/src/main/java/it/unipr/cfg/Getloca.java
@@ -45,7 +45,6 @@ public <A extends AbstractState<A>> AnalysisState<A> forwardSemantics(AnalysisSt
 
 	@Override
 	protected int compareSameClass(Statement o) {
-		// TODO Auto-generated method stub
 		return 0;
 	}
 }
diff --git a/src/main/java/it/unipr/cfg/Jumpif.java b/src/main/java/it/unipr/cfg/Jumpif.java
@@ -46,7 +46,6 @@ public <A extends AbstractState<A>> AnalysisState<A> forwardSemantics(AnalysisSt
 
 	@Override
 	protected int compareSameClass(Statement o) {
-		// TODO Auto-generated method stub
 		return 0;
 	}
 }
diff --git a/src/main/java/it/unipr/cfg/Jumpsubv.java b/src/main/java/it/unipr/cfg/Jumpsubv.java
@@ -46,7 +46,6 @@ public <A extends AbstractState<A>> AnalysisState<A> forwardSemantics(AnalysisSt
 
 	@Override
 	protected int compareSameClass(Statement o) {
-		// TODO Auto-generated method stub
 		return 0;
 	}
 }
diff --git a/src/main/java/it/unipr/cfg/Jumpto.java b/src/main/java/it/unipr/cfg/Jumpto.java
@@ -46,7 +46,6 @@ public <A extends AbstractState<A>> AnalysisState<A> forwardSemantics(AnalysisSt
 
 	@Override
 	protected int compareSameClass(Statement o) {
-		// TODO Auto-generated method stub
 		return 0;
 	}
 }
diff --git a/src/main/java/it/unipr/cfg/Lookup.java b/src/main/java/it/unipr/cfg/Lookup.java
@@ -45,7 +45,6 @@ public <A extends AbstractState<A>> AnalysisState<A> forwardSemantics(AnalysisSt
 
 	@Override
 	protected int compareSameClass(Statement o) {
-		// TODO Auto-generated method stub
 		return 0;
 	}
 }
diff --git a/src/main/java/it/unipr/cfg/Putlocal.java b/src/main/java/it/unipr/cfg/Putlocal.java
@@ -45,7 +45,6 @@ public <A extends AbstractState<A>> AnalysisState<A> forwardSemantics(AnalysisSt
 
 	@Override
 	protected int compareSameClass(Statement o) {
-		// TODO Auto-generated method stub
 		return 0;
 	}
 }
diff --git a/src/main/java/it/unipr/cfg/Returnsub.java b/src/main/java/it/unipr/cfg/Returnsub.java
@@ -45,7 +45,6 @@ public <A extends AbstractState<A>> AnalysisState<A> forwardSemantics(AnalysisSt
 
 	@Override
 	protected int compareSameClass(Statement o) {
-		// TODO Auto-generated method stub
 		return 0;
 	}
 }
diff --git a/src/main/java/it/unipr/cfg/Sloadbytes.java b/src/main/java/it/unipr/cfg/Sloadbytes.java
@@ -45,7 +45,6 @@ public <A extends AbstractState<A>> AnalysisState<A> forwardSemantics(AnalysisSt
 
 	@Override
 	protected int compareSameClass(Statement o) {
-		// TODO Auto-generated method stub
 		return 0;
 	}
 }
diff --git a/src/main/java/it/unipr/cfg/Sstorebytes.java b/src/main/java/it/unipr/cfg/Sstorebytes.java
@@ -45,7 +45,6 @@ public <A extends AbstractState<A>> AnalysisState<A> forwardSemantics(AnalysisSt
 
 	@Override
 	protected int compareSameClass(Statement o) {
-		// TODO Auto-generated method stub
 		return 0;
 	}
 }
diff --git a/src/main/java/it/unipr/cfg/Txexecgas.java b/src/main/java/it/unipr/cfg/Txexecgas.java
@@ -45,7 +45,6 @@ public <A extends AbstractState<A>> AnalysisState<A> forwardSemantics(AnalysisSt
 
 	@Override
 	protected int compareSameClass(Statement o) {
-		// TODO Auto-generated method stub
 		return 0;
 	}
 }
diff --git a/src/main/java/it/unipr/frontend/EVMFrontend.java b/src/main/java/it/unipr/frontend/EVMFrontend.java
@@ -16,6 +16,8 @@
 import java.io.InputStreamReader;
 import java.io.Writer;
 import java.net.HttpURLConnection;
+import java.net.URI;
+import java.net.URISyntaxException;
 import java.net.URL;
 import java.nio.charset.StandardCharsets;
 import org.antlr.v4.runtime.CharStreams;
@@ -680,7 +682,12 @@ public static String etherscanRequest(String module, String action, String addre
 		String request = String.format("https://api.etherscan.io/api?module=%s&action=%s&address=%s&apikey=%s", module,
 				action, address, API_KEY);
 
-		URL requestUrl = new URL(request);
+		URL requestUrl;
+		try {
+			requestUrl = new URI(request).toURL();
+		} catch (URISyntaxException e) {
+			return null;
+		}
 		HttpURLConnection connection = (HttpURLConnection) requestUrl.openConnection();
 		connection.setRequestMethod("GET");
 		connection.setRequestProperty("User-Agent", "Mozilla/5.0");
@@ -744,7 +751,12 @@ public static String etherscanRequest(String module, String action, String posit
 				"https://api.etherscan.io/api?module=%s&action=%s&address=%s&position=%s&apikey=%s", module,
 				action, address, position, API_KEY);
 
-		URL requestUrl = new URL(request);
+		URL requestUrl;
+		try {
+			requestUrl = new URI(request).toURL();
+		} catch (URISyntaxException e) {
+			return null;
+		}
 		HttpURLConnection connection = (HttpURLConnection) requestUrl.openConnection();
 		connection.setRequestMethod("GET");
 		connection.setRequestProperty("User-Agent", "Mozilla/5.0");
diff --git a/src/main/java/it/unipr/utils/EVMLiSAExecutor.java b/src/main/java/it/unipr/utils/EVMLiSAExecutor.java
@@ -14,6 +14,7 @@ public class EVMLiSAExecutor {
 	private static ExecutorService _executor = Executors.newFixedThreadPool(CORES);
 
 	private static long tasksInQueue = 0;
+	@SuppressWarnings("unused")
 	private static long tasksExecuted = 0;
 	private static long tasksTimedOut = 0;
 
diff --git a/src/test/java/it/unipr/analysis/cron/EVMBytecodeAnalysisExecutor.java b/src/test/java/it/unipr/analysis/cron/EVMBytecodeAnalysisExecutor.java
@@ -108,8 +108,7 @@ public void perform(
 		try {
 			program = readProgram(target);
 		} catch (IOException e) {
-			// TODO Auto-generated catch block
-			e.printStackTrace();
+			throw new RuntimeException("Unable to read program: " + e.getMessage(), e);
 		}
 
 		setupWorkdir(conf, actualPath);

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,6 @@ public <A extends AbstractState<A>> AnalysisState<A> forwardSemantics(AnalysisSt`
`45`	`45`
`46`	`46`	`@Override`
`47`	`47`	`protected int compareSameClass(Statement o) {`
`48`		`- // TODO Auto-generated method stub`
`49`	`48`	`return 0;`
`50`	`49`	`}`
`51`	`50`	`}`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,6 @@ CoinbaseOperator.INSTANCE, getLocation()),`
`51`	`51`
`52`	`52`	`@Override`
`53`	`53`	`protected int compareSameClass(Statement o) {`
`54`		`- // TODO Auto-generated method stub`
`55`	`54`	`return 0;`
`56`	`55`	`}`
`57`	`56`	`}`
Original file line number	Diff line number	Diff line change
`@@ -46,7 +46,6 @@ public <A extends AbstractState<A>> AnalysisState<A> forwardSemantics(AnalysisSt`
`46`	`46`
`47`	`47`	`@Override`
`48`	`48`	`protected int compareSameClass(Statement o) {`
`49`		`- // TODO Auto-generated method stub`
`50`	`49`	`return 0;`
`51`	`50`	`}`
`52`	`51`	`}`