Minor changes

Author: merendamattia

scripts/python/benchmark-checkers/compile-smart-contracts.py

@@ -378,8 +378,9 @@ def compile_bridge(name):
     args = parser.parse_args()
 
     if args.cross_chain:
+        compile_bridge('cross-chain/smartaxe/manually-labeled/LiFinance20220320')
         # compile_bridges('cross-chain/smartaxe/dataset')
-        compile_bridges('cross-chain/smartaxe/manually-labeled')
+        # compile_bridges('cross-chain/smartaxe/manually-labeled')
         # compile_bridge('cross-chain/time-synchronization')
         # compile_bridge('cross-chain/dummy-bridge')
 

scripts/python/benchmark-checkers/cross-chain.py

@@ -3,32 +3,33 @@
 import json
 import argparse
 import re
+import sys
 
 def move_solidity_files(base_dir):
     for root, dirs, files in os.walk(base_dir):
         if root == base_dir:
             continue  # Skip the base directory itself
-        
+
         # Determine the parent directory (bridge directory)
         parent_dir = os.path.dirname(root)
         source_code_dir = os.path.join(parent_dir, "source-code")
-        
+
         # Create 'source-code' directory if it does not exist
         os.makedirs(source_code_dir, exist_ok=True)
-        
+
         for file in files:
             if file.endswith(".sol"):
                 src_path = os.path.join(root, file)
                 dest_path = os.path.join(source_code_dir, file)
-                
+
                 # Handle duplicates by renaming files
                 counter = 1
                 while os.path.exists(dest_path):
                     file_name, file_ext = os.path.splitext(file)
                     new_file_name = f"{file_name}_{counter}{file_ext}"
                     dest_path = os.path.join(source_code_dir, new_file_name)
                     counter += 1
-                
+
                 shutil.move(src_path, dest_path)
                 print(f"Moved: {src_path} -> {dest_path}")
 
@@ -61,7 +62,7 @@ def analyze_vulnerabilities_bridge(json_path):
         num_contracts = bridge.get("number_of_contracts", "N/A")
         print(f"Bridge: {name}")
         print(f"  Number of contracts: {num_contracts}")
-        
+
         # Print aggregate vulnerability data
         aggregate_vulns = bridge.get("bridge_vulnerabilities", {})
         if not aggregate_vulns:
@@ -70,15 +71,15 @@ def analyze_vulnerabilities_bridge(json_path):
             print("  Aggregate vulnerabilities:")
             for key, value in aggregate_vulns.items():
                 print(f"    {key}: {value}")
-        
+
         # Print per-contract vulnerability data
         contracts_vulns = bridge.get("contract_vulnerabilities", [])
         if not contracts_vulns:
             print("  No contract vulnerability data available.")
         else:
             total_contracts = len(contracts_vulns)
             print(f"  Vulnerability data for {total_contracts} contracts:")
-            
+
             # Sum vulnerabilities per type across contracts
             total_vulnerabilities = {}
             for vuln_entry in contracts_vulns:
@@ -127,25 +128,25 @@ def simplify_imports_in_solidity_files(base_dir):
     Explores all .sol files in the given directory and removes folder paths from import statements.
     """
     solidity_file_pattern = re.compile(r'import\s+["\'](.+?/.+?)["\'];')
-    
+
     for root, _, files in os.walk(base_dir):
         for file in files:
             if file.endswith(".sol"):
                 file_path = os.path.join(root, file)
-                
+
                 with open(file_path, 'r', encoding='utf-8') as f:
                     content = f.read()
-                
+
                 # Replace import paths with only the file name
                 modified_content = solidity_file_pattern.sub(
                     lambda match: f'import "./{os.path.basename(match.group(1))}";',
                     content
                 )
-                
+
                 # Write the modified content back to the file
                 with open(file_path, 'w', encoding='utf-8') as f:
                     f.write(modified_content)
-                
+
                 print(f"Processed imports in: {file_path}")
 
 def simplify_named_imports(base_dir):
@@ -159,20 +160,20 @@ def simplify_named_imports(base_dir):
         for file in files:
             if file.endswith(".sol"):
                 file_path = os.path.join(root, file)
-                
+
                 with open(file_path, 'r', encoding='utf-8') as f:
                     content = f.read()
-                
+
                 # Replace import paths with only the file name
                 modified_content = solidity_named_import_pattern.sub(
                     lambda match: f'import {{{match.group(1).strip()}}} from "./{os.path.basename(match.group(2))}";',
                     content
                 )
-                
+
                 # Write the modified content back to the file
                 with open(file_path, 'w', encoding='utf-8') as f:
                     f.write(modified_content)
-                
+
                 print(f"Processed named imports in: {file_path}")
 
 def replace_specific_imports(base_dir):
@@ -194,30 +195,100 @@ def replace_specific_imports(base_dir):
         for file in files:
             if file.endswith(".sol"):
                 file_path = os.path.join(root, file)
-                
+
                 with open(file_path, 'r', encoding='utf-8') as f:
                     content = f.read()
-                
+
                 # Replace specific imports
                 modified_content = solidity_import_pattern.sub(
                     lambda match: f'import "{import_replacements[match.group(1)]}";'
                     if match.group(1) in import_replacements else match.group(0),
                     content
                 )
-                
+
                 # Write the modified content back to the file
                 with open(file_path, 'w', encoding='utf-8') as f:
                     f.write(modified_content)
-                
+
                 print(f"Processed imports in: {file_path}")
 
+def remove_duplicate_vulnerabilities(json_path):
+    """
+    Legge un file JSON, itera attraverso la struttura dati e rimuove le stringhe
+    duplicate dalla lista 'vulnerabilities' all'interno di ogni contratto.
+
+    Args:
+        json_path (str): Il percorso del file JSON di input.
+
+    Returns:
+        list or None: La struttura dati JSON modificata (lista di oggetti bridge)
+                      con le vulnerabilità duplicate rimosse, oppure None se
+                      si verifica un errore durante la lettura o il parsing
+                      o se il formato non è corretto.
+    """
+    try:
+        with open(json_path, "r", encoding="utf-8") as file:
+            data = json.load(file)
+    except FileNotFoundError:
+        print(f"Errore: File non trovato a '{json_path}'", file=sys.stderr)
+        return None
+    except json.JSONDecodeError as e:
+        print(f"Errore: Impossibile decodificare JSON da '{json_path}'. Dettagli: {e}", file=sys.stderr)
+        return None
+    except Exception as e:
+        print(f"Errore imprevisto durante la lettura di '{json_path}': {e}", file=sys.stderr)
+        return None
+
+    if not isinstance(data, list):
+        print(f"Errore: L'input JSON in '{json_path}' deve essere una lista di oggetti bridge.", file=sys.stderr)
+        return None
+
+    modified = False # Traccia se sono state fatte modifiche
+    for bridge in data:
+        # Controlla se 'contracts' esiste ed è una lista
+        if 'contracts' not in bridge or not isinstance(bridge['contracts'], list):
+            # Stampa un avviso se la struttura non è come previsto, ma continua
+            print(f"Attenzione: Bridge '{bridge.get('bridge', 'Sconosciuto')}' in '{json_path}' non ha una lista 'contracts' valida. Salto.", file=sys.stderr)
+            continue
+
+        for contract in bridge['contracts']:
+            # Controlla se 'vulnerabilities' esiste ed è una lista
+            if 'vulnerabilities' in contract and isinstance(contract['vulnerabilities'], list):
+                original_count = len(contract['vulnerabilities'])
+                # Usa dict.fromkeys per rimuovere duplicati mantenendo l'ordine
+                unique_vulnerabilities = list(dict.fromkeys(contract['vulnerabilities']))
+                if len(unique_vulnerabilities) < original_count:
+                    modified = True
+                contract['vulnerabilities'] = unique_vulnerabilities
+            # else: # Opzionale: Avvisa se la chiave vulnerabilities manca o non è una lista
+            #     print(f"Attenzione: Contratto '{contract.get('bytecode-name', 'Sconosciuto')}' nel bridge '{bridge.get('bridge', 'Sconosciuto')}' non ha una lista 'vulnerabilities' valida.", file=sys.stderr)
+
+    if not modified:
+         print(f"Nessuna vulnerabilità duplicata trovata da rimuovere in '{json_path}'.")
+
+    return data # Restituisce la struttura dati modificata (o originale se non c'erano duplicati)
+
+
 if __name__ == "__main__":
-    json_file_path = "benchmark_results.json"  
-    analyze_vulnerabilities(json_file_path)
+    json_file_path = "benchmark_results.json"
+    analyze_vulnerabilities_bridge(json_file_path)
 
-    base_directory = "cross-chain/smartaxe" 
+    # base_directory = "cross-chain/smartaxe"
     # move_solidity_files(base_directory)
     # rename_files_in_directory(base_directory)
     # simplify_imports_in_solidity_files(base_directory)
     # simplify_named_imports(base_directory)
-    # replace_specific_imports(base_directory)
+    # replace_specific_imports(base_directory)
+
+    # output_json_path = "benchmark_results_function_updated.json"
+    # modified_data = remove_duplicate_vulnerabilities("benchmark_results_function-missing-notification.json")
+
+    # output_json_str = json.dumps(modified_data, indent=4) # Use indent for pretty printing
+
+    # try:
+    #     with open(output_json_path, 'w', encoding='utf-8') as f:
+    #         f.write(output_json_str)
+    #     print(f"Successfully processed and saved modified JSON to '{output_json_path}'")
+    # except Exception as e:
+    #     print(f"Error writing output file '{output_json_path}': {e}")
+