Refactoring LiSAConfiguration to use public self-documenting fields

Author: lucaneg

lisa/lisa-core/src/main/java/it/unive/lisa/LiSA.java

@@ -52,12 +52,9 @@ public class LiSA {
 	 * @param conf the configuration of the analysis to run
 	 */
 	public LiSA(LiSAConfiguration conf) {
-		// since the warnings collection will be filled AFTER the execution of
-		// every concurrent bit has completed its execution, it is fine to use a
-		// non thread-safe one
 		this.warnings = new ArrayList<>();
 		this.conf = conf;
-		this.fileManager = new FileManager(conf.getWorkdir());
+		this.fileManager = new FileManager(conf.workdir);
 	}
 
 	/**
@@ -74,25 +71,25 @@ public void run(Program... programs) throws AnalysisException {
 
 		CallGraph callGraph;
 		try {
-			callGraph = conf.getCallGraph() == null ? getDefaultFor(CallGraph.class) : conf.getCallGraph();
-			if (conf.getCallGraph() == null)
+			callGraph = conf.callGraph == null ? getDefaultFor(CallGraph.class) : conf.callGraph;
+			if (conf.callGraph == null)
 				LOG.warn("No call graph set for this analysis, defaulting to {}", callGraph.getClass().getSimpleName());
 		} catch (AnalysisSetupException e) {
 			throw new AnalysisExecutionException("Unable to create default call graph", e);
 		}
 
 		InterproceduralAnalysis interproc;
 		try {
-			interproc = conf.getInterproceduralAnalysis() == null ? getDefaultFor(InterproceduralAnalysis.class)
-					: conf.getInterproceduralAnalysis();
-			if (conf.getInterproceduralAnalysis() == null)
+			interproc = conf.interproceduralAnalysis == null ? getDefaultFor(InterproceduralAnalysis.class)
+					: conf.interproceduralAnalysis;
+			if (conf.interproceduralAnalysis == null)
 				LOG.warn("No interprocedural analysis set for this analysis, defaulting to {}",
 						interproc.getClass().getSimpleName());
 		} catch (AnalysisSetupException e) {
 			throw new AnalysisExecutionException("Unable to create default interprocedural analysis", e);
 		}
 
-		LiSARunner runner = new LiSARunner(conf, interproc, callGraph, conf.getAbstractState());
+		LiSARunner runner = new LiSARunner(conf, interproc, callGraph, conf.abstractState);
 		Application app = new Application(programs);
 
 		try {
@@ -103,7 +100,7 @@ public void run(Program... programs) throws AnalysisException {
 
 		printStats();
 
-		if (conf.isJsonOutput()) {
+		if (conf.jsonOutput) {
 			LOG.info("Dumping reported warnings to 'report.json'");
 			JsonReport report = new JsonReport(warnings, fileManager.createdFiles());
 			try {